From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, <ziy@nvidia.com>,
<linux-mm@kvack.org>
Subject: Re: [PATCH] mm: memory: use nth_page() in clear/copy_subpage()
Date: Wed, 3 Jan 2024 14:23:14 +0800 [thread overview]
Message-ID: <8d941161-6433-44c4-9064-b3bb346edf2c@huawei.com> (raw)
In-Reply-To: <747e1c4e-6339-4b11-aaf9-9f8c4a428d66@redhat.com>
On 2024/1/3 0:11, David Hildenbrand wrote:
> On 02.01.24 07:53, Kefeng Wang wrote:
>>
>>
>> On 2023/12/29 19:15, David Hildenbrand wrote:
>>> On 29.12.23 09:49, Matthew Wilcox wrote:
>>>> On Fri, Dec 29, 2023 at 04:22:07PM +0800, Kefeng Wang wrote:
>>>>> The clear and copy of huge gigantic page has converted to use
>>>>> nth_page()
>>>>> to handle the possible discontinuous struct page(SPARSEMEM without
>>>>> VMEMMAP),
>>>>> but not change for the non-gigantic part, fix it too.
>>>>
>>>> Can there be discontiguities within a non-gigantic huge page? My
>>>> impression was that you can't have a discontiguity at such a small
>>>> boundary.
>>>
>>> No, we can't. MAX_ORDER allocations from the buddy always completely fit
>>> into a memory section.
>>
>> On ARM64, we have 32M(16*2M) HugeTLB, it maybe not within a mem section,
>> right?
>
> I recall the mem sections are always at least 128 MiB on arm64.
>
> Note that anything > MAX_ORDER is called a "gigantic huge page" in
> hugetlb code.
Yes, we already check MAX_ORDER, please ignore this one, thanks.
>
>
prev parent reply other threads:[~2024-01-03 6:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 8:22 [PATCH] mm: memory: use nth_page() in clear/copy_subpage() Kefeng Wang
2023-12-29 8:49 ` Matthew Wilcox
2023-12-29 11:15 ` David Hildenbrand
2024-01-02 6:53 ` Kefeng Wang
2024-01-02 16:11 ` David Hildenbrand
2024-01-03 6:23 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d941161-6433-44c4-9064-b3bb346edf2c@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).