From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20308C10F14 for ; Thu, 3 Oct 2019 11:50:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DA622218DE for ; Thu, 3 Oct 2019 11:50:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="O020jbcr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA622218DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 505C46B0005; Thu, 3 Oct 2019 07:50:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B8DF6B0006; Thu, 3 Oct 2019 07:50:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A63C6B0007; Thu, 3 Oct 2019 07:50:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id 1D5FC6B0005 for ; Thu, 3 Oct 2019 07:50:35 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id A31C7180AD801 for ; Thu, 3 Oct 2019 11:50:34 +0000 (UTC) X-FDA: 76002305988.29.trade71_3f2e77081a263 X-HE-Tag: trade71_3f2e77081a263 X-Filterd-Recvd-Size: 3885 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Oct 2019 11:50:34 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id u22so3049059qtq.13 for ; Thu, 03 Oct 2019 04:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=4tYmUjoUlo2Xqo/y5um3PxrT1tlXAA1LkGIE6UYEn3o=; b=O020jbcrUFhT7KwwXQCB/2LZrgQ+ScGaUJxYQJ/UuGXHx2SvPAyvqKmcIkaW13VAA7 0QKaEXVjzDGCa867Z/x9JT5clpj3l07TR55z5aY6NMqDYXkRP+KsNuCA22pth51J9uRR Q4xOrykegrbfbsZjzuQfdrJEqNqNO6pdllyYbgdDDIO7sajMeLiwLk5dOylA1ZlRVKXk dnWiCVIP5y1KM7T2D8ioH6xpVZqtZddeDeGIg1VnZ7B8aytHmivwXZVq2KXEkGzHlBJ5 ZMYd5vnhGsnCRfRF1M7OLCWex4QYZzn6YSnDMRy2A58jnM5SYCgA9dEp/2GX2YvQEup7 RwuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=4tYmUjoUlo2Xqo/y5um3PxrT1tlXAA1LkGIE6UYEn3o=; b=OcpcufTza1R4Ato+0X+uZt6JCUa4oeh2MLhd1Z00lw7YVFsiQ5pZ/1Pu3NpE48tSZi BPLyDMIOj3xRp0S+Y0Dv3t1p1bP0OUbyWlDFKhPbzLya9gqM1wXmmFEHiY6PJmRd1SLm cN7VsKCRffkkmYFn0EquG6PlXwah5hvflaUXE+scOBiCu9bNUrCHUAOsYXBSbCoFCcsW S1yJt/51qmdaI8IXWtokc+vAOP9H9ls1EouU+MqTQ2RQ8gcajtXwuPP2EKtkJzi3t0FW /eQoxlLW00sC5nP0RUBRJb7J3QJTKY51e+wJXbhGdWoD1vy1CRlo2nLOfA/F6nlaO/gE yTUg== X-Gm-Message-State: APjAAAVeQeBeuLzA1Cj0ZIn5/0G7sCXcoAmMeLnhh6MVaO6P1QgKx6R/ BS//COZ2Y8W/t+ThKNEZsHSHzw== X-Google-Smtp-Source: APXvYqwVwqVvYGwiskRdDpkyuODvgkHB5LyrTXwGoZJb7/HmZY3p+AKlv9WZlAn53Q3l7PTr0EWa/A== X-Received: by 2002:a0c:8867:: with SMTP id 36mr8044088qvm.177.1570103433376; Thu, 03 Oct 2019 04:50:33 -0700 (PDT) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id z12sm1464699qkg.97.2019.10.03.04.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2019 04:50:32 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages() Date: Thu, 3 Oct 2019 07:50:31 -0400 Message-Id: <983E7EA4-A022-448C-B11D-8C10441A2E07@lca.pw> References: Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Vlastimil Babka , Oscar Salvador , Mel Gorman , Mike Rapoport , Dan Williams , Pavel Tatashin , linux-kernel@vger.kernel.org In-Reply-To: To: Anshuman Khandual X-Mailer: iPhone Mail (17A844) X-Bogosity: Ham, tests=bogofilter, spamicity=0.001655, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Oct 3, 2019, at 7:31 AM, Anshuman Khandual w= rote: >=20 > Ohh, never meant that the 'Reserved' bit is anything special here but it > is a reason to make a page unmovable unlike many other flags. But dump_page() is used everywhere, and it is better to reserve =E2=80=9Crea= son=E2=80=9D to indicate something more important rather than duplicating th= e page flags. Especially, it is trivial enough right now for developers look in the page f= lags dumping from has_unmovable_pages(), and figure out the exact branching i= n the code.=