From: Jeff Layton <jlayton@kernel.org>
To: David Howells <dhowells@redhat.com>,
Christian Brauner <christian@brauner.io>,
Gao Xiang <hsiangkao@linux.alibaba.com>,
Dominique Martinet <asmadeus@codewreck.org>
Cc: Steve French <smfrench@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Marc Dionne <marc.dionne@auristor.com>,
Paulo Alcantara <pc@manguebit.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
Eric Van Hensbergen <ericvh@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
linux-cachefs@redhat.com, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
ceph-devel@vger.kernel.org, v9fs@lists.linux.dev,
linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] netfs, cachefiles: More additional patches
Date: Tue, 09 Jan 2024 13:37:11 -0500 [thread overview]
Message-ID: <999b36cc66c9682d78206b4e67be70889c7b11f8.camel@kernel.org> (raw)
In-Reply-To: <20240109112029.1572463-1-dhowells@redhat.com>
On Tue, 2024-01-09 at 11:20 +0000, David Howells wrote:
> Hi Christian, Jeff, Gao,
>
> Here are some additional patches for my netfs-lib tree:
>
> (1) Mark netfs_unbuffered_write_iter_locked() static as it's only used in
> the file in which it is defined.
>
> (2) Display a counter for DIO writes in /proc/fs/netfs/stats.
>
> (3) Fix the interaction between write-streaming (dirty data in
> non-uptodate pages) and the culling of a cache file trying to write
> that to the cache.
>
> (4) Fix the loop that unmarks folios after writing to the cache. The
> xarray iterator only advances the index by 1, so if we unmarked a
> multipage folio and that got split before we advance to the next
> folio, we see a repeat of a fragment of the folio.
>
> (5) Fix a mixup with signed/unsigned offsets when prepping for writing to
> the cache that leads to missing error detection.
>
> (6) Fix a wrong ifdef hiding a wait.
>
> David
>
> The netfslib postings:
> Link: https://lore.kernel.org/r/20231013160423.2218093-1-dhowells@redhat.com/ # v1
> Link: https://lore.kernel.org/r/20231117211544.1740466-1-dhowells@redhat.com/ # v2
> Link: https://lore.kernel.org/r/20231207212206.1379128-1-dhowells@redhat.com/ # v3
> Link: https://lore.kernel.org/r/20231213152350.431591-1-dhowells@redhat.com/ # v4
> Link: https://lore.kernel.org/r/20231221132400.1601991-1-dhowells@redhat.com/ # v5
> Link: https://lore.kernel.org/r/20240103145935.384404-1-dhowells@redhat.com/ # added patches
>
> David Howells (6):
> netfs: Mark netfs_unbuffered_write_iter_locked() static
> netfs: Count DIO writes
> netfs: Fix interaction between write-streaming and cachefiles culling
> netfs: Fix the loop that unmarks folios after writing to the cache
> cachefiles: Fix signed/unsigned mixup
> netfs: Fix wrong #ifdef hiding wait
>
> fs/cachefiles/io.c | 18 +++++++++---------
> fs/netfs/buffered_write.c | 27 ++++++++++++++++++++++-----
> fs/netfs/direct_write.c | 5 +++--
> fs/netfs/fscache_stats.c | 9 ++++++---
> fs/netfs/internal.h | 8 ++------
> fs/netfs/io.c | 2 +-
> fs/netfs/stats.c | 13 +++++++++----
> include/linux/fscache-cache.h | 3 +++
> include/linux/netfs.h | 1 +
> 9 files changed, 56 insertions(+), 30 deletions(-)
>
These all look fine to me. You can add:
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2024-01-09 18:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 11:20 [PATCH 0/6] netfs, cachefiles: More additional patches David Howells
2024-01-09 11:20 ` [PATCH 1/6] netfs: Mark netfs_unbuffered_write_iter_locked() static David Howells
2024-01-09 11:20 ` [PATCH 2/6] netfs: Count DIO writes David Howells
2024-01-09 11:20 ` [PATCH 3/6] netfs: Fix interaction between write-streaming and cachefiles culling David Howells
2024-01-09 11:20 ` [PATCH 4/6] netfs: Fix the loop that unmarks folios after writing to the cache David Howells
2024-01-09 11:20 ` [PATCH 5/6] cachefiles: Fix signed/unsigned mixup David Howells
2024-01-09 13:03 ` Gao Xiang
2024-01-10 12:05 ` [External] " Jia Zhu
2024-01-09 11:20 ` [PATCH 6/6] netfs: Fix wrong #ifdef hiding wait David Howells
2024-01-09 17:11 ` [PATCH 0/6] netfs, cachefiles: More additional patches Marc Dionne
2024-01-09 18:37 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=999b36cc66c9682d78206b4e67be70889c7b11f8.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=ceph-devel@vger.kernel.org \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=ericvh@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=idryomov@gmail.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).