From: maobibo <maobibo@loongson.cn>
To: "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Huacai Chen" <chenhc@lemote.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Paul Burton" <paulburton@kernel.org>,
"Dmitry Korotin" <dkorotin@wavecomp.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Stafford Horne" <shorne@gmail.com>,
"Steven Price" <steven.price@arm.com>,
"Anshuman Khandual" <anshuman.khandual@arm.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Rapoport <rppt@linux.ibm.com>,
"Maciej W. Rozycki" <macro@wdc.com>,
linux-mm@kvack.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v6 1/4] MIPS: Do not flush tlb page when updating PTE entry
Date: Wed, 27 May 2020 09:07:57 +0800 [thread overview]
Message-ID: <9b71761b-a744-086f-43f5-78dcca18b459@loongson.cn> (raw)
In-Reply-To: <0a38f25d-dba0-688f-4588-345c861325aa@cogentembedded.com>
On 05/25/2020 04:31 PM, Sergei Shtylyov wrote:
> On 25.05.2020 11:12, Sergei Shtylyov wrote:
>
>>> It is not necessary to flush tlb page on all CPUs if suitable PTE
>>> entry exists already during page fault handling, just updating
>>> TLB is fine.
>>>
>>> Here redefine flush_tlb_fix_spurious_fault as empty on MIPS system.
>>
>> Need empty line here.
>>
>>> V6:
>>> - Add update_mmu_tlb function as empty on all platform except mips
>>> system, we use this function to update local tlb for page fault
>>> smp-race handling
>>> V5:
>>> - define update_mmu_cache function specified on MIPS platform, and
>>> add page fault smp-race stats info
>>> V4:
>>> - add pte_sw_mkyoung function to implement readable privilege, and
>>> this function is only in effect on MIPS system.
>>> - add page valid bit judgement in function pte_modify
>>> V3:
>>> - add detailed changelog, modify typo issue in patch V2
>>> v2:
>>> - split flush_tlb_fix_spurious_fault and tlb update into two patches
>>> - comments typo modification
>>> - separate tlb update and add pte readable privilege into two patches
>>
>> It was a bad idea to keep the version change log in the 1st patch only,
>> we have either cover letter for that, or all the individual patches...
>
> Sorry for noticing this only now. With 4 patches, you should have a cover letter anyway...
Thanks for reviewing my patch, a cover letter will be added.
>
>>> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
>> [...]
>
> MBR, Sergei
next prev parent reply other threads:[~2020-05-27 1:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 2:52 [PATCH v6 1/4] MIPS: Do not flush tlb page when updating PTE entry Bibo Mao
2020-05-25 2:52 ` [PATCH v6 2/4] mm/memory.c: Update local TLB if PTE entry exists Bibo Mao
2020-05-25 21:43 ` Andrew Morton
2020-05-25 2:52 ` [PATCH v6 3/4] mm/memory.c: Add memory read privilege on page fault handling Bibo Mao
2020-05-25 21:44 ` Andrew Morton
2020-05-27 1:05 ` maobibo
2020-05-27 7:10 ` Thomas Bogendoerfer
2020-05-25 2:52 ` [PATCH v6 4/4] MIPS: mm: add page valid judgement in function pte_modify Bibo Mao
2020-05-25 8:12 ` [PATCH v6 1/4] MIPS: Do not flush tlb page when updating PTE entry Sergei Shtylyov
2020-05-25 8:31 ` Sergei Shtylyov
2020-05-27 1:07 ` maobibo [this message]
2020-05-25 21:42 ` Andrew Morton
2020-05-27 1:06 ` maobibo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b71761b-a744-086f-43f5-78dcca18b459@loongson.cn \
--to=maobibo@loongson.cn \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=chenhc@lemote.com \
--cc=david@redhat.com \
--cc=dkorotin@wavecomp.com \
--cc=f4bug@amsat.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=macro@wdc.com \
--cc=paulburton@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=shorne@gmail.com \
--cc=steven.price@arm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).