From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55A57C388F9 for ; Fri, 23 Oct 2020 17:00:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A966720E65 for ; Fri, 23 Oct 2020 17:00:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V+Gg9uIC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A966720E65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C6FD76B0071; Fri, 23 Oct 2020 13:00:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C20FD6B0072; Fri, 23 Oct 2020 13:00:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE9716B0073; Fri, 23 Oct 2020 13:00:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 81AB96B0071 for ; Fri, 23 Oct 2020 13:00:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 249DC8249980 for ; Fri, 23 Oct 2020 17:00:24 +0000 (UTC) X-FDA: 77403803568.27.owl82_110a4542725b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 0201E3D66B for ; Fri, 23 Oct 2020 17:00:23 +0000 (UTC) X-HE-Tag: owl82_110a4542725b X-Filterd-Recvd-Size: 9031 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 23 Oct 2020 17:00:23 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id p10so2042596ile.3 for ; Fri, 23 Oct 2020 10:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=o1VEizSN6TM+raklNtIXpsapMZWxETouBV0mamAPQo0=; b=V+Gg9uICyKn5tIe46atfWAON+AixWQBBQ6Pn1mKsJ9LTyk3eEKENj8UdU0jz8oEJ/T iY3pDKKGEDsjM5zsL71qeD2upMbTwf/0oJPU2qhreG0VoH8Btr+eBgBDvB9g58CZSQ96 Sgr8eEMx01tJ+JJaSGqxsdIW8XuWtidjH3RUren590Av2KVvyiUDBkwd3pzRSI5r/akg 4Be7/bT6OAM0TaD6IR1KR8VzV6ouQZqBCGjLPr0uzK1WtJoC3shbqQqA3Z4hhhb9EDl9 hZ/RmeUyYqgXTzKPMWN2s3dmpVJISsGiyopT/jpiQLJijpHH+ZJruUA+qldH7HfKM+2Z DsWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=o1VEizSN6TM+raklNtIXpsapMZWxETouBV0mamAPQo0=; b=DPLeB8gMSn6VKZxFuo8C7KkOhuWsgsSIPJxLrQaLPWJ4iPdwsAugEbfLqtTTWOboKc VU9NRy3MEVaPpQ/XmFWW+j+jwiJcGUqgi5CZSUnXyUlFErBqhoTLt4iDS5x5PbAMZ7Hc a1a47sbXuUn5s3efANK1QZ2lrd7ZEHfcO1JyxVEqokjeEKzK6siDx2L0pK8bFTk+rXPA TzN+ymMVEojLiaQegSq76D0Che2l/i0K3/zu/vbL4eUvc6ulmcaVyuqvKq77aQEool3t 81WeaqLS/7Y3ytKLCud02VNQtk7JKm+wq1JWGCBjZ2WgBvP2OBBQgI/He7ll9C/nrkL/ 6dFQ== X-Gm-Message-State: AOAM53177gofH3F20t8YrcK1Z7vlue5Io6FfXCcCCDw6WNWYINSFLM+6 LcolYk8NYGT9c5rSEpjLG/2ccJJPc/IaMjMO5qteVw== X-Google-Smtp-Source: ABdhPJwrgJp/OuJrOp+n+UP8gE/pj8wa+8lsTQ0hX8+Y+rO4ME9yioa2pi9mLHL+KrbDWGnIoZjFUeIWTh+m6MuqhEo= X-Received: by 2002:a92:b6d2:: with SMTP id m79mr1190406ill.216.1603472422474; Fri, 23 Oct 2020 10:00:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Naresh Kamboju Date: Fri, 23 Oct 2020 22:30:11 +0530 Message-ID: Subject: Re: [LTP] mmstress[1309]: segfault at 7f3d71a36ee8 ip 00007f3d77132bdf sp 00007f3d71a36ee8 error 4 in libc-2.27.so[7f3d77058000+1aa000] To: Linus Torvalds Cc: =?UTF-8?B?RGFuaWVsIETDrWF6?= , Stephen Rothwell , "Matthew Wilcox (Oracle)" , "Peter Zijlstra (Intel)" , Viresh Kumar , X86 ML , open list , lkft-triage@lists.linaro.org, "Eric W. Biederman" , linux-mm , linux-m68k , Linux-Next Mailing List , Thomas Gleixner , kasan-dev , Dmitry Vyukov , Geert Uytterhoeven , Christian Brauner , Ingo Molnar , LTP List , Al Viro Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 23 Oct 2020 at 08:35, Linus Torvalds wrote: > > On Thu, Oct 22, 2020 at 6:36 PM Daniel D=C3=ADaz = wrote: > > > > The kernel Naresh originally referred to is here: > > https://builds.tuxbuild.com/SCI7Xyjb7V2NbfQ2lbKBZw/ > > is unnecessary (because the 8-byte case is still just a single > register, no %eax:%edx games needed), it would be interesting to hear > if the attached patch fixes it. That would confirm that the problem > really is due to some register allocation issue interaction (or, > alternatively, it would tell me that there's something else going on). [Old patch from yesterday] After applying your patch on top on linux next tag 20201015 there are two observations, 1) i386 build failed. please find build error build 2) x86_64 kasan test PASS and the reported error not found. i386 build failure, ---------------------- make -sk KBUILD_BUILD_USER=3DTuxBuild -C/linux -j16 ARCH=3Di386 HOSTCC=3Dgc= c CC=3D"sccache gcc" O=3Dbuild # In file included from ../include/linux/uaccess.h:11, from ../arch/x86/include/asm/fpu/xstate.h:5, from ../arch/x86/include/asm/pgtable.h:26, from ../include/linux/pgtable.h:6, from ../include/linux/mm.h:33, from ../include/linux/memblock.h:13, from ../fs/proc/page.c:2: ../fs/proc/page.c: In function =E2=80=98kpagecgroup_read=E2=80=99: ../arch/x86/include/asm/uaccess.h:217:2: error: inconsistent operand constraints in an =E2=80=98asm=E2=80=99 217 | asm volatile("call __" #fn "_%P[size]" \ | ^~~ ../arch/x86/include/asm/uaccess.h:244:44: note: in expansion of macro =E2=80=98do_put_user_call=E2=80=99 244 | #define put_user(x, ptr) ({ might_fault(); do_put_user_call(put_user,x,ptr); }) | ^~~~~~~~~~~~~~~~ ../fs/proc/page.c:307:7: note: in expansion of macro =E2=80=98put_user=E2= =80=99 307 | if (put_user(ino, out)) { | ^~~~~~~~ make[3]: *** [../scripts/Makefile.build:283: fs/proc/page.o] Error 1 make[3]: Target '__build' not remade because of errors. make[2]: *** [../scripts/Makefile.build:500: fs/proc] Error 2 In file included from ../include/linux/uaccess.h:11, from ../include/linux/sched/task.h:11, from ../include/linux/sched/signal.h:9, from ../include/linux/rcuwait.h:6, from ../include/linux/percpu-rwsem.h:7, from ../include/linux/fs.h:33, from ../include/linux/cgroup.h:17, from ../include/linux/memcontrol.h:13, from ../include/linux/swap.h:9, from ../include/linux/suspend.h:5, from ../kernel/power/user.c:10: ../kernel/power/user.c: In function =E2=80=98snapshot_ioctl=E2=80=99: ../arch/x86/include/asm/uaccess.h:217:2: error: inconsistent operand constraints in an =E2=80=98asm=E2=80=99 217 | asm volatile("call __" #fn "_%P[size]" \ | ^~~ ../arch/x86/include/asm/uaccess.h:244:44: note: in expansion of macro =E2=80=98do_put_user_call=E2=80=99 244 | #define put_user(x, ptr) ({ might_fault(); do_put_user_call(put_user,x,ptr); }) | ^~~~~~~~~~~~~~~~ ../kernel/power/user.c:340:11: note: in expansion of macro =E2=80=98put_use= r=E2=80=99 340 | error =3D put_user(size, (loff_t __user *)arg); | ^~~~~~~~ ../arch/x86/include/asm/uaccess.h:217:2: error: inconsistent operand constraints in an =E2=80=98asm=E2=80=99 217 | asm volatile("call __" #fn "_%P[size]" \ | ^~~ ../arch/x86/include/asm/uaccess.h:244:44: note: in expansion of macro =E2=80=98do_put_user_call=E2=80=99 244 | #define put_user(x, ptr) ({ might_fault(); do_put_user_call(put_user,x,ptr); }) | ^~~~~~~~~~~~~~~~ ../kernel/power/user.c:346:11: note: in expansion of macro =E2=80=98put_use= r=E2=80=99 346 | error =3D put_user(size, (loff_t __user *)arg); | ^~~~~~~~ ../arch/x86/include/asm/uaccess.h:217:2: error: inconsistent operand constraints in an =E2=80=98asm=E2=80=99 217 | asm volatile("call __" #fn "_%P[size]" \ | ^~~ ../arch/x86/include/asm/uaccess.h:244:44: note: in expansion of macro =E2=80=98do_put_user_call=E2=80=99 244 | #define put_user(x, ptr) ({ might_fault(); do_put_user_call(put_user,x,ptr); }) | ^~~~~~~~~~~~~~~~ ../kernel/power/user.c:357:12: note: in expansion of macro =E2=80=98put_use= r=E2=80=99 357 | error =3D put_user(offset, (loff_t __user *)arg); | ^~~~~~~~ x86_64 Kasan tested and the reported issue not found. https://lkft.validation.linaro.org/scheduler/job/1868029#L2374 - Naresh