From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF1E9C433E0 for ; Wed, 10 Jun 2020 03:11:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 68D4C2076A for ; Wed, 10 Jun 2020 03:11:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fRVONKp+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68D4C2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 03F2B6B0002; Tue, 9 Jun 2020 23:11:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F31C96B0005; Tue, 9 Jun 2020 23:11:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E20E86B0006; Tue, 9 Jun 2020 23:11:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id C6D336B0002 for ; Tue, 9 Jun 2020 23:11:51 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 728D1181ABEA5 for ; Wed, 10 Jun 2020 03:11:51 +0000 (UTC) X-FDA: 76911827622.20.angle06_420469726dc7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id D81AE180C07AB for ; Wed, 10 Jun 2020 03:11:50 +0000 (UTC) X-HE-Tag: angle06_420469726dc7 X-Filterd-Recvd-Size: 3998 Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Jun 2020 03:11:50 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id x16so421022qvr.3 for ; Tue, 09 Jun 2020 20:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PCGE0i5jShj8XCDSt3k7yuWmEi5dY5Ug2+/GmDjxlYg=; b=fRVONKp+S7uG//pRPspo5Nrf6ifu8rHa/DU2rAa4lAHzRZGIe/nDBoa8miLk7F6Icc VEVIk+U45HDrEklck8Ov0E4Y5iQEzvA8bfRjmMvRusZWQnJjJmcoAKUa78MkOm0XoTwY QVrUP8RIVEyXgf4KrBLCirjjMlJJgCmDHwKfI35ATFvI3Xz4VbUbYepbO5Lzjjv4nXao oMFd38agVxpYwuoMJKajIs81MFDfLavTEx3UJ2sV8TOL0EexI7p5jqzMpgFC4het1G8e 3/bQpoAQG10F6WnkKbpwi1Mc3+Y49jUaFNFElZdQ8PE8EKwvFQuBjnMOM4iRb99bFLL8 GGqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PCGE0i5jShj8XCDSt3k7yuWmEi5dY5Ug2+/GmDjxlYg=; b=ioMnRaBOFtpVPlcznYJ/Knh/xkmExYOv4Nf+yMGyXZ3SUUyoqCxghiIjbO8BvUtZqB e932Zt8aiMH3OtgeMWP1MAxGExF0dcq2sT1F/FHKXokxMhGpEuDBsWBlw6Fk7/6kIn8g DIqmvqvBjJcTI1YakxiM4GkjqwZgks5s8bBYVMU/S08Z60u3AnoqOjF/AzElpJW5pWdR QMAIHJDsJLYsvChU+yXhDZVWESd5I6GEqgD6HKp7RzxPpYOas0vUS0o+UeEhl9GGuSZ6 c1eEQKg4fr6rJ/mFL2XAmXQ3Q1fo04vWMcLSwiib52JPLIZUW2XPmF0BYVpik3Qw0A+g z3ig== X-Gm-Message-State: AOAM530jrlzWc10b442un8tbMqpu2L6Vz0aFgynyhbgjCwrMnr7pmHNB JXZ/ol29yDHFoE3RXFTm2rCJRjU135lvOCvjzmw= X-Google-Smtp-Source: ABdhPJxhrkEWfhv5QuiXBId0hcpxjE7i5N03/xqjKk6WQVwWEDDrUdbOkfB47BYSeQXEPEaokNih1g1UoY3KjvI9flo= X-Received: by 2002:ad4:4d04:: with SMTP id l4mr1277779qvl.88.1591758709588; Tue, 09 Jun 2020 20:11:49 -0700 (PDT) MIME-Version: 1.0 References: <1590561903-13186-1-git-send-email-iamjoonsoo.kim@lge.com> <1590561903-13186-6-git-send-email-iamjoonsoo.kim@lge.com> <20200609134309.GG22623@dhcp22.suse.cz> In-Reply-To: <20200609134309.GG22623@dhcp22.suse.cz> From: Joonsoo Kim Date: Wed, 10 Jun 2020 12:11:35 +0900 Message-ID: Subject: Re: [PATCH v2 05/12] mm/hugetlb: unify hugetlb migration callback function To: Michal Hocko Cc: Andrew Morton , Linux Memory Management List , LKML , kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D81AE180C07AB X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 6=EC=9B=94 9=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 10:43, M= ichal Hocko =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Wed 27-05-20 15:44:56, Joonsoo Kim wrote: > [...] > > -/* page migration callback function */ > > struct page *alloc_huge_page_nodemask(struct hstate *h, > > struct alloc_control *ac) > > { > > ac->gfp_mask |=3D htlb_alloc_mask(h); > > + if (ac->nid =3D=3D NUMA_NO_NODE) > > + ac->gfp_mask &=3D ~__GFP_THISNODE; > > Is this really needed? alloc_huge_page_node is currently only called > from numa migration code and the target node should be always defined. Thanks! When I read the code, I was not sure that the target node is always defined so I left this code. However, if it's true, this code isn't needed at all. I will consider your suggestion in the next version. Thanks.