From: Pengfei Li <lpf.vector@gmail.com>
To: Roman Gushchin <guro@fb.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"vbabka@suse.cz" <vbabka@suse.cz>, "cl@linux.com" <cl@linux.com>,
"penberg@kernel.org" <penberg@kernel.org>,
"rientjes@google.com" <rientjes@google.com>,
"iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] mm, slab_common: Make 'type' is enum kmalloc_cache_type
Date: Tue, 10 Sep 2019 08:59:20 +0800 [thread overview]
Message-ID: <CAD7_sbHgfNB-rYQ=uOGL14Pmf8VgChbnwh804r8LT_o73iH4Hg@mail.gmail.com> (raw)
In-Reply-To: <20190909195955.GA2181@tower.dhcp.thefacebook.com>
On Tue, Sep 10, 2019 at 4:00 AM Roman Gushchin <guro@fb.com> wrote:
>
> On Tue, Sep 10, 2019 at 01:07:14AM +0800, Pengfei Li wrote:
>
> Hi Pengfei!
>
> > The 'type' of the function new_kmalloc_cache should be
> > enum kmalloc_cache_type instead of int, so correct it.
>
> I think you mean type of the 'i' variable, not the type of
> new_kmalloc_cache() function. Also the name of the patch is
> misleading. How about
> mm, slab_common: use enum kmalloc_cache_type to iterate over kmalloc caches ?
> Or something like this.
>
Ok, this name is really better :)
> The rest of the series looks good to me.
>
> Please, feel free to use
> Acked-by: Roman Gushchin <guro@fb.com>
> for patches [1-3] in the series after fixing this commit message and
> restoring __initconst.
>
Thanks!
> Patch [4] needs some additional clarifications, IMO.
>
I will add more clarification in v3.
> Thank you!
>
> >
> > Signed-off-by: Pengfei Li <lpf.vector@gmail.com>
> > Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
>
>
> > ---
> > mm/slab_common.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/slab_common.c b/mm/slab_common.c
> > index cae27210e4c3..d64a64660f86 100644
> > --- a/mm/slab_common.c
> > +++ b/mm/slab_common.c
> > @@ -1192,7 +1192,7 @@ void __init setup_kmalloc_cache_index_table(void)
> > }
> >
> > static void __init
> > -new_kmalloc_cache(int idx, int type, slab_flags_t flags)
> > +new_kmalloc_cache(int idx, enum kmalloc_cache_type type, slab_flags_t flags)
> > {
> > if (type == KMALLOC_RECLAIM)
> > flags |= SLAB_RECLAIM_ACCOUNT;
> > @@ -1210,7 +1210,8 @@ new_kmalloc_cache(int idx, int type, slab_flags_t flags)
> > */
> > void __init create_kmalloc_caches(slab_flags_t flags)
> > {
> > - int i, type;
> > + int i;
> > + enum kmalloc_cache_type type;
> >
> > for (type = KMALLOC_NORMAL; type <= KMALLOC_RECLAIM; type++) {
> > for (i = KMALLOC_SHIFT_LOW; i <= KMALLOC_SHIFT_HIGH; i++) {
> > --
> > 2.21.0
> >
> >
next prev parent reply other threads:[~2019-09-10 0:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 17:07 [PATCH v2 0/4] mm, slab: Make kmalloc_info[] contain all types of names Pengfei Li
2019-09-09 17:07 ` [PATCH v2 1/4] " Pengfei Li
2019-09-09 17:07 ` [PATCH v2 2/4] mm, slab: Remove unused kmalloc_size() Pengfei Li
2019-09-09 17:07 ` [PATCH v2 3/4] mm, slab_common: Make 'type' is enum kmalloc_cache_type Pengfei Li
2019-09-09 20:00 ` Roman Gushchin
2019-09-10 0:59 ` Pengfei Li [this message]
2019-09-09 17:07 ` [PATCH v2 4/4] mm, slab_common: Make initializing KMALLOC_DMA start from 1 Pengfei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD7_sbHgfNB-rYQ=uOGL14Pmf8VgChbnwh804r8LT_o73iH4Hg@mail.gmail.com' \
--to=lpf.vector@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).