From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACDD5C433E0 for ; Thu, 21 May 2020 22:10:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 697B5207D3 for ; Thu, 21 May 2020 22:10:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rvtv2nZM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 697B5207D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0074D8000A; Thu, 21 May 2020 18:10:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF99D80007; Thu, 21 May 2020 18:10:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E36028000A; Thu, 21 May 2020 18:10:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id CF52880007 for ; Thu, 21 May 2020 18:10:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9C6B88248047 for ; Thu, 21 May 2020 22:10:54 +0000 (UTC) X-FDA: 76842122028.07.month22_7e7539ef110e X-HE-Tag: month22_7e7539ef110e X-Filterd-Recvd-Size: 3716 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 May 2020 22:10:54 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id i14so8861328qka.10 for ; Thu, 21 May 2020 15:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=isMsZ2pUMyCVKxa9Y2mlyk5l3TCYNg/xt93/ki7P2xM=; b=rvtv2nZMjsCYj/CeRcxqSRzJYCvoWBWeEm/72+lnNyxa+Vdy9NkfFeD8cpeGY76yDk wfvMzNxbucIn7Hs+oWyf05qo9fHMcUsteanx5aU0XArHtMRRXJLuU721EUNgAES4ID8L 4BK22OGZzPIFuxQJNAXNMRKzin+VQSx6P4f7rTt5QxVcnbVdnbKLOB4xWP/9BUtlDCzG wxQKxlWDremxmA6nHO7Dnyr4bSR0bzQXoj8MWM7oqmmacFdDmArrPOzkdO2ojiT2NeXZ 3rF1QgvrXugmu2458C0loC8GmxZvMhABO4SKgIQSvB76sfSoth+Bvjqp6Btx4FaWlhSq MSyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=isMsZ2pUMyCVKxa9Y2mlyk5l3TCYNg/xt93/ki7P2xM=; b=Bjo8rxjiIUGJzxDEeoBc5yyFlVoOCILsfm3vynRcabVFWM7vfBzpAod+8xrJkasAFJ SFfCwzzghhsQ7vf2yunkbDbU19euLcgFDorrHo2jj2JDfgwLKPlWpVLWKsZCR/8xceHs 9/cHSe4J+vPf0M20aCyd23sEveYzN3ja1NPOvJSSmLgP7ZKkKfIMuTvIVoh55WUqyR6g mujd1QIyFV9HDU8iFUqcONNIHFBghUgwmUxC5eY8duNtMEcw0e70fR3v450KqiARkn2L FF90ADBzW3V1OS/34D1GFWQRT3NFoq8eRdm9mZfgepaCpaBYlgtM36j+lV4RdOWOtEMj vuNg== X-Gm-Message-State: AOAM531fI4zqDskKLUSGZw7gPUMWTHi1SVJ+uYaLWgQmOBhS7NLbs8vo 0cWdjfQ+2+w5NgVwBqwTLZQluoew7uvjZEq8IB8= X-Google-Smtp-Source: ABdhPJyXmTlK01x/mLueG4iMCV7LUGdCvFmE02/3ZxSTylcerxvuwFpzisGXHtk+V9iTqf6OpLYFCd1cU/qrM9V446Y= X-Received: by 2002:ae9:e713:: with SMTP id m19mr12160235qka.39.1590099053692; Thu, 21 May 2020 15:10:53 -0700 (PDT) MIME-Version: 1.0 References: <20200521152301.2587579-1-hch@lst.de> <20200521152301.2587579-14-hch@lst.de> In-Reply-To: <20200521152301.2587579-14-hch@lst.de> From: Andrii Nakryiko Date: Thu, 21 May 2020 15:10:42 -0700 Message-ID: Subject: Re: [PATCH 13/23] bpf: rework the compat kernel probe handling To: Christoph Hellwig Cc: x86@kernel.org, Alexei Starovoitov , Daniel Borkmann , Masami Hiramatsu , Linus Torvalds , Andrew Morton , linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, Networking , bpf , linux-mm@kvack.org, open list Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 21, 2020 at 8:26 AM Christoph Hellwig wrote: > > Instead of using the dangerous probe_kernel_read and strncpy_from_unsafe > helpers, rework the compat probes to check if an address is a kernel or > userspace one, and then use the low-level kernel or user probe helper > shared by the proper kernel and user probe helpers. This slightly > changes behavior as the compat probe on a user address doesn't check > the lockdown flags, just as the pure user probes do. > > Signed-off-by: Christoph Hellwig > --- Looks good, thanks. Acked-by: Andrii Nakryiko > kernel/trace/bpf_trace.c | 109 ++++++++++++++++++++++++--------------- > 1 file changed, 67 insertions(+), 42 deletions(-) > [...]