From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 590A8C433E0 for ; Thu, 21 May 2020 22:10:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 02021206F6 for ; Thu, 21 May 2020 22:10:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J8AydxJv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02021206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9CA2780008; Thu, 21 May 2020 18:10:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97AE580007; Thu, 21 May 2020 18:10:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8901C80008; Thu, 21 May 2020 18:10:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 7453E80007 for ; Thu, 21 May 2020 18:10:45 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 405C75836 for ; Thu, 21 May 2020 22:10:45 +0000 (UTC) X-FDA: 76842121650.13.prose12_68a86b8f792e X-HE-Tag: prose12_68a86b8f792e X-Filterd-Recvd-Size: 3404 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 May 2020 22:10:44 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id i5so8836296qkl.12 for ; Thu, 21 May 2020 15:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fm4JD807X5RrjTwsFUI7w3BEzpMypViAerLd/aB5r74=; b=J8AydxJvTfOLj4SnXaGjYeBAkg2KcbONigWAqFhy28XWe0yoJSm2mqXTvJxPUdz4vn 8csb1VJ846w+CN438dl2Kd9l3C73W6h4oKEYXoALOVTin7KbZ/YDlKFLF0AAA4nbJqFp LB1X3Hn5mhIhPavMozO/KMXf6gthpTGbRdfqH9PzmVymTuezcrONofpWVb61Js8EVDpD 4pbUlvLX2ye6Sf9Rnhp+0IxPOYwwYikWR57bi9J2cXHzgLs31qHiq+XRCvC7s0Ay6mem 07lgQH3Sz3f5gduyy8vQZYJru94h9wd40ax2jSnBP3+ZJ7hlV7fwe7o5DnnsyqeeIJkb nEMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fm4JD807X5RrjTwsFUI7w3BEzpMypViAerLd/aB5r74=; b=rU3DO4UcXV0WQbj+h2tLq0nSACtJwNG1T8EiRfGRFK0+5Pc+3aEbrEuXcCruufskty ks/DaZFHrzORu1DPtvPr9jKzj13taWxWct9BPsmnTaqtNOy3GgfitkFOq5v0hQXaKLpq 9jdqG6gP6yOlnBYaEOD61LDejnYb/vCe3LwS8zSIzc3lISzSxnjMBS4lTBijHSNvJ04z rTu+fVYxihFPs4rK+ct5CY77WXw9zdtTu5zz3uONQywi5rv439Ls/ov0mpmrYWjq5Ly3 z9ZsJQpGGywBjygA4vquyvZ9drsERSjW36aCCAoYTGPWT00zYtMQmhH74RO3z3Zdl/p8 bySA== X-Gm-Message-State: AOAM530tyFfj3fg1lZwuzgalri/pxQX4daXCjeCfRWyzqGW37waHpocL WuDsVD3OONtHS14a2l04+F8nvjjsniM1OQRTONo= X-Google-Smtp-Source: ABdhPJxJhqPjBqLqBOYnkHGHiDuGjV6UrwgRBFuNPFyvTMaKJ10aWTqgfPPDhtmPKaNroLARywp1EK7gtepHBmRPz9I= X-Received: by 2002:a05:620a:14a1:: with SMTP id x1mr11755356qkj.92.1590099044250; Thu, 21 May 2020 15:10:44 -0700 (PDT) MIME-Version: 1.0 References: <20200521152301.2587579-1-hch@lst.de> <20200521152301.2587579-12-hch@lst.de> In-Reply-To: <20200521152301.2587579-12-hch@lst.de> From: Andrii Nakryiko Date: Thu, 21 May 2020 15:10:33 -0700 Message-ID: Subject: Re: [PATCH 11/23] bpf: factor out a bpf_trace_copy_string helper To: Christoph Hellwig Cc: x86@kernel.org, Alexei Starovoitov , Daniel Borkmann , Masami Hiramatsu , Linus Torvalds , Andrew Morton , linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, Networking , bpf , linux-mm@kvack.org, open list Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 21, 2020 at 8:25 AM Christoph Hellwig wrote: > > Split out a helper to do the fault free access to the string pointer > to get it out of a crazy indentation level. > > Signed-off-by: Christoph Hellwig > --- LGTM. Acked-by: Andrii Nakryiko > kernel/trace/bpf_trace.c | 42 +++++++++++++++++++++++----------------- > 1 file changed, 24 insertions(+), 18 deletions(-) > [...]