Re: [PATCH v2] mm: Change return type to vm_fault_t

From: Souptick Joarder <jrdr.linux@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.com>, Hugh Dickins <hughd@google.com>,
	Dan Williams <dan.j.williams@intel.com>,
	David Rientjes <rientjes@google.com>,
	mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Linux-MM <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: Change return type to vm_fault_t
Date: Fri, 11 May 2018 23:56:48 +0530	[thread overview]
Message-ID: <CAFqt6zbZw74s=Kqh=UgtZti_jJJ8UcCXVqBgXyG3vruRbqg9Yw@mail.gmail.com> (raw)
In-Reply-To: <20180511181546.GA25613@bombadil.infradead.org>

On Fri, May 11, 2018 at 11:45 PM, Matthew Wilcox <willy@infradead.org> wrote:
> On Fri, May 11, 2018 at 11:36:39PM +0530, Souptick Joarder wrote:
>>  mm/hugetlb.c | 2 +-
>>  mm/mmap.c    | 4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> Don't we also need to convert include/linux/mm_types.h:
>
> @@ -621,7 +621,7 @@ struct vm_special_mapping {
>          * If non-NULL, then this is called to resolve page faults
>          * on the special mapping.  If used, .pages is not checked.
>          */
> -       int (*fault)(const struct vm_special_mapping *sm,
> +       vm_fault_t (*fault)(const struct vm_special_mapping *sm,
>                      struct vm_area_struct *vma,
>                      struct vm_fault *vmf);
>
> or are you leaving that for a later patch?

Ahh, I didn't realise. No I think, we can add it as part of this
patch. Will send v3.