From: Alexander Potapenko <glider@google.com>
To: glider@google.com, andy@kernel.org, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
elver@google.com, dvyukov@google.com,
kasan-dev@googlegroups.com, ndesaulniers@google.com,
nathan@kernel.org, keescook@chromium.org
Subject: Re: [PATCH v2] string: use __builtin_memcpy() in strlcpy/strlcat
Date: Tue, 30 May 2023 10:40:26 +0200 [thread overview]
Message-ID: <CAG_fn=U67cq4502h2G8kms8r6e=13tn8Ta+QWhA8N6cK-PFyaA@mail.gmail.com> (raw)
In-Reply-To: <20230530083911.1104336-1-glider@google.com>
On Tue, May 30, 2023 at 10:39 AM Alexander Potapenko <glider@google.com> wrote:
>
> lib/string.c is built with -ffreestanding, which prevents the compiler
> from replacing certain functions with calls to their library versions.
>
> On the other hand, this also prevents Clang and GCC from instrumenting
> calls to memcpy() when building with KASAN, KCSAN or KMSAN:
> - KASAN normally replaces memcpy() with __asan_memcpy() with the
> additional cc-param,asan-kernel-mem-intrinsic-prefix=1;
> - KCSAN and KMSAN replace memcpy() with __tsan_memcpy() and
> __msan_memcpy() by default.
>
> To let the tools catch memory accesses from strlcpy/strlcat, replace
> the calls to memcpy() with __builtin_memcpy(), which KASAN, KCSAN and
> KMSAN are able to replace even in -ffreestanding mode.
>
> This preserves the behavior in normal builds (__builtin_memcpy() ends up
> being replaced with memcpy()), and does not introduce new instrumentation
> in unwanted places, as strlcpy/strlcat are already instrumented.
>
> Suggested-by: Marco Elver <elver@google.com>
> Signed-off-by: Alexander Potapenko <glider@google.com>
> Link: https://lore.kernel.org/all/20230224085942.1791837-1-elver@google.com/
Sorry, missed a "Reviewed-by: Marco Elver <elver@google.com>" from the
previous thread:
https://lore.kernel.org/lkml/CAG_fn=UzQ-jnQrxzvLE6EV37zSVCOGPmsVTxyfp1wXzBir4vAg@mail.gmail.com/T/
> Acked-by: Kees Cook <keescook@chromium.org>
next prev parent reply other threads:[~2023-05-30 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 8:39 [PATCH v2] string: use __builtin_memcpy() in strlcpy/strlcat Alexander Potapenko
2023-05-30 8:40 ` Alexander Potapenko [this message]
2023-05-30 23:10 ` Kees Cook
2023-05-31 7:57 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=U67cq4502h2G8kms8r6e=13tn8Ta+QWhA8N6cK-PFyaA@mail.gmail.com' \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).