From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 238B4C388F9 for ; Wed, 11 Nov 2020 13:25:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A923206CA for ; Wed, 11 Nov 2020 13:25:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="W2VqwyDs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A923206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C9F396B0068; Wed, 11 Nov 2020 08:25:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C2A066B006C; Wed, 11 Nov 2020 08:25:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B17EC6B006E; Wed, 11 Nov 2020 08:25:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 790E76B0068 for ; Wed, 11 Nov 2020 08:25:16 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1B256181AEF00 for ; Wed, 11 Nov 2020 13:25:16 +0000 (UTC) X-FDA: 77472208632.05.grass06_2f14262272fe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id F11A91801D3E8 for ; Wed, 11 Nov 2020 13:25:15 +0000 (UTC) X-HE-Tag: grass06_2f14262272fe X-Filterd-Recvd-Size: 7624 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 13:25:15 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id p12so1211275qtp.7 for ; Wed, 11 Nov 2020 05:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lxMzMj/D4VM40jBrYMiztVpoEGAQUw5RwBN1Z96sbhM=; b=W2VqwyDslVmOcQeQWaDTcCrfP6LVQRfhinZFA/R9I36CXRJM8ng79ded5njEpNajDg oMSWsbk2jAFI0UErp9871SonwHoCGDF+iXTfroiZ3G4OZ73/0VN2ljiQAGlOg4U0IhmH 5ml4pwZMsu+lSJvzExtLweP9pysH4HiRRAAj5MisCDNA9e8ggSeN04sVnBiOl2PU+OLh QfqEodaTeEXIzkFqsc9n1wqbG3NWGRnhL+DzKgcgWeOp+GiEe3OLqK4q3NGxFXoybktD rXYepg+8m/I7hgMlJyYhD9LlX6VyVki3rOvCG0dc5TAWkvAwX1++kHCe4u1MC9OzBgZN uXLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lxMzMj/D4VM40jBrYMiztVpoEGAQUw5RwBN1Z96sbhM=; b=fq8H2dx7ja6De3qQsorukQh97r/ecfAhW24Z5TWGfO+G8ZAPsUibVxXtH8AU4zxLkD K5lWH4XwwNy/J2vGY3GrqjInSO6cGnJgl/7hW9mat4iCEYk5mtGBqi5RximeiRmDON0b iIUBKhZXx1Coj4fu6Nu1Lzi+4en6K2sNSoJ96ZXLnT3pkw4p5CL/x/a1j0C2HWOw6cVx E/txSUeu91qqwFJQkX2+C2jgU2yi62waTbnt8MKP0vNunz53sVdGIgGoWJ2xZcAXkPtf 9y/Jf3kuoEAHmaYcd2o46QybhPmJxx81ulQq4/gB6DcZ+ITbqcMeGbY/dqqUfJzSRmpo yGwQ== X-Gm-Message-State: AOAM530dxP9Hc/Bq2QVxQ6oIPMurQ82KuAd4TCzHVi7ZpgWpqsjCuETT yFzvA34zrgqsHci6P71ySAmhT7cNxA6PG91RqqKyrQ== X-Google-Smtp-Source: ABdhPJzZP8LufNZKkqyfvQftEsoHgigk7e7Ui/hYJEjxWJoUQLIPPesZuqSnRUCafXIq6dogg7NdlHgqwZ4WmjnR8HM= X-Received: by 2002:ac8:454d:: with SMTP id z13mr20929301qtn.175.1605101114470; Wed, 11 Nov 2020 05:25:14 -0800 (PST) MIME-Version: 1.0 References: <81fbf12c3455448b2bb4162dd9888d405ee0c00a.1605046192.git.andreyknvl@google.com> In-Reply-To: <81fbf12c3455448b2bb4162dd9888d405ee0c00a.1605046192.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 11 Nov 2020 14:25:03 +0100 Message-ID: Subject: Re: [PATCH v9 05/44] kasan: shadow declarations only for software modes To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov w= rote: > > This is a preparatory commit for the upcoming addition of a new hardware > tag-based (MTE-based) KASAN mode. > > Group shadow-related KASAN function declarations and only define them > for the two existing software modes. > > No functional changes for software modes. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > Reviewed-by: Marco Elver Reviewed-by: Alexander Potapenko > --- > Change-Id: I864be75a88b91b443c55e9c2042865e15703e164 > --- > include/linux/kasan.h | 47 ++++++++++++++++++++++++++++--------------- > 1 file changed, 31 insertions(+), 16 deletions(-) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 59538e795df4..26f2ab92e7ca 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -11,7 +11,6 @@ struct task_struct; > > #ifdef CONFIG_KASAN > > -#include > #include > > /* kasan_data struct is used in KUnit tests for KASAN expected failures = */ > @@ -20,6 +19,20 @@ struct kunit_kasan_expectation { > bool report_found; > }; > > +#endif > + > +#if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS) > + > +#include > + > +/* Software KASAN implementations use shadow memory. */ > + > +#ifdef CONFIG_KASAN_SW_TAGS > +#define KASAN_SHADOW_INIT 0xFF > +#else > +#define KASAN_SHADOW_INIT 0 > +#endif > + > extern unsigned char kasan_early_shadow_page[PAGE_SIZE]; > extern pte_t kasan_early_shadow_pte[PTRS_PER_PTE]; > extern pmd_t kasan_early_shadow_pmd[PTRS_PER_PMD]; > @@ -35,6 +48,23 @@ static inline void *kasan_mem_to_shadow(const void *ad= dr) > + KASAN_SHADOW_OFFSET; > } > > +int kasan_add_zero_shadow(void *start, unsigned long size); > +void kasan_remove_zero_shadow(void *start, unsigned long size); > + > +#else /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > + > +static inline int kasan_add_zero_shadow(void *start, unsigned long size) > +{ > + return 0; > +} > +static inline void kasan_remove_zero_shadow(void *start, > + unsigned long size) > +{} > + > +#endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > + > +#ifdef CONFIG_KASAN > + > /* Enable reporting bugs after kasan_disable_current() */ > extern void kasan_enable_current(void); > > @@ -75,9 +105,6 @@ struct kasan_cache { > int free_meta_offset; > }; > > -int kasan_add_zero_shadow(void *start, unsigned long size); > -void kasan_remove_zero_shadow(void *start, unsigned long size); > - > size_t __ksize(const void *); > static inline void kasan_unpoison_slab(const void *ptr) > { > @@ -143,14 +170,6 @@ static inline bool kasan_slab_free(struct kmem_cache= *s, void *object, > return false; > } > > -static inline int kasan_add_zero_shadow(void *start, unsigned long size) > -{ > - return 0; > -} > -static inline void kasan_remove_zero_shadow(void *start, > - unsigned long size) > -{} > - > static inline void kasan_unpoison_slab(const void *ptr) { } > static inline size_t kasan_metadata_size(struct kmem_cache *cache) { ret= urn 0; } > > @@ -158,8 +177,6 @@ static inline size_t kasan_metadata_size(struct kmem_= cache *cache) { return 0; } > > #ifdef CONFIG_KASAN_GENERIC > > -#define KASAN_SHADOW_INIT 0 > - > void kasan_cache_shrink(struct kmem_cache *cache); > void kasan_cache_shutdown(struct kmem_cache *cache); > void kasan_record_aux_stack(void *ptr); > @@ -174,8 +191,6 @@ static inline void kasan_record_aux_stack(void *ptr) = {} > > #ifdef CONFIG_KASAN_SW_TAGS > > -#define KASAN_SHADOW_INIT 0xFF > - > void kasan_init_tags(void); > > void *kasan_reset_tag(const void *addr); > -- > 2.29.2.222.g5d2a92d10f8-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg