From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F04C55ABD for ; Wed, 11 Nov 2020 16:19:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C8E7820791 for ; Wed, 11 Nov 2020 16:19:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EDK8+6vZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8E7820791 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 13FEF6B005D; Wed, 11 Nov 2020 11:19:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EFB06B0071; Wed, 11 Nov 2020 11:19:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F20976B0073; Wed, 11 Nov 2020 11:19:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id C194B6B005D for ; Wed, 11 Nov 2020 11:19:43 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 57C96362B for ; Wed, 11 Nov 2020 16:19:43 +0000 (UTC) X-FDA: 77472648246.29.match02_3503442272ff Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 2D411180868E8 for ; Wed, 11 Nov 2020 16:19:43 +0000 (UTC) X-HE-Tag: match02_3503442272ff X-Filterd-Recvd-Size: 4520 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 16:19:41 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id q5so2132740qkc.12 for ; Wed, 11 Nov 2020 08:19:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NdgljsAg/2kl6g/hQQs/nkDVrJD6gaQwZKzBgT4Tycw=; b=EDK8+6vZvqG4lgainA6noaRoMS9BYL+HJyKxtdibIsYOyZM4+qBxmZYkjgcHILiuDB r40ch7x5Hjr5lgJR2vl9f1hOU89IOY66J65dPWlRrlzn7cZt76xAhN/UEf5UsU5g9UHg M4S10l5GvCixHcZky2v9mm9O8up6atKysDwV79yZFLogABjYKXRT1+qE9FaSUL6s57Vq fWyEZ9MTjhv0SIq5Uz0tw5H8w5A5HR8r6cTl9av+YTUeZySii+2RtklJpxppjIb+SZ8C MKXiYkK8qN8K6nRNYiktCQ9p7zMAnXWsfWiDJY2NSp+gKMG6kfpSe5blI4Xca2i+JCR0 TfbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NdgljsAg/2kl6g/hQQs/nkDVrJD6gaQwZKzBgT4Tycw=; b=Z0WMo7258t7TrbZM6foUdvdD8P60m6DA6IG3I5LvxuQZ4BDnE1JPLHyLCS+eaKR+nL 8ysirKl7aBlTCGJTKhsJbPdQux2IVC5keKnfcEt+62XvdKWxxU06FpMmoCtLx1/ZXfm7 kKrWqkeICAlKuZd25H2qbpQt+UXa5dkrp3MXG+H7HfUlfLI6XWwzNRIUx8YW0qorr1LO mBSTefOmTZwnZEnzgmXKjzhZio1S0aT9xUmDGP0OfM+YJRrCU8XdlughtXstPEF/CCSp tgd+c7UU0QZ4LMgU+5LPm+pcV4zS7e6iZm0La8HY8jmuIFHulAez6rCvQsskrF7IZnVM XEAg== X-Gm-Message-State: AOAM533lTHfgZTOxewjn1/F5HfcLWUhLhKgtwqEE3/xEx4KTnvACGGME +on57aEhGa5q3bweyEdXj3MVxGhWQTxbuKF6TFT2CQ== X-Google-Smtp-Source: ABdhPJwEWFsczvA9eGNn3bEDLsp5Wc6vUSPX+LtgEiTHwNZx9oxkijXqdSW/eG5CPEGhKgzP1CrHtnGP6gHxFCccMO4= X-Received: by 2002:a37:4552:: with SMTP id s79mr19714490qka.6.1605111580407; Wed, 11 Nov 2020 08:19:40 -0800 (PST) MIME-Version: 1.0 References: <560e04850b62da4fd69caa92b4ce3bebf275ea59.1605046192.git.andreyknvl@google.com> In-Reply-To: From: Alexander Potapenko Date: Wed, 11 Nov 2020 17:19:28 +0100 Message-ID: Subject: Re: [PATCH v9 23/44] kasan: separate metadata_fetch_row for each mode To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 11, 2020 at 4:22 PM Alexander Potapenko wrote: > > On Tue, Nov 10, 2020 at 11:12 PM Andrey Konovalov wrote: > > > > This is a preparatory commit for the upcoming addition of a new hardware > > tag-based (MTE-based) KASAN mode. > > > > Rework print_memory_metadata() to make it agnostic with regard to the > > way metadata is stored. Allow providing a separate metadata_fetch_row() > > implementation for each KASAN mode. Hardware tag-based KASAN will provide > > its own implementation that doesn't use shadow memory. > > > > No functional changes for software modes. > > > > Signed-off-by: Andrey Konovalov > > Signed-off-by: Vincenzo Frascino > > Reviewed-by: Marco Elver Reviewed-by: Alexander Potapenko > > +void metadata_fetch_row(char *buffer, void *row) > > +{ > > + memcpy(buffer, kasan_mem_to_shadow(row), META_BYTES_PER_ROW); > > I think it is important to use __memcpy() instead of memcpy() in KASAN > runtime to avoid calling instrumented code. Please disregard this. Turns out we define memcpy to __memcpy for non-instrumented files.