From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E1EC432C3 for ; Tue, 3 Dec 2019 14:09:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38CC4206EC for ; Tue, 3 Dec 2019 14:09:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FeuAJoMc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38CC4206EC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BB33C6B0552; Tue, 3 Dec 2019 09:09:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B3D026B0553; Tue, 3 Dec 2019 09:09:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A043D6B0554; Tue, 3 Dec 2019 09:09:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 86E086B0552 for ; Tue, 3 Dec 2019 09:09:41 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 46A16180ACEFB for ; Tue, 3 Dec 2019 14:09:41 +0000 (UTC) X-FDA: 76224013362.29.BED1772 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id B96E9180445F1 for ; Tue, 3 Dec 2019 14:07:18 +0000 (UTC) X-HE-Tag: tiger24_57f3b3ea6803 X-Filterd-Recvd-Size: 6712 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Dec 2019 14:07:17 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id g206so3091351wme.1 for ; Tue, 03 Dec 2019 06:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fGnbNs1F5W8bSWBJ5Igyt/SH/YuNAG8weIknhsBpThc=; b=FeuAJoMc2aEUU9eFoX0BxiibFGbjwzAJSHBfy4TJkf+shYhQAFIS/zi3THJ9cika2n xdPJWmpsOY6PFeSDo85VX/zcB781X48mEvcb4xyjV/9SZ1T8K1kmHxfn6A4YnjWgdi0G Z3Y3RNV1vitzt0V/Y6SGkAr/EpGB5tFzwYY4u3+xZ/B+NcELmLz1+Hvuz7uZq+6MCFRy icfv4S3uvf74A+rLv7MbqDz2/6HvLhew/m2jocRZjexdqE2qSIYNh2EsZecq6z9Fj5c1 UvLprKfaS3Z9ePV0ecYq69UPGcOnSANBtMK+uB+n9F4pG+iriOKAtZVOfMElnGCxWk3K m2mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fGnbNs1F5W8bSWBJ5Igyt/SH/YuNAG8weIknhsBpThc=; b=pncamNgpS5R64CvPaxIJe2y1FBLGmMb0gg39c532LV6frsp7sLUpBp0Gn6rPK1NFdx RB/ClX5Jcv/wWjYb4aRpwM8NExBfA22BeZgIR+uRjRw3ZeVzMsTEZ9/L3eMtVo3anQbJ vvjKH37gjaWc5szIgUatabNhJOGVgUVDUwRGGdxHX/j4rGx/zV8uC7z0wrIwGYrD5UqV BJR088U30/1h9jKm+lF9VTlyVUbKU2LGevVKT6Rm/x5HwrPTTjCmDAf3PkF80wjzSnTA EuOOucobma+1S3Td7tpL4I3frwW2eXa/yD8gV/XqrM9NhxGVuwnlpSTF/Nh16PyQgsll gDWw== X-Gm-Message-State: APjAAAW6ikh1UfIAImaV5+XUsA5ZK560et2mVg3OixdKsmLI9rnlv1Og BIVIbVTQB01XDcelctgcAVyi1y19wXQpgGTt1kvzvg== X-Google-Smtp-Source: APXvYqwbe7rJeXggQiY77kNDu11GzgJoyV1LSlnUzsY1Nh8k+NI3TXOc4f+b5vZiZMH/51ckanjkDEJPcwfLs9hmnI8= X-Received: by 2002:a1c:a98e:: with SMTP id s136mr33983037wme.140.1575382036063; Tue, 03 Dec 2019 06:07:16 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-33-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Tue, 3 Dec 2019 15:07:04 +0100 Message-ID: Subject: Re: [PATCH RFC v3 32/36] kmsan: add iomap support To: Marco Elver Cc: Christoph Hellwig , "Darrick J. Wong" , Vegard Nossum , Dmitry Vyukov , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 3, 2019 at 1:51 PM Marco Elver wrote: > > On Fri, 22 Nov 2019 at 12:28, wrote: > > > > Functions from lib/iomap.c interact with hardware, so KMSAN must ensure > > that: > > - every read function returns an initialized value > > - every write function checks values before sending them to hardware. > > > > Signed-off-by: Alexander Potapenko > > Cc: Christoph Hellwig > > Cc: Darrick J. Wong > > Cc: Vegard Nossum > > Cc: Dmitry Vyukov > > Cc: linux-mm@kvack.org > > --- > > > > Change-Id: Iacd96265e56398d8c111637ddad3cad727e48c8d > > --- > > lib/iomap.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/lib/iomap.c b/lib/iomap.c > > index e909ab71e995..3ef20b8138e2 100644 > > --- a/lib/iomap.c > > +++ b/lib/iomap.c > > @@ -6,6 +6,7 @@ > [...] > > void iowrite8_rep(void __iomem *addr, const void *src, unsigned long c= ount) > > { > > + /* Make sure uninitialized memory isn't copied to devices. */ > > + kmsan_check_memory(src, count); > > IO_COND(addr, outsb(port, src, count), mmio_outsb(addr, src, co= unt)); > > } > > void iowrite16_rep(void __iomem *addr, const void *src, unsigned long = count) > > { > > + /* Make sure uninitialized memory isn't copied to devices. */ > > + kmsan_check_memory(src, count); > > Should this be 'count * 2' ? Good catch, thanks! Will fix in v4. > > > IO_COND(addr, outsw(port, src, count), mmio_outsw(addr, src, co= unt)); > > } > > void iowrite32_rep(void __iomem *addr, const void *src, unsigned long = count) > > { > > + /* Make sure uninitialized memory isn't copied to devices. */ > > + kmsan_check_memory(src, count); > > Should this be 'count * 4' ? Ditto > Thanks, > -- Marco --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg