From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D68C43603 for ; Mon, 16 Dec 2019 11:35:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 34D9B206D3 for ; Mon, 16 Dec 2019 11:35:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bVLNQ0di" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34D9B206D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 847608E0006; Mon, 16 Dec 2019 06:35:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F82B8E0003; Mon, 16 Dec 2019 06:35:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70D328E0006; Mon, 16 Dec 2019 06:35:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 5AF778E0003 for ; Mon, 16 Dec 2019 06:35:17 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id F2EE245B3 for ; Mon, 16 Dec 2019 11:35:16 +0000 (UTC) X-FDA: 76270798674.16.silk05_10f02f83e230f X-HE-Tag: silk05_10f02f83e230f X-Filterd-Recvd-Size: 5957 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Dec 2019 11:35:16 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id z3so6828733wru.3 for ; Mon, 16 Dec 2019 03:35:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XIkXUh3jV+8ZYPSYrz01NxqA4ksdP5UHuD0doGmR3KU=; b=bVLNQ0di5O17N1P+yj4IowHk2DUY5mHtVCIbVBKeuRl5cchOyqIDfXTgH9xl4Uxlz5 CDtzrrula541Fu7IwAviki6mc5YzLVZ5mG9onQpVoZWlSKbB8j84mApO3kKYQipiQVFi d8hZRMlUfknzp7RVA+xgQkPIASoJi10WzX6nh0WYCCrDij6HgYK0wQdpIDSxGqC7tV8v Y58Syc8PtZnJ5B2fYsO7QpNWVOAqN5wC8taF43rGRcHIi252so4zJT/atMy/VgUcYwge KCOwIHdQUF2tECR6VDqu71bTh4WG+1DqSnWf7sCPkcOc7zbQqXuY8vd/07NeuyDoe+E0 ADWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XIkXUh3jV+8ZYPSYrz01NxqA4ksdP5UHuD0doGmR3KU=; b=sTgAMNDZD51G1KCXfGps6/JfV9qpGjlUC657axllxZbCuOvO+y/WP57uKPjhso1jxb R2/V/lrhsOJ/kzw63DugNu7onu/c19fR35GXTU9S9BQKLLjAqursd+7i2L1gOZzzHcb+ vOiRqJJuMwE8Y8TGUn9W1Awr0pNOMerdgZqu5sv6uCaaeggEp7TlN51h0IaU4F7oxoNH e8lbOknx+0GOaCthS/SSJERIMUj8V2vVTrCvO8K3u1o6ET7hpWN5fRc7/Pv8EjA672q7 x8jCdMOPJT7etbmt+ZCK7pApHaDVjQW7K17hJKfv1JyVSGbI7miYJXd1NzEKDJiq9I1M a2Og== X-Gm-Message-State: APjAAAV8FUKjQNrXSFV0O2ckmB7KTC3hz2rfIAmMCIIh/XH0y6XLZNFB pispCiE4nqEI6S8gMCQWRZq79a6ODbuNGsrVf6aQXg== X-Google-Smtp-Source: APXvYqy1vsJLkJ4gzNHId9blH7aY5pept9J6jKvN1Jl6JLPAwev7YVz1Oaquq2V5YPlozEuswRA/P5VZSYi0zR3rMPI= X-Received: by 2002:adf:9104:: with SMTP id j4mr29913321wrj.221.1576496114967; Mon, 16 Dec 2019 03:35:14 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-8-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Mon, 16 Dec 2019 12:35:03 +0100 Message-ID: Subject: Re: [PATCH RFC v3 07/36] kmsan: introduce __no_sanitize_memory and __SANITIZE_MEMORY__ To: Andrey Konovalov Cc: Vegard Nossum , Dmitry Vyukov , Linux Memory Management List , Alexander Viro , Andreas Dilger , Andrew Morton , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Marco Elver , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S . Tsirkin" , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 29, 2019 at 5:09 PM Andrey Konovalov wrote: > > On Fri, Nov 22, 2019 at 12:26 PM wrote: > > > > __no_sanitize_memory is a function attribute that makes KMSAN > > ignore the uninitialized values coming from the function's > > inputs, and initialize the function's outputs. > > > > Functions marked with this attribute can't be inlined into functions > > not marked with it, and vice versa. > > > > __SANITIZE_MEMORY__ is a macro that's defined iff the file is > > instrumented with KMSAN. This is not the same as CONFIG_KMSAN, which is > > defined for every file. > > > > Signed-off-by: Alexander Potapenko > > To: Alexander Potapenko > > Cc: Vegard Nossum > > Cc: Dmitry Vyukov > > Cc: linux-mm@kvack.org > > > > --- > > > > Change-Id: I1f1672652c8392f15f7ca8ac26cd4e71f9cc1e4b > > --- > > include/linux/compiler-clang.h | 8 ++++++++ > > include/linux/compiler-gcc.h | 5 +++++ > > 2 files changed, 13 insertions(+) > > > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > > index 333a6695a918..edba13a069a6 100644 > > --- a/include/linux/compiler-clang.h > > +++ b/include/linux/compiler-clang.h > > @@ -24,6 +24,14 @@ > > #define __no_sanitize_address > > #endif > > > > +/* KMSAN is a Clang-only tool, thus putting the defines here */ > > I'm not sure if this comment is useful here. Dropped the comment in v4.