From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E0DC432C0 for ; Tue, 3 Dec 2019 14:35:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BD61820659 for ; Tue, 3 Dec 2019 14:35:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="MNBFGxOt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD61820659 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6E5396B056C; Tue, 3 Dec 2019 09:35:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66DDE6B056D; Tue, 3 Dec 2019 09:35:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55DE06B056E; Tue, 3 Dec 2019 09:35:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 390326B056C for ; Tue, 3 Dec 2019 09:35:12 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id D3D5682B750E for ; Tue, 3 Dec 2019 14:35:11 +0000 (UTC) X-FDA: 76224077622.15.beam12_677b5aa6afa19 X-HE-Tag: beam12_677b5aa6afa19 X-Filterd-Recvd-Size: 7346 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Dec 2019 14:35:11 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id z3so3976038wru.3 for ; Tue, 03 Dec 2019 06:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=eSe/VBsaIwQyUQOoz0NRjtEmXzq8rA/sj1iRIcBnYm0=; b=MNBFGxOtPHXjIt84W9A0mSzYR2kyREgM5CVocPkPYRwgt1MtE/q98oaAvcCVZMM9MO 8OA49LuFf0jTqqpFibbPzvD2IDjUyat2O5CeYnn34jqqUB2HBNhtIdmpfrM7lI+zHk1+ umOVOY78NlXA3qRTMHhy/rQPQumoV2rE069dtS803hLsRV/jDVzjPh622d+0kI+5AU04 Kn4ws+hUoGc9kCHrNNVjdBdSUCZ6Z4kWvZd6NMYTpYOVlMBB6S+gcpy9FJ0R5UMxDJgq kTnCuiiCjRcStyQdRr+MVqZSKDCsDBOtWTDEawy+AYIwaVqFtHZQMXQUA0+G1tp3gFCO vQ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=eSe/VBsaIwQyUQOoz0NRjtEmXzq8rA/sj1iRIcBnYm0=; b=oPIWHSTGQtyUCOGgkWG7v8RSkjky6sPR4N04iyt3DNxEP8S731I8cYy6Ihc4fnoIvf Yziop3IdO0wxKbwNuoqGiMPxMcq6aZdEInDiGfamV8UQXPuvYIUDru052fgGwfBxYeRF /BaolM81T+Jd/JS1C4EqXf2olEdA3f3tSE0HMBh8gTsrxi/e6g5PBtkrQMWykOiQ3Anb l94j7iIfj6Vf9mODl3HlkGfH7rcW6OUZ7PKTjg558ul9ErLdIy4VIOQUEILUThZf9Pix WOvl28QKMONGxAOyEnKnWUVLl1b0hZYHjyVxESTzRj1jE3dZpY7/+uaF2gpJj2XLNiy3 CMyA== X-Gm-Message-State: APjAAAWNyjxm+awMoRXMpjgTxRs6i8N0Nwb52/xjz2QAOCxHWxgdUYpA 8Q9A8ehLkFI10rQzJiKaw4WA47Mo+2n16kDVs2X20w== X-Google-Smtp-Source: APXvYqzUBlkvQSGEwIva6M+q01iPD/HIBPAJ+U4tjYi9KxS/VUE9IBmrFok2sNOuQtJ9vutxu+5CGLc7cl1JCIEE37c= X-Received: by 2002:adf:e2cd:: with SMTP id d13mr5556434wrj.221.1575383709472; Tue, 03 Dec 2019 06:35:09 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-19-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Tue, 3 Dec 2019 15:34:58 +0100 Message-ID: Subject: Re: [PATCH RFC v3 18/36] kmsan: disable LOCK_DEBUGGING_SUPPORT To: Marco Elver Cc: Eric Biggers , Qian Cai , Christoph Hellwig , Herbert Xu , Harry Wentland , Vegard Nossum , Dmitry Vyukov , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 2, 2019 at 2:33 PM Marco Elver wrote: > > On Fri, 22 Nov 2019 at 12:27, wrote: > > > > KMSAN doesn't currently support lock debugging, causing the kernel to > > enter infinite recursion at boot time. > > See https://github.com/google/kmsan/issues/57. > > > > Signed-off-by: Alexander Potapenko > > Cc: Eric Biggers > > Cc: Qian Cai > > Cc: Christoph Hellwig > > Cc: Herbert Xu > > Cc: Harry Wentland > > Cc: Vegard Nossum > > Cc: Dmitry Vyukov > > Cc: linux-mm@kvack.org > > > > --- > > This patch is part of "kmsan: Kconfig changes to disable options > > incompatible with KMSAN", which was split into smaller pieces. > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 75c36318943d..a3f6f5d68593 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -1068,6 +1068,9 @@ menu "Lock Debugging (spinlocks, mutexes, etc...)= " > > config LOCK_DEBUGGING_SUPPORT > > bool > > depends on TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCK= DEP_SUPPORT > > + # KMSAN is incompatible with lockdep, > > + # see https://github.com/google/kmsan/issues/57. > > + depends on !KMSAN > > default y > > > > config PROVE_LOCKING > > > > Change-Id: I4f97edc8a02d8ca208fc914e55e8f0c23d74eac8 > > --- > > lib/Kconfig.debug | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 75c36318943d..a3f6f5d68593 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -1068,6 +1068,9 @@ menu "Lock Debugging (spinlocks, mutexes, etc...)= " > > config LOCK_DEBUGGING_SUPPORT > > bool > > depends on TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCK= DEP_SUPPORT > > + # KMSAN is incompatible with lockdep, > > + # see https://github.com/google/kmsan/issues/57. > > Does it make sense to get this working? Or rather, is it feasible to > get working? If not, I would just remove the reference to the Github > issue, and declare that KMSAN is incompatible with lockdep. Agreed. At this point I don't really know why KMSAN and lockdep don't play well together, but I'm not expecting anyone to use them together either. > > + depends on !KMSAN > > default y > > > > config PROVE_LOCKING > > -- > > 2.24.0.432.g9d3f5f5b63-goog > > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg