From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A49C5517A for ; Wed, 11 Nov 2020 16:11:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4F42D2074B for ; Wed, 11 Nov 2020 16:11:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EyFkI0AP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F42D2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B85646B007D; Wed, 11 Nov 2020 11:11:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0EE86B007E; Wed, 11 Nov 2020 11:11:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D6106B0080; Wed, 11 Nov 2020 11:11:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 6C8CE6B007D for ; Wed, 11 Nov 2020 11:11:03 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 174531EF2 for ; Wed, 11 Nov 2020 16:11:03 +0000 (UTC) X-FDA: 77472626406.04.cave87_1b0ea7f272ff Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id D8F99800340C for ; Wed, 11 Nov 2020 16:11:02 +0000 (UTC) X-HE-Tag: cave87_1b0ea7f272ff X-Filterd-Recvd-Size: 5007 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 16:11:02 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id h12so1620533qtc.9 for ; Wed, 11 Nov 2020 08:11:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=225dH83D48RrYMdcBweixtFsm7zoRRCV87kzdcWWgZw=; b=EyFkI0AP0amRkumU51nrztnLa9GiB9YufpOXcE1f4qID1vC9kgrza35k5Nho8yRDRL uqeaddWMgvidmrVAblzBJ0RmJICeeR6olwF5w3Hpqmj7sDSg/SKLg5PHkZaFMmkJmeHu lidCeiLmJL7g3mQ3/Gn0WghBqmSD75mcPEHSwwZCpSOF8o4MTIFMHxcLOLiJvAfVWSoP tY9POrER0u0kiEcuqFdKrQ185ZxS89sdeDVhr2xkQyze+chNRvW1zjNI2WXm63uv54ds uwANYaznp9hMHVSqITVlH57hwZw9P3LQT5kagm9ctNvzpSZ9ziQ1mLJ1H70UK48TtQJc uiyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=225dH83D48RrYMdcBweixtFsm7zoRRCV87kzdcWWgZw=; b=Tq+IwZxAZFpWvqIZvBhT4qZWAtfD5QMn2LDVfkmixthkD+4hIirhmKdT0m2knrpkVg /MqV5nQ8i4kj2KaRuUSeiMBjqsWMgNeqqEmRwoN4BqSPeMj1EL5qxf6auRtmB9zTLXeD KhiGqcj8FOGONFsyw16NqyKreUbs/RNJkj4ConEUj5uZf1tg+kWDUTUYl8v6bydIHg1B TbQI2BNpU3nE/rjxpGjMKiLgvMFkMfwebBjw139pt9HuUC+qixekHL4TS9TCKL0bjZkn wgxUWf48reL+pB7hEf0LWa4uTTr4MBI/10f9LbuHKdnlCpLfUYUhpPgMExyHrLj+oojy S9+Q== X-Gm-Message-State: AOAM531xVwzUCu9T17MJ2+lxtMLB+/UGHairvzIqSbfNnzcR9jR6KMvj Xt3NkW5iBh50YmqerhJsPCyh4NxWp01iXEyJQnK5Kw== X-Google-Smtp-Source: ABdhPJwTzo1m2Sr8laF/CiEBGPM3ZdbGWEO7fIU3/m6+DyFx6UPYO65RiP1CyS7CC7n3IMLpMXRZK7arGblHtec79fg= X-Received: by 2002:ac8:5c85:: with SMTP id r5mr19357172qta.8.1605111060119; Wed, 11 Nov 2020 08:11:00 -0800 (PST) MIME-Version: 1.0 References: <76b91f88120fc8c3e5923d6432a1d537ee584fc8.1605046192.git.andreyknvl@google.com> In-Reply-To: <76b91f88120fc8c3e5923d6432a1d537ee584fc8.1605046192.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 11 Nov 2020 17:10:48 +0100 Message-ID: Subject: Re: [PATCH v9 34/44] arm64: kasan: Align allocations for HW_TAGS To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:12 PM Andrey Konovalov w= rote: > > Hardware tag-based KASAN uses the memory tagging approach, which requires > all allocations to be aligned to the memory granule size. Align the > allocations to MTE_GRANULE_SIZE via ARCH_SLAB_MINALIGN when > CONFIG_KASAN_HW_TAGS is enabled. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > Reviewed-by: Catalin Marinas Reviewed-by: Alexander Potapenko > --- > Change-Id: I51ebd3f9645e6330e5a92973bf7c86b62d632c2b > --- > arch/arm64/include/asm/cache.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/include/asm/cache.h b/arch/arm64/include/asm/cach= e.h > index 63d43b5f82f6..77cbbe3625f2 100644 > --- a/arch/arm64/include/asm/cache.h > +++ b/arch/arm64/include/asm/cache.h > @@ -6,6 +6,7 @@ > #define __ASM_CACHE_H > > #include > +#include > > #define CTR_L1IP_SHIFT 14 > #define CTR_L1IP_MASK 3 > @@ -51,6 +52,8 @@ > > #ifdef CONFIG_KASAN_SW_TAGS > #define ARCH_SLAB_MINALIGN (1ULL << KASAN_SHADOW_SCALE_SHIFT) > +#elif defined(CONFIG_KASAN_HW_TAGS) > +#define ARCH_SLAB_MINALIGN MTE_GRANULE_SIZE > #endif > > #ifndef __ASSEMBLY__ > -- > 2.29.2.222.g5d2a92d10f8-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg