From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F09C4361B for ; Tue, 15 Dec 2020 22:48:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B54922D02 for ; Tue, 15 Dec 2020 22:48:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B54922D02 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 55F466B005D; Tue, 15 Dec 2020 17:48:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E9906B0068; Tue, 15 Dec 2020 17:48:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B1086B006C; Tue, 15 Dec 2020 17:48:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id 2118F6B005D for ; Tue, 15 Dec 2020 17:48:33 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DDA4A181AEF1D for ; Tue, 15 Dec 2020 22:48:32 +0000 (UTC) X-FDA: 77597007264.03.size98_2c17dd627427 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id B96B128A4E9 for ; Tue, 15 Dec 2020 22:48:32 +0000 (UTC) X-HE-Tag: size98_2c17dd627427 X-Filterd-Recvd-Size: 4354 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 22:48:32 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id l11so43609575lfg.0 for ; Tue, 15 Dec 2020 14:48:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6SRWuFo92SM064QyV0W13yR71kbBhAobGQxQ9l5tQV0=; b=IwokctP9iac7BgaORL9Wl2HAGv8ftuxP51ZoQbpCD5Zay1eYecNU4vUPMmtxGDC7VO lP5x8kkCTqJBcuxHpUSXTiPFzC4yMjyzIRIAu4IzSNSKriMmVxLrPcEpYm+/eiEJlRgp f+npEKCzzkUS8XhDnsGTGEfIh+B+uncpjKGlk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6SRWuFo92SM064QyV0W13yR71kbBhAobGQxQ9l5tQV0=; b=sLFK78H87/Q4kdM9tkTlWcI/mOb1fA56bppISXIZ+7/HCrIIJYbwxDOVlQISquPCMQ 36bfswXTtDIfBDdPa2t5CsC49WXQqrsP6pDp5aJr5ckXq1MPzLVM9nhm+fH8PmnqP/Uj 737mLKnQ82nJyP79VQ/C8T+FFYSgHSnxOPYTRjM+4hgOJlCdgUr3tzXoFROZE1goP5LM 9XwciX70QbN2eJ2JuOvITMRrzldUn2jeull6imk71JDyjBwuAxJNB1ReM20XWzKcprM2 BKINuM81TTwIc1YxnSgO5Wc1baENtbD5I4hwoW0Lemu9dVyfAB4roth8Bgw9oWkProN/ wZzA== X-Gm-Message-State: AOAM530jIFUWlKvPcYdpQqGHxZPP3FBPaF1TOyQjAXpQB1orWnhKNNRT p5W3pWDjVPbxv59T5U3H+7/m5QVo8NhJWg== X-Google-Smtp-Source: ABdhPJzqrgFpuv6SncAM5nXNA2Eu3hF9DCARhH0CrPuCYMuYVRON4fUZw4q24WVGlzIZbeXQmg5Llw== X-Received: by 2002:a2e:9296:: with SMTP id d22mr4231168ljh.197.1608072510173; Tue, 15 Dec 2020 14:48:30 -0800 (PST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com. [209.85.167.48]) by smtp.gmail.com with ESMTPSA id t20sm20137ljk.71.2020.12.15.14.48.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 14:48:29 -0800 (PST) Received: by mail-lf1-f48.google.com with SMTP id o17so40635715lfg.4 for ; Tue, 15 Dec 2020 14:48:29 -0800 (PST) X-Received: by 2002:a05:6512:3048:: with SMTP id b8mr12547465lfb.421.1608072508910; Tue, 15 Dec 2020 14:48:28 -0800 (PST) MIME-Version: 1.0 References: <20201215123253.954eca9a5ef4c0d52fd381fa@linux-foundation.org> In-Reply-To: <20201215123253.954eca9a5ef4c0d52fd381fa@linux-foundation.org> From: Linus Torvalds Date: Tue, 15 Dec 2020 14:48:13 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: incoming To: Andrew Morton Cc: Linux-MM , mm-commits@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 15, 2020 at 12:32 PM Andrew Morton wrote: > > - more MM work: a memcg scalability improvememt > > 19 patches, based on 148842c98a24e508aecb929718818fbf4c2a6ff3. With your re-send, I get all patches, but they don't actually apply cleanly. Is that base correct? I get error: patch failed: mm/huge_memory.c:2750 error: mm/huge_memory.c: patch does not apply Patch failed at 0004 mm/thp: narrow lru locking for that patch "[patch 04/19] mm/thp: narrow lru locking", and that's definitely true: the patch fragment has @@ -2750,7 +2751,7 @@ int split_huge_page_to_list(struct page __dec_lruvec_page_state(head, NR_FILE_THPS); } - __split_huge_page(page, list, end, flags); + __split_huge_page(page, list, end); ret = 0; } else { if (IS_ENABLED(CONFIG_DEBUG_VM) && mapcount) { but that __dec_lruvec_page_state() conversion was done by your previous commit series. So I have the feeling that what you actually mean by "base" isn't actually really the base for that series at all.. I will try to apply it on top of my merge of your previous series instead. Linus