From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3701C63777 for ; Fri, 20 Nov 2020 17:31:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 468A02240B for ; Fri, 20 Nov 2020 17:31:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="BFMI34mC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 468A02240B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 76AD76B0036; Fri, 20 Nov 2020 12:31:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F4A96B005C; Fri, 20 Nov 2020 12:31:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BB906B005D; Fri, 20 Nov 2020 12:31:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 22E496B0036 for ; Fri, 20 Nov 2020 12:31:32 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B0D951F0A for ; Fri, 20 Nov 2020 17:31:31 +0000 (UTC) X-FDA: 77505488382.19.bag03_19035ac2734d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 851321AD1B2 for ; Fri, 20 Nov 2020 17:31:31 +0000 (UTC) X-HE-Tag: bag03_19035ac2734d X-Filterd-Recvd-Size: 4237 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Nov 2020 17:31:30 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id a9so14581521lfh.2 for ; Fri, 20 Nov 2020 09:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lItF3xfzrkMwAcEP2AiG8imrdLGggrsmJi1buDvkPRQ=; b=BFMI34mCS8datX5bZPIO32Ia6Z0khqyvljC/F2ipby+FA8y7zjtEPDzufwkKCXsjGY 0SEsiwdU89ifjQNP6kPAg5YDmJ1pPYqqdG3Ywcja1hlPVrYYsR7s+pMKUtp9768p9l63 Pt/TtziP5KCnD3DRevsTzPb9SNDDLTK2uFSEQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lItF3xfzrkMwAcEP2AiG8imrdLGggrsmJi1buDvkPRQ=; b=Td0g6EDy0NVBd+0eMRK6BB+2KdXl3SVV9h5XrTJrlBAyDusVWp7K/X4kDOzMXagJ38 JFXC61XzWRHwfakOgfeqTuzxy+clatBOiePrJDarU5aLgDhKtTkS7E/sO6nE6/EkDJkT JjbjgLFlAFyximzNNXliX0LPYr6WEFxX/Js1QcHyBQDS6CLtOsm1FUd0BdEDEC6ZIdkV PRcN4uoVCZrY5tCiD8UdS7rROCupasAnbT+GXyCCfVBuUh7RbAU4nB+WIvTobHV/RV+l sELuq/LDGNm9CWn0CbJsZg2a7UEP0AqJnNT0y5pzK0ZwMzcrek9f9Zsp/O57xxTOpRNF OLVQ== X-Gm-Message-State: AOAM532aUcH94K8AmzhbFCQkxuzDzrDBptmYw4BPjeI0nvfkoYucWhms YrDO1AqmMCgOOI9ydCU8YiJ22PkWtkt5zg== X-Google-Smtp-Source: ABdhPJzoFxoCsyvulHXfqmBNAdIBa9/iaFQqCxoEgMKSg2qIT4At7qiAXgUe8oD0ww0+dszJ54zwBQ== X-Received: by 2002:a05:6512:314d:: with SMTP id s13mr7989106lfi.464.1605893488662; Fri, 20 Nov 2020 09:31:28 -0800 (PST) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com. [209.85.208.175]) by smtp.gmail.com with ESMTPSA id o130sm407650lff.277.2020.11.20.09.31.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2020 09:31:26 -0800 (PST) Received: by mail-lj1-f175.google.com with SMTP id r17so10871023ljg.5 for ; Fri, 20 Nov 2020 09:31:26 -0800 (PST) X-Received: by 2002:a2e:9bd2:: with SMTP id w18mr8866461ljj.312.1605893486061; Fri, 20 Nov 2020 09:31:26 -0800 (PST) MIME-Version: 1.0 References: <20201120143557.6715-1-will@kernel.org> <20201120143557.6715-6-will@kernel.org> In-Reply-To: From: Linus Torvalds Date: Fri, 20 Nov 2020 09:31:09 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5/6] tlb: mmu_gather: Introduce tlb_gather_mmu_fullmm() To: Will Deacon Cc: Linux Kernel Mailing List , Android Kernel Team , Catalin Marinas , Yu Zhao , Minchan Kim , Peter Zijlstra , Anshuman Khandual , Linux-MM , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Oh - wait. Not ack. Not because this is wrong, but because I think you should remove the start/end arguments here too. The _only_ thing they were used for was that "fullmm" flag, afaik. So now they no longer make sense. Hmm? Linus On Fri, Nov 20, 2020 at 9:22 AM Linus Torvalds wrote: > > On Fri, Nov 20, 2020 at 6:36 AM Will Deacon wrote: > > > > Introduce tlb_gather_mmu_fullmm() to make it clearer that this is for the > > entire mm and WARN() if tlb_gather_mmu() is called with an 'end' address > > greated than TASK_SIZE. > > Ack (but with a spello note - "greated"). > > Linus