From: Yosry Ahmed <yosryahmed@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: memcg: use rstat for non-hierarchical stats
Date: Tue, 25 Jul 2023 12:25:03 -0700 [thread overview]
Message-ID: <CAJD7tkb47j48TkpH=zwdJZqo5QBehVmyeMMekd6JSbNbR7XLMw@mail.gmail.com> (raw)
In-Reply-To: <20230725104310.ac652a03ab92357a162b1f92@linux-foundation.org>
On Tue, Jul 25, 2023 at 10:43 AM Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> On Tue, 25 Jul 2023 10:04:35 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> > > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
> >
> > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> >
> > But I want to be clear: this isn't a regression fix. It's a new
> > performance optimization for the deprecated cgroup1 code. And it comes
> > at the cost of higher memory footprint for both cgroup1 AND cgroup2.
>
> Thanks.
>
> Yosry, could you please send along a suitably modified changelog?
I will send a v2 once we agree on the history story and whether or not
this fixes a regression.
Thanks!
next prev parent reply other threads:[~2023-07-25 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 17:46 [PATCH] mm: memcg: use rstat for non-hierarchical stats Yosry Ahmed
2023-07-24 18:31 ` Andrew Morton
2023-07-24 18:34 ` Yosry Ahmed
2023-07-25 14:04 ` Johannes Weiner
2023-07-25 17:43 ` Andrew Morton
2023-07-25 19:25 ` Yosry Ahmed [this message]
2023-07-25 19:24 ` Yosry Ahmed
2023-07-25 20:18 ` Johannes Weiner
2023-07-25 22:00 ` Yosry Ahmed
2023-07-25 23:58 ` Yosry Ahmed
2023-07-26 0:29 Yosry Ahmed
2023-07-26 15:32 Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJD7tkb47j48TkpH=zwdJZqo5QBehVmyeMMekd6JSbNbR7XLMw@mail.gmail.com' \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).