From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D08FCC7619A for ; Wed, 12 Apr 2023 17:08:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56BE46B007D; Wed, 12 Apr 2023 13:08:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51994900003; Wed, 12 Apr 2023 13:08:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E233900002; Wed, 12 Apr 2023 13:08:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2F7736B007D for ; Wed, 12 Apr 2023 13:08:32 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EC5BC1C3789 for ; Wed, 12 Apr 2023 17:08:31 +0000 (UTC) X-FDA: 80673372822.15.E3C5656 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf27.hostedemail.com (Postfix) with ESMTP id D74104000B for ; Wed, 12 Apr 2023 17:08:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ub4rOKQi; spf=pass (imf27.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681319310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bHz36P6n/IFFYRn+2wzmmIWjkkyGKKtV0x6DRHklJqg=; b=gbE3yBQCNB23ubLwYi+BJxrWajRMLAiFgMkobHEpXlqlWLKfczbvaKGae2ABDfZiqHMP9U mptfY33Chh01dlNyo4rM7pJ69P4ufF3gMJEtNw/iAGGeHK0u1N3WLGipDtFwv0el4R5rtq nroU8gsp9PM0/8rnSg37PUH6pEQTts0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ub4rOKQi; spf=pass (imf27.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681319310; a=rsa-sha256; cv=none; b=4/qcrss7z9/kM9Vo3c+5QhIY6HOzEoqrMEcVH3vByEQFYcd3eNmMDGSiq+N9eYN6MMGKib YwaeWaWPKmmz+LXcVyfQun3WmdeBqNKdXfV1f8MLRnsA/TjK0W9/kR4sgm+C6gFtjyGUt9 uh/gV4TgVcNaX0hF99BExlBXnU+x6O0= Received: by mail-lf1-f46.google.com with SMTP id h12so10656848lfj.8 for ; Wed, 12 Apr 2023 10:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681319308; x=1683911308; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bHz36P6n/IFFYRn+2wzmmIWjkkyGKKtV0x6DRHklJqg=; b=ub4rOKQiFk3fl6RCjWMFWEwScl/mi0Mb8jEGcN8OPvBVr3WIhDPXcjKhhJ1ZczX1i5 tVHVOvw/fNbZJ8QccOygNweSQ9/o3jZmEqBZXHNaMkdNHQshebFGrAPput/hUzDWombz +Ap9OibnxYWBtlk95HGHSFzUlPr5rdjesByXpKt2Gf9gBbP34ELi8+PzKfPV9Y0hRfsb Jdhpxad+pPNjRpnqmTgq1++zLtw6MTCopw229216FM3jbytkW5wPklMF0WjC/ipL9ZQf TrduHVqxWfQJis0Mq5wGYKh38TgZPkvyHsRdna9mUnlQZjVSMwrJbvopmmuYdWzG5aan GQug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681319308; x=1683911308; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bHz36P6n/IFFYRn+2wzmmIWjkkyGKKtV0x6DRHklJqg=; b=cOAYmYbkx1ZOjaYS5LPGyEgN2gVUJ9FtnleKKHN5k/9m9Q8Dt4proDiWxz5rOoCKJy q1JsRqiQxj4iKSnaOsZi0oIYgc+9cdABX6Tad8QqIYGxS5N4h24/bgnqT0sIIgmvrQNi 6n3x1u5Mokk6C1zbyU0pDl0AAGni78FYpjjFqraMrOA0TPjX9o8/RbGscNeqULYFZz27 t7cXDSaP2B/jR0x7c9+nDWVYxXrFhSy6DL2yb+NAMiN6KGzwSUnRhETbVuD+u3RSZV3v bVZ8Qk8CH2FOx4o5B6LHj7hL1VjnJhy5tIxx0LM36yDYakmJE2vTtmkdB/mj/sdFsThr Spcg== X-Gm-Message-State: AAQBX9cC7JIRWZuAYGvvQThFOCTHuOSZ3ul2gh6llN1mHkZWuIk7mxNO 3Pk3+a3RcFVxQlaOItYb0wiygLSOoIq845Hl1QZb8g== X-Google-Smtp-Source: AKy350aeRD2uyIx+8xPYqOwdHgXc/Hv+zLNUb4oOukQRWLRx6AvonH/xj+JYS9QZTPyjHv8+b8RlxhWgvF30nruae7E= X-Received: by 2002:a19:f717:0:b0:4dc:807a:d140 with SMTP id z23-20020a19f717000000b004dc807ad140mr4424933lfe.10.1681319307825; Wed, 12 Apr 2023 10:08:27 -0700 (PDT) MIME-Version: 1.0 References: <20230412163922.327282-1-peterx@redhat.com> <20230412164234.328168-1-peterx@redhat.com> In-Reply-To: <20230412164234.328168-1-peterx@redhat.com> From: Axel Rasmussen Date: Wed, 12 Apr 2023 10:07:51 -0700 Message-ID: Subject: Re: [PATCH v2 10/31] selftests/mm: Test UFFDIO_ZEROPAGE only when !hugetlb To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Andrea Arcangeli , Mike Kravetz , Nadav Amit , David Hildenbrand , Mike Rapoport , Leonardo Bras Soares Passos Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: mo3k1k9mgmkcsydugbbzuib7dq4d1rc8 X-Rspam-User: X-Rspamd-Queue-Id: D74104000B X-Rspamd-Server: rspam06 X-HE-Tag: 1681319309-117458 X-HE-Meta: U2FsdGVkX19zr9ZmTsGkgor4Xd7ymQr81USWzHlqz5lqO7AFgEqUOsKOelyeCntxAyU8J7JhpewGGNQIHYySmi30apdhP8uyKO8IVKAP+Pi/L23s+fD5EpyKsEhIhV1qMZS6Mc9CC1/1CSCAye8WP9Vc5pKF2duZKIzjOJkf1whdJSyUXHASumChnFnBiIxpSeKaQiaZNSWnxeIj4XTeNurDwF3Q5co8qhYNHgi8+n77sCqWmRcavSZReyc1whuxIbDfofUuWJrSHN1b880/5iIWDFiLesdDQrJ9FrG6p935rLu/raT0XQX47/yQXYR0d/JP8yV9pNAuYCm1NSPblgtOWOUVYVxI2j5i/4TrXCTYB0CH8HSk/GiS2MkkcCW/OAoFS3HMmMwd8CbWe4UopSOBgpuv9KRNbF8to9l3AAG98xVTVpFDvitM0KL2XsOLNEFL+Ad0hCslG3RGqqTYcKAuoSZbshFWsbVZ+6oy2TA1lRFEo6RSxodFXMye8q+mvdFuHrcOyZicm1q9pmrSA2aQSTWMmTl3ozSzEexK3f7vK6LT57FW1daTXwLNUEQfd2br92uwaFJsiRGcjayaWGQ/ZLr4jAByPWkr/RLnoU64cHz1fvYLiN99Sw8PjhADW5jZ9xii3CG1z2rJAd3fmtu5GL75aAYq810AnHtRSQOTPTZ3co42JmpBLDF8nbTL0VpNXWUmBEksUwgTspjrHiYRNOpk7yXV1YybVMulGRSBnjJrQbl8Cn06RB0N1RwFhA6NtbjrSMoZbyZFiWv0W606fQ9WUO1Ue0rmc4w3p8sQjOfS0UbMmxMj7+QbmofFh376j1QTeI7zGJTh1NPPGdX8PT/frWRWtjy96Sayge1ECJFrZXfmo/MkkdUmip0PCB0zXCSPK4asV5ZXvbw0zpZqtExRV85hy/LVRaNaqnhlKYWa5qu0hlR3algikMwyqQjtFpGUldys2gLkdg8 EzbwPq+J mn/ZUdgoUKJWGnMqa+N6h8new2ClzgtKWyHZn2aKvPGU7+a45zSxwCB9uUUNfWHtbeddpuoGbNX4mfwQq84CEPj5oANJ8PUaOHMm4H0ubeI43Sq7LVdDK/s+mnzQyEax2MtMjCqb793EnIYejom99CYxyMwSoXeTl+SbaQwHFawvwM3Hw7cQnNwp8F+fYJTxyPBhtnd/bOgyvbiHCNMTJWuU3vMl6NCEh3gCLjTkYSUIHbMtrQsOCM2KNr3rxh+Vil1jKnt4fKQWZzEnAFrcSGjbwINhhe+RT7gthZzjvnPrCvqjaO7zhGjx+tnw9Q5SY5/Ie6Vuu/IUAgqfybbm6H29EHyVPhK9vzoh/pVmHQYfhaegkxlAMca3m47TB9JGdCqZs3vB4tDlV5wJ6AGYzaEYm4mtYEXsxu3KK71RSQj7x+MFBNCX+9NhG8Rs1phDxJgsAtoU4B8a/8z4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000113, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 12, 2023 at 9:42=E2=80=AFAM Peter Xu wrote: > > Make the check as simple as "test_type =3D=3D TEST_HUGETLB" because that'= s the > only mem that doesn't support ZEROPAGE. > > Signed-off-by: Peter Xu The end state we get to in patch 26 is what I was hoping for - we check the ioctls reported by UFFDIO_REGISTER to decide if we rest this or not. So then this intermediate state used to get rid of get_expected_ioctls() is fine. Reviewed-by: Axel Rasmussen > --- > tools/testing/selftests/mm/userfaultfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/userfaultfd.c b/tools/testing/sel= ftests/mm/userfaultfd.c > index 795fbc4d84f8..d724f1c78847 100644 > --- a/tools/testing/selftests/mm/userfaultfd.c > +++ b/tools/testing/selftests/mm/userfaultfd.c > @@ -1118,7 +1118,7 @@ static int __uffdio_zeropage(int ufd, unsigned long= offset, bool retry) > { > struct uffdio_zeropage uffdio_zeropage; > int ret; > - bool has_zeropage =3D get_expected_ioctls(0) & (1 << _UFFDIO_ZERO= PAGE); > + bool has_zeropage =3D !(test_type =3D=3D TEST_HUGETLB); > __s64 res; > > if (offset >=3D nr_pages * page_size) > -- > 2.39.1 >