From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C03C433E0 for ; Thu, 16 Jul 2020 19:30:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A68B2074B for ; Thu, 16 Jul 2020 19:30:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Lv8wc5MB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A68B2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 791B38D0007; Thu, 16 Jul 2020 15:30:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71E108D0003; Thu, 16 Jul 2020 15:30:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E5398D0007; Thu, 16 Jul 2020 15:30:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 44B8B8D0003 for ; Thu, 16 Jul 2020 15:30:40 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D30978248047 for ; Thu, 16 Jul 2020 19:30:39 +0000 (UTC) X-FDA: 77044930998.10.walk72_1c04d5f26f04 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id A2AD716A0DE for ; Thu, 16 Jul 2020 19:30:39 +0000 (UTC) X-HE-Tag: walk72_1c04d5f26f04 X-Filterd-Recvd-Size: 4630 Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jul 2020 19:30:39 +0000 (UTC) Received: by mail-vs1-f66.google.com with SMTP id s20so3628122vsq.5 for ; Thu, 16 Jul 2020 12:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5JHL6dtY9/obxl6PVDueE6KgqOWo1hP8aToaLoJogXM=; b=Lv8wc5MBk1xMDoVDniZJYSNIRYaVwYd563pj/BmHDv29qhlkxXzVxJn/UycDj5BI55 0o7EKZrbVLG1OH9iMGZCjUaydi2H0vTAwdpEKzb4PDFVmlhuT2w5pIQV1wJSSWKsjDnk fvfiqoflke0iz/+NpbwihrTIcQZdfdIcAV8aHK0JN2ysHxmhrqZbA3VmcRSa9jqUfjsB fMQlsVKQdqcwLjEJX7bJ4Qed9+Rn6rYUC4en/fQ9rUNxGrl03j2+7zPJiON+pYZQfpbO EzxaJQcjLJ5PPVoVTuuALA5gujvbGUxCdHyehPNe2VtYJaHy1nYydB7CQfP374ARk7Zu rU4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5JHL6dtY9/obxl6PVDueE6KgqOWo1hP8aToaLoJogXM=; b=WFImWtgW0JdI9bZqoT2PHnMfc/aHR/3TMJRR/of7vZqv+JGX5fViYYtAd1zbWqWNiL QM8HcohDHY4bLHrINIf6lbg3xk2aYSzk4Zgdc8jCgYpd0p2pq7Rq6l3L+DKzCD8mVB/A vX70N3hUcvNz70HxQoAJrZFVHCnCNyt/3c7LZkR6qoJjcxgL8hCMY1z7zOYEMG48JpyZ YlFQ7yu4Jyg2roj2XU9HUG2eyGDSS3jDODyDUe/trl+5geb5gzuFSqissHASNbUc4kzz l4hWs3/HruVGkHh/bJXqA2Teh852tGPf30wa3TXAGXPEpS9YnHkl0KF2OcMjlO+IJt1t lI7g== X-Gm-Message-State: AOAM5329suBN00YKyWGRVkye1i7gJwLs2VP+78JSi3dZzRI3PQ/mBm6m 3wO9u5CncDUeVGu/nM/f7qtc7wQAWQufxzwPeInFwA== X-Google-Smtp-Source: ABdhPJwWkXtOPLOqrVcmtyJlG0aP+T8u+bPUV6PKoDH5U90Xrq5hIuM+nD03u5LdjnNO/fWF+VkxFtBnpluxWXZxTok= X-Received: by 2002:a67:69c1:: with SMTP id e184mr4865729vsc.119.1594927838113; Thu, 16 Jul 2020 12:30:38 -0700 (PDT) MIME-Version: 1.0 References: <20200716024527.4009170-1-surenb@google.com> <20200716033048.GG1167@sol.localdomain> In-Reply-To: <20200716033048.GG1167@sol.localdomain> From: Suren Baghdasaryan Date: Thu, 16 Jul 2020 12:30:27 -0700 Message-ID: Subject: Re: [PATCH 1/1] staging: android: ashmem: Fix lockdep warning for write operation To: Eric Biggers Cc: Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Michal Hocko , Hillf Danton , "open list:ANDROID DRIVERS" , linux-mm , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A2AD716A0DE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 15, 2020 at 8:30 PM Eric Biggers wrote: > > On Wed, Jul 15, 2020 at 07:45:27PM -0700, Suren Baghdasaryan wrote: > > syzbot report [1] describes a deadlock when write operation against an > > ashmem fd executed at the time when ashmem is shrinking its cache results > > in the following lock sequence: > > > > Possible unsafe locking scenario: > > > > CPU0 CPU1 > > ---- ---- > > lock(fs_reclaim); > > lock(&sb->s_type->i_mutex_key#13); > > lock(fs_reclaim); > > lock(&sb->s_type->i_mutex_key#13); > > > > kswapd takes fs_reclaim and then inode_lock while generic_perform_write > > takes inode_lock and then fs_reclaim. However ashmem does not support > > writing into backing shmem with a write syscall. The only way to change > > its content is to mmap it and operate on mapped memory. Therefore the race > > that lockdep is warning about is not valid. Resolve this by introducing a > > separate lockdep class for the backing shmem inodes. > > > > [1]: https://lkml.kernel.org/lkml/0000000000000b5f9d059aa2037f@google.com/ > > > > Signed-off-by: Suren Baghdasaryan > > Please add proper tags: > > Reported-by: syzbot+7a0d9d0b26efefe61780@syzkaller.appspotmail.com > Fixes: ... > Cc: stable@vger.kernel.org > > > The Reported-by tag to use was given in the original syzbot report. Will add in v2. Thanks! > > - Eric