linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <kernel@gpiccoli.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Guilherme G. Piccoli" <gpiccoli@canonical.com>,
	linux-mm@kvack.org,  linux-kernel@vger.kernel.org,
	Gavin Guo <gavin.guo@canonical.com>,
	 Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [PATCH] mm, compaction: Indicate when compaction is manually triggered by sysctl
Date: Thu, 7 May 2020 23:14:10 -0300	[thread overview]
Message-ID: <CALJn8nNDqWwanhmutCiP-WBLN1eSg2URrG2j5R4kzgHTYObs7Q@mail.gmail.com> (raw)
In-Reply-To: <20200507160438.ed336a1e00c23c6863d75ae5@linux-foundation.org>

On Thu, May 7, 2020 at 8:04 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> Could add it to vmstat?

Hi Andrew, thanks for your suggestion! I thought the same, as a second
potential solution for this..was planning to add as a comment below
the "---" but forgot heheh
I agree that would be great in vmstat, do you have a name suggestion
for it? "compaction_triggered" maybe?


> Userspace could write to /dev/kmsg when it decides to trigger
> compaction?  Although using the kernel log seems a fairly lame way for
> userspace to record its own actions...
Well...you can think that the problem we are trying to solve was more
like...admin forgot if they triggered or not the compaction hehe
So, counting on the user to keep track of it is what I'd like to
avoid. And thinking about drop_caches (that have an indication when
triggered) makes me think this indeed does make sense for compaction
too.
Cheers,

Guilherme


  reply	other threads:[~2020-05-08  2:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 21:59 [PATCH] mm, compaction: Indicate when compaction is manually triggered by sysctl Guilherme G. Piccoli
2020-05-07 23:04 ` Andrew Morton
2020-05-08  2:14   ` Guilherme G. Piccoli [this message]
2020-05-08 18:31     ` David Rientjes
2020-05-08 19:01       ` Guilherme Piccoli
2020-05-11  1:24         ` David Rientjes
2020-05-11 11:26           ` Guilherme Piccoli
2020-05-18  7:06             ` peter enderborg
2020-05-18 12:14               ` Guilherme Piccoli
2020-05-18 12:54                 ` Enderborg, Peter
2020-05-18 13:50                   ` Guilherme Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALJn8nNDqWwanhmutCiP-WBLN1eSg2URrG2j5R4kzgHTYObs7Q@mail.gmail.com \
    --to=kernel@gpiccoli.net \
    --cc=akpm@linux-foundation.org \
    --cc=gavin.guo@canonical.com \
    --cc=gpiccoli@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).