linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yafang Shao <laoar.shao@gmail.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Petr Mladek <pmladek@suse.com>,  Linux MM <linux-mm@kvack.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	 Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH 3/5] test_printf: Remove custom appending of '|'
Date: Wed, 13 Oct 2021 13:21:15 +0800	[thread overview]
Message-ID: <CALOAHbC0imHNzpKHxLzqJkUemowETSDx3veAMaE0ZtySqBmvEg@mail.gmail.com> (raw)
In-Reply-To: <20211012182647.1605095-4-willy@infradead.org>

On Wed, Oct 13, 2021 at 2:32 AM Matthew Wilcox (Oracle)
<willy@infradead.org> wrote:
>
> Instead of having an ifdef to decide whether to print a |, use the
> 'append' functionality of the main loop to print it.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Reviewed-by: Yafang Shao <laoar.shao@gmail.com>

> ---
>  lib/test_printf.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index f744b0498672..60cdf4ba991e 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -616,12 +616,7 @@ page_flags_test(int section, int node, int zone, int last_cpupid,
>         if (flags & PAGEFLAGS_MASK) {
>                 snprintf(cmp_buf + size, BUF_SIZE - size, "%s", name);
>                 size = strlen(cmp_buf);
> -#if SECTIONS_WIDTH || NODES_WIDTH || ZONES_WIDTH || \
> -       LAST_CPUPID_WIDTH || KASAN_TAG_WIDTH
> -               /* Other information also included in page flags */
> -               snprintf(cmp_buf + size, BUF_SIZE - size, "|");
> -               size = strlen(cmp_buf);
> -#endif
> +               append = true;
>         }
>
>         for (i = 0; i < ARRAY_SIZE(pft); i++) {
> --
> 2.32.0
>


-- 
Thanks
Yafang


  reply	other threads:[~2021-10-13  5:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 18:26 [PATCH 0/5] Improvements to %pGp Matthew Wilcox (Oracle)
2021-10-12 18:26 ` [PATCH 1/5] test_printf: Make pft array const Matthew Wilcox (Oracle)
2021-10-13  5:20   ` Yafang Shao
2021-10-15  9:21   ` Petr Mladek
2021-10-18  5:32   ` Anshuman Khandual
2021-10-12 18:26 ` [PATCH 2/5] test_printf: Assign all flags to page_flags Matthew Wilcox (Oracle)
2021-10-13  5:20   ` Yafang Shao
2021-10-13  9:25   ` Kirill A. Shutemov
2021-10-15 10:22     ` Petr Mladek
2021-10-18  5:33     ` Anshuman Khandual
2021-10-15 10:14   ` Petr Mladek
2021-10-12 18:26 ` [PATCH 3/5] test_printf: Remove custom appending of '|' Matthew Wilcox (Oracle)
2021-10-13  5:21   ` Yafang Shao [this message]
2021-10-15 10:23     ` Petr Mladek
2021-10-18  5:41   ` Anshuman Khandual
2021-10-12 18:26 ` [PATCH 4/5] test_printf: Append '|' more efficiently Matthew Wilcox (Oracle)
2021-10-13  5:22   ` Yafang Shao
2021-10-13  9:27     ` Kirill A. Shutemov
2021-10-18  5:42       ` Anshuman Khandual
2021-10-13  9:59     ` Rasmus Villemoes
2021-10-15 10:37       ` Petr Mladek
2021-10-12 18:26 ` [PATCH 5/5] vsprintf: Make %pGp print the hex value Matthew Wilcox (Oracle)
2021-10-13  5:24   ` Yafang Shao
2021-10-15 10:55   ` Petr Mladek
2021-10-27 11:28     ` Petr Mladek
2021-10-18  6:13   ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALOAHbC0imHNzpKHxLzqJkUemowETSDx3veAMaE0ZtySqBmvEg@mail.gmail.com \
    --to=laoar.shao@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=pmladek@suse.com \
    --cc=senozhatsky@chromium.org \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).