From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48DD9C282DD for ; Sat, 11 Jan 2020 00:24:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A3602082E for ; Sat, 11 Jan 2020 00:24:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SmX5zYon" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A3602082E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A1E628E0006; Fri, 10 Jan 2020 19:24:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CE208E0001; Fri, 10 Jan 2020 19:24:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E4278E0006; Fri, 10 Jan 2020 19:24:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 792348E0001 for ; Fri, 10 Jan 2020 19:24:05 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 19515181AEF00 for ; Sat, 11 Jan 2020 00:24:05 +0000 (UTC) X-FDA: 76363456050.30.salt40_239f750d4654e X-HE-Tag: salt40_239f750d4654e X-Filterd-Recvd-Size: 3213 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jan 2020 00:24:04 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id 59so3676348otp.12 for ; Fri, 10 Jan 2020 16:24:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G+JPdmbTt0+yq7xgA9xx/1MNE9mXhCi0WakjpzpM0nc=; b=SmX5zYon81AqjnJHQ1JB7Z6jxf/3WEnK/r/U/nn1ND9UafXh5g0ELEG7BdenRw2RY3 Pjd1GOb7XIg6KX8hTpQTR/go8DHP2oNuTpTp0IbxUiZgxUi6B/lPi0ThzHyYCggkO792 wNr1u+U5ynqq4lvRN+tbjH267PhKt1cpSTkBxrVkoAhNUORfZK+2kotsa9ahK9UXx+Yo XmWZfaFoZCpJHWkFGhjwLandR+StNjAYlUF449qiEt/hAdLs55rNyd0Phr18YhLEj+ar WCEOPcC+s0MHKE95JAxH6t3UMch0u3nv+vGU2cpuNM308mK6t94yQl4jAEi1ocqmeMhb Thqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G+JPdmbTt0+yq7xgA9xx/1MNE9mXhCi0WakjpzpM0nc=; b=aHUkwCAeaQsHQ9mRlV7c5qndEX9rCMQ68By6YRkUgZBauzSSive5t6/RY4ZsO6yo+4 fY3NPAnHac2Is2kdg10sy9k6+3zcHOEG6GonntUg9GOk/o3PB0uKiHD14ZjvkHiTLZza aV0Di+bQdWPdYQRH/jJrrjkjHhY6UlKE5aM+M8zlH52UFN/rrwf+E8O3jKaYlTtH1e3d eJFK25duh9GJB8/2pcKMj8blPfpYeLe8d2AtT5Y1QIsnt+G4wKgA005fD/Rygn7KUcA9 SNxKOrtDZTcRi3ZNAgwpoChc/j49l+Fa09I7DMk9li1GigBOoRT9bkLzQcL5sWJyIO3J Y80Q== X-Gm-Message-State: APjAAAUrPiDebwoz0PWtW0jY/ddozwm5cgWHNIK6dO2xzTXfZTLaa6Io wEc53GJaZcn1mLuHqL4xLPUGzxBKZoD8tLivgXRMjg== X-Google-Smtp-Source: APXvYqw6Iqeg5rAtrOp7nb+NJ5t/jmryneW6ZegFOQPCpITX53S1be5+B5cO0snmqu9Lml6auQPWlV8+8HVX5eeOulg= X-Received: by 2002:a9d:7c90:: with SMTP id q16mr5014707otn.191.1578702243840; Fri, 10 Jan 2020 16:24:03 -0800 (PST) MIME-Version: 1.0 References: <20200109202659.752357-1-guro@fb.com> <20200109202659.752357-3-guro@fb.com> In-Reply-To: <20200109202659.752357-3-guro@fb.com> From: Shakeel Butt Date: Fri, 10 Jan 2020 16:23:52 -0800 Message-ID: Subject: Re: [PATCH v2 2/6] mm: kmem: cleanup memcg_kmem_uncharge_memcg() arguments To: Roman Gushchin Cc: Linux MM , Andrew Morton , Michal Hocko , Johannes Weiner , Vladimir Davydov , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 9, 2020 at 12:27 PM Roman Gushchin wrote: > > Drop the unused page argument and put the memcg pointer at the first > place. This make the function consistent with its peers: > __memcg_kmem_uncharge_memcg(), memcg_kmem_charge_memcg(), etc. > > Signed-off-by: Roman Gushchin Why not squash this patch in the previous one? Reviewed-by: Shakeel Butt