From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 846E8FA372C for ; Thu, 7 Nov 2019 02:51:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 41EDC20679 for ; Thu, 7 Nov 2019 02:51:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lHGybIy/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41EDC20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E943F6B0008; Wed, 6 Nov 2019 21:51:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E44306B000A; Wed, 6 Nov 2019 21:51:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5A336B000C; Wed, 6 Nov 2019 21:51:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id C52556B0008 for ; Wed, 6 Nov 2019 21:51:14 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 78F7E180AD815 for ; Thu, 7 Nov 2019 02:51:14 +0000 (UTC) X-FDA: 76127954868.24.bells26_ac9a971eeb3e X-HE-Tag: bells26_ac9a971eeb3e X-Filterd-Recvd-Size: 5004 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Nov 2019 02:51:13 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id e17so711207otk.6 for ; Wed, 06 Nov 2019 18:51:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GKO7/fbdppvBINU5UzZk1jxJvjGwB3qbyKeLUMFG0WY=; b=lHGybIy/4+Wd5Xs4rFF43Igo7QNmIxIkOuOeO28hVod0YQrbdceC97gt53BQZ/IXhX 5XUSf0vl69ZMl/BHL/QP2dXa5rAauS3uo4T33ETfaQHSlKrFGEKWmMkuA1mx95AcHix5 x+/uzcZlA1JTfMck4Lia9FP9eTVtJHq8rJTe6Zd977QZlsYRi4cOhgWUCFGnv2iXZiyA 1qfoMzmCQ3/yTKxORuIPubW5CpJM2JJczPR77EO8tyN+1q5X8jHiaB+vPpZ2r6SMTQNt f+gBkwqBIA7GiVBBHaRKE5Ooff8jHI6UtIccu7HdP9NybJy8Dp0ur2UrYxED2hpmKSPf PAUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GKO7/fbdppvBINU5UzZk1jxJvjGwB3qbyKeLUMFG0WY=; b=rCEGTRiOlEfG28GiDHtn3tikeNCGGkrvPZaz2mHHEL+RhVzHSNcG5VNeIRQkY829k5 ck4JcTgtvM4//w7PT1xiaDf6q6DUV0WREdA4Yimk0bAxJjS3v7mo8u0VuLIchxIQTZLc qmtfTfOSOa23UdMl1n7sE3CLnkQDXNr4eGrU2DKSOsc9YLqRcLKqjnUxZpusgeuO/v/4 CY7x48phMdQoky5WUId+XP+qvoNanLankf0cED6Kb1qljN+2REK6C2rMu4ZT11zoWkAg grZ2WUuScYWy22AwFF5N62qAAP/gty6zz55+e2pLnVi01qdsxCs2YqwFVjPE/3sTlf+d vfzw== X-Gm-Message-State: APjAAAUdW5mwJfxHBjYVdlTGljvl6vuq7izxgItzOzwgEYVl11CHfHa5 9eA0m6eYD04OfUr07eNfF6VfwMXPeT06hHKP/+rNWQ== X-Google-Smtp-Source: APXvYqzzv7HIbB64JiAktrqXuieu+Qi+ofExLaTWbbpI/vhljtRTUn8VDqOTsN6GKkLyWX6YVdkOZMePuaQRtZtspAA= X-Received: by 2002:a9d:71cc:: with SMTP id z12mr840037otj.124.1573095073108; Wed, 06 Nov 2019 18:51:13 -0800 (PST) MIME-Version: 1.0 References: <20190603210746.15800-1-hannes@cmpxchg.org> <20190603210746.15800-4-hannes@cmpxchg.org> In-Reply-To: <20190603210746.15800-4-hannes@cmpxchg.org> From: Shakeel Butt Date: Wed, 6 Nov 2019 18:51:02 -0800 Message-ID: Subject: Re: [PATCH 03/11] mm: vmscan: simplify lruvec_lru_size() To: Johannes Weiner Cc: Andrew Morton , Andrey Ryabinin , Suren Baghdasaryan , Michal Hocko , Linux MM , Cgroups , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 3, 2019 at 2:59 PM Johannes Weiner wrote: > > This function currently takes the node or lruvec size and subtracts > the zones that are excluded by the classzone index of the > allocation. It uses four different types of counters to do this. > > Just add up the eligible zones. > > Signed-off-by: Johannes Weiner I think this became part of other series. Anyways: Reviewed-by: Shakeel Butt > --- > mm/vmscan.c | 19 +++++-------------- > 1 file changed, 5 insertions(+), 14 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 853be16ee5e2..69c4c82a9b5a 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -342,30 +342,21 @@ unsigned long zone_reclaimable_pages(struct zone *zone) > */ > unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru, int zone_idx) > { > - unsigned long lru_size; > + unsigned long size = 0; > int zid; > > - if (!mem_cgroup_disabled()) > - lru_size = lruvec_page_state_local(lruvec, NR_LRU_BASE + lru); > - else > - lru_size = node_page_state(lruvec_pgdat(lruvec), NR_LRU_BASE + lru); > - > - for (zid = zone_idx + 1; zid < MAX_NR_ZONES; zid++) { > + for (zid = 0; zid <= zone_idx; zid++) { > struct zone *zone = &lruvec_pgdat(lruvec)->node_zones[zid]; > - unsigned long size; > > if (!managed_zone(zone)) > continue; > > if (!mem_cgroup_disabled()) > - size = mem_cgroup_get_zone_lru_size(lruvec, lru, zid); > + size += mem_cgroup_get_zone_lru_size(lruvec, lru, zid); > else > - size = zone_page_state(&lruvec_pgdat(lruvec)->node_zones[zid], > - NR_ZONE_LRU_BASE + lru); > - lru_size -= min(size, lru_size); > + size += zone_page_state(zone, NR_ZONE_LRU_BASE + lru); > } > - > - return lru_size; > + return size; > > } > > -- > 2.21.0 >