From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BB64C433DF for ; Wed, 27 May 2020 19:48:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C429920C56 for ; Wed, 27 May 2020 19:48:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TnvOhSKl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C429920C56 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4F9E18001A; Wed, 27 May 2020 15:48:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A94780010; Wed, 27 May 2020 15:48:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 398D48001A; Wed, 27 May 2020 15:48:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 1DA6680010 for ; Wed, 27 May 2020 15:48:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BDBC2C8F02 for ; Wed, 27 May 2020 19:48:33 +0000 (UTC) X-FDA: 76863536106.03.debt33_84e59bd77d808 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 97A4C28A4E9 for ; Wed, 27 May 2020 19:48:33 +0000 (UTC) X-HE-Tag: debt33_84e59bd77d808 X-Filterd-Recvd-Size: 3502 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 19:48:33 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id m12so28047600ljc.6 for ; Wed, 27 May 2020 12:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5aQnJXyiQA3IowsNfVoOSqHgT1OkRmP0E5K+YnP6bZ0=; b=TnvOhSKlFxE31tFdDGs7QlyMOK6Y7cUfkHrTbOmzpDgDbGW+JPoveR4i0MYR41TeBh z3XnFBVgJIiV5+i6dphaBvKpRVeqDNoT8mp9flwB3oLqK1X+fKUW4N0cq1KlbOxLaPD9 Oa23F4+5CyZa0ZuPBk7SL9bZg/5tT/T3VwRO4DQnpNMjhqK/pwF2PDzUOFa1n1wSpaeh EwhNhB4cA+b/YBoGMYrYiD2SZEprrV0KkYUySrjMaaqPGLzkzYx+J+ACdgcVMl8lAxwC 0oA2BItbx/b+YNSeQcDZX1HHFzlW05hAPbrEyTQnb8VcyMMKWD1rAKGjasJC4kcIOcN/ ZeIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5aQnJXyiQA3IowsNfVoOSqHgT1OkRmP0E5K+YnP6bZ0=; b=VlnMx90YWbG6uNL46h/mSmStwKZxj7RAzTjEbaE/gQbJ5t4rPW/lLJF3DNXmu1+cyP fDBgYVT3sI+ZbeWtskvrIHQMxOJxC0N/Wyuwmod9ASif4D6tZnoKVBCbz5cwTND1XfTl +cenRVBy7UuiwVFNaq/Ieuv26xnKu/eSloAz1PA/3HJelLw978vQGC2tNFeXLD4AVxhg JETOiEju1hibbNBWMhUqjtNriA5DJomXekfq9Sv9IqBSCRmIS6a0I03Cu+jvE/ueNKJl 3z4SFXiaAuYqBtCnNUbwxMWWW0K/KeTyDdR5crq+eBfBmwrc/f1VxIbzQg0pXQpXveI1 Eq7A== X-Gm-Message-State: AOAM533QN7k2oTGsi4vopZbrgv27wHoBEbaRf4Ay5qzoexSze5Vtdb2j 2ivuXVksHcjmY0YZWRM7haYOdD19RvpVvhlxZd+ibA== X-Google-Smtp-Source: ABdhPJyEZKW3APXVi32eLvyHMFmU9WePyudCh1ndYkbgbtfCupI8fzy9fNXJFu97bCHQmtzpSyDl6UVJ40xglAwJ4VY= X-Received: by 2002:a2e:8e79:: with SMTP id t25mr4050863ljk.446.1590608911447; Wed, 27 May 2020 12:48:31 -0700 (PDT) MIME-Version: 1.0 References: <20200520232525.798933-1-hannes@cmpxchg.org> <20200520232525.798933-2-hannes@cmpxchg.org> In-Reply-To: <20200520232525.798933-2-hannes@cmpxchg.org> From: Shakeel Butt Date: Wed, 27 May 2020 12:48:20 -0700 Message-ID: Subject: Re: [PATCH 01/14] mm: fix LRU balancing effect of new transparent huge pages To: Johannes Weiner Cc: Linux MM , Rik van Riel , Minchan Kim , Michal Hocko , Andrew Morton , Joonsoo Kim , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 97A4C28A4E9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 20, 2020 at 4:28 PM Johannes Weiner wrote: > > Currently, THP are counted as single pages until they are split right > before being swapped out. However, at that point the VM is already in > the middle of reclaim, and adjusting the LRU balance then is useless. > > Always account THP by the number of basepages, and remove the fixup > from the splitting path. > > Signed-off-by: Johannes Weiner > Reviewed-by: Rik van Riel > Acked-by: Michal Hocko > Acked-by: Minchan Kim Reviewed-by: Shakeel Butt