From: Shakeel Butt <shakeelb@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Minchan Kim <minchan@kernel.org>,
Huang Ying <ying.huang@intel.com>,
Mel Gorman <mgorman@techsingularity.net>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Thelen <gthelen@google.com>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mm,vmscan: Kill global shrinker lock.
Date: Fri, 17 Nov 2017 09:53:22 -0800 [thread overview]
Message-ID: <CALvZod5b8EBgJ=jTWfAs97zn3D9WPDP5j-2qAR5FGEYrn0GM6Q@mail.gmail.com> (raw)
In-Reply-To: <CALvZod7Mrs8=5A2j=x96vaUcjCMSxVYi6RVLaKF23UENcAPLvw@mail.gmail.com>
On Fri, Nov 17, 2017 at 9:41 AM, Shakeel Butt <shakeelb@google.com> wrote:
> On Fri, Nov 17, 2017 at 9:35 AM, Christoph Hellwig <hch@infradead.org> wrote:
>> On Tue, Nov 14, 2017 at 06:37:42AM +0900, Tetsuo Handa wrote:
>>> Since do_shrink_slab() can reschedule, we cannot protect shrinker_list
>>> using one RCU section. But using atomic_inc()/atomic_dec() for each
>>> do_shrink_slab() call will not impact so much.
>>
>> But you could use SRCU..
>
> I looked into that but was advised to not go through that route due to
> SRCU behind the CONFIG_SRCU. However now I see the precedence of
> "#ifdef CONFIG_SRCU" in drivers/base/core.c and I think if we can take
> that route if even after Minchan's patch the issue persists.
Too many 'ifs' in the last sentence. I just wanted to say we can
consider SRCU if the issue persists even after Minchan's patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-17 17:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 21:37 [PATCH 1/2] mm,vmscan: Kill global shrinker lock Tetsuo Handa
2017-11-13 21:37 ` [PATCH 2/2] mm,vmscan: Allow parallel registration/unregistration of shrinkers Tetsuo Handa
2017-11-13 22:05 ` [PATCH 1/2] mm,vmscan: Kill global shrinker lock Shakeel Butt
2017-11-15 0:56 ` Minchan Kim
2017-11-15 6:28 ` Shakeel Butt
2017-11-16 0:46 ` Minchan Kim
2017-11-16 1:41 ` Shakeel Butt
2017-11-16 4:50 ` Minchan Kim
2017-11-15 8:56 ` Michal Hocko
2017-11-15 9:18 ` Michal Hocko
2017-11-16 17:44 ` Johannes Weiner
2017-11-23 23:46 ` Minchan Kim
2017-11-15 9:02 ` Michal Hocko
2017-11-15 10:58 ` Tetsuo Handa
2017-11-15 11:51 ` Michal Hocko
2017-11-16 0:56 ` Minchan Kim
2017-11-15 13:28 ` Johannes Weiner
2017-11-16 10:56 ` Tetsuo Handa
2017-11-15 14:00 ` Johannes Weiner
2017-11-15 14:11 ` Michal Hocko
2018-01-25 2:04 ` Tetsuo Handa
2018-01-25 8:36 ` Michal Hocko
2018-01-25 10:56 ` Tetsuo Handa
2018-01-25 11:41 ` Michal Hocko
2018-01-25 22:19 ` Eric Wheeler
2018-01-26 3:12 ` Tetsuo Handa
2018-01-26 10:08 ` Michal Hocko
2017-11-17 17:35 ` Christoph Hellwig
2017-11-17 17:41 ` Shakeel Butt
2017-11-17 17:53 ` Shakeel Butt [this message]
2017-11-17 18:36 ` Christoph Hellwig
2017-11-20 9:25 ` Michal Hocko
2017-11-20 9:33 ` Christoph Hellwig
2017-11-20 9:42 ` Michal Hocko
2017-11-20 10:41 ` Christoph Hellwig
2017-11-20 10:56 ` Tetsuo Handa
2017-11-20 18:28 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALvZod5b8EBgJ=jTWfAs97zn3D9WPDP5j-2qAR5FGEYrn0GM6Q@mail.gmail.com' \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=vdavydov.dev@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).