From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C17C33CA4 for ; Sat, 11 Jan 2020 00:28:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D7FD20838 for ; Sat, 11 Jan 2020 00:28:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TwKbw/ma" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D7FD20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2EE378E0005; Fri, 10 Jan 2020 19:28:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 277B58E0001; Fri, 10 Jan 2020 19:28:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 167158E0005; Fri, 10 Jan 2020 19:28:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id F1FF88E0001 for ; Fri, 10 Jan 2020 19:28:34 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 85C358248041 for ; Sat, 11 Jan 2020 00:28:34 +0000 (UTC) X-FDA: 76363467348.29.duck10_4ad2cddb23e3a X-HE-Tag: duck10_4ad2cddb23e3a X-Filterd-Recvd-Size: 3262 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jan 2020 00:28:34 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id r9so3692632otp.13 for ; Fri, 10 Jan 2020 16:28:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NJNkeTlQeivzybUuWcx9iwSzhzlDjNiYUt081VfoN4c=; b=TwKbw/maTje9O+6K+AaSChQ3qI7lnU05ARSs0EJm+ULMqILrCJLwsvhBP7NhMsDYVW Sy+DSLyCZwJr/9LoAfM/h+x6S+FrcD/7ASrj5IVeb8j6lE0mlxL2Hj8ajX9gV9mm5ZC8 H9dB/o9QJQlpmb8VeCy1owDzjedi0JBlbAag2P6wvvmbzTC+zWK618sI9T0Ip6obAU61 fqPrK3D+C3bQowSmWKnZyGThkNiBpLN3Z9vkbSEhZ/7mG6FKhJOaNmH3cJ8Masbu962F AmtS6Ns7Tn2J87fZDOcddZkZzcdTBA5E28OjaKb7qkCFG76BKUnNZSvm22nTKpEsAout y/og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NJNkeTlQeivzybUuWcx9iwSzhzlDjNiYUt081VfoN4c=; b=W6SW8CpAOV9ZVwPA/La3GmXt5TXd/IvXSzuoAjm+HFEGI0uTiJU/qiId6u4un++Djq zW0aUtMbNKbmU+j3jrwup68N3Bf+mra1D5tpaLDyp7SWymjr1kO7TxdXrxguoclGQeFh XWX+RO+7waZVL9SBnt0hWRCD0n8J6M/ikiWgf6HMMxvJN/ujpUT6ogcmwSv4ee7eiT1y 51DHrbT59DpHiPkQNdMYvw2abhgaOZh069RdTS4WbeungoPNU9+RoNS3coh8MJQxBAv8 DbRzvQNmG8kfOEnHi5CL/C9lE+UFnL6TUcc9iWhcDALZ9Ow/G1ulz+sy/qhAHxuHKANk 1IMQ== X-Gm-Message-State: APjAAAWoIAbMvYnG1jbpg/LkjWC2Py40TBxnXh4JO1RRAnFIgErkJ1RA GQQASEVFAooHd/6CiNgtutmBQyPPlAstCowfYVWHPQ== X-Google-Smtp-Source: APXvYqzix9yfkezMicGVnwOPqgQD9fq0U9kpLygPZIeiqIZ0LYEG/OhqYmMoZ1F9dWJUX+jVXmOmR4gPatuKT+srtok= X-Received: by 2002:a9d:7c8a:: with SMTP id q10mr4622088otn.124.1578702513230; Fri, 10 Jan 2020 16:28:33 -0800 (PST) MIME-Version: 1.0 References: <20200109202659.752357-1-guro@fb.com> <20200109202659.752357-6-guro@fb.com> In-Reply-To: <20200109202659.752357-6-guro@fb.com> From: Shakeel Butt Date: Fri, 10 Jan 2020 16:28:22 -0800 Message-ID: Subject: Re: [PATCH v2 5/6] mm: memcg/slab: cache page number in memcg_(un)charge_slab() To: Roman Gushchin Cc: Linux MM , Andrew Morton , Michal Hocko , Johannes Weiner , Vladimir Davydov , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 9, 2020 at 12:27 PM Roman Gushchin wrote: > > There are many places in memcg_charge_slab() and memcg_uncharge_slab() > which are calculating the number of pages to charge, css references to > grab etc depending on the order of the slab page. > > Let's simplify the code by calculating it once and caching in the > local variable. > > Signed-off-by: Roman Gushchin Reviewed-by: Shakeel Butt