From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6989C4361B for ; Tue, 8 Dec 2020 02:43:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 04FCF23433 for ; Tue, 8 Dec 2020 02:43:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04FCF23433 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B80D8D0007; Mon, 7 Dec 2020 21:43:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73FA28D0001; Mon, 7 Dec 2020 21:43:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E26F8D0007; Mon, 7 Dec 2020 21:43:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 43CC18D0001 for ; Mon, 7 Dec 2020 21:43:36 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0C8128249980 for ; Tue, 8 Dec 2020 02:43:36 +0000 (UTC) X-FDA: 77568569232.26.cover42_220dbd3273e3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id D80E11804B660 for ; Tue, 8 Dec 2020 02:43:35 +0000 (UTC) X-HE-Tag: cover42_220dbd3273e3 X-Filterd-Recvd-Size: 4652 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 02:43:35 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id v3so6186184plz.13 for ; Mon, 07 Dec 2020 18:43:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jdb7C5Aq6omc7IwwxIaz9ZxTwUguDQHTm2UuR3rHd+Y=; b=ydR/LN6K9fneUKUhkvE0+Qv6s3BVCHWfdKrE8qmGsJQvTKxAvH9WDn3PvEV1YToQ++ ENpqHWssU08a9ws5Cz79XXu2j8Q0956aFERX3PY4UC1SSHoXCBCdCGV/rgwtWULf+KOC szt0cHALCdHrYWL4imlZnAkQp9vw0sgOXP0WXl1BcK0B2RH9Ba1SV/nEg7H9W2ZSk00y risTzoaMsDDNspp3wyshZifGP61j6MGm1spuBHXbJ9fRUy491LUSUAXxifd/Pyb/+qJy R6tsRdYWrGbaeU6n5MgdwPuTfvydofDO5YHGF6V+LZJ0YJeNSm19aKSbA34QXd277huE dLwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jdb7C5Aq6omc7IwwxIaz9ZxTwUguDQHTm2UuR3rHd+Y=; b=aCWZWEeyteMK/5GKUD8CZwjR8gbL/kzf7eVv5xt+hlvHwox1eaQeY4W4Lgedsw10Pj J/RAjIoKsltL6UPu1bNXyWDuOe4xbODlfZoH/GwqVymoOsbUOLK1J6YIstEw9IPii7uN vytHrD5oN/mj+eTDWpA5hmIbzWeSnDIKXwsSG54h17lZYjvCclDqLjvWhnUssJp1DAU5 dq7b3Gr4c0YzYDH1ntuymx/YqWsftZkTHcjEi9ZjheikMKIiZgEzVjbViYGhkGDbTh+r /5PlfZRjIhYetUjdOvA5F1+2mO4hDXQlK3HZHmfsydl31mUXV7FKBvxysMG1yfcTAQKf 773w== X-Gm-Message-State: AOAM531o5t+dLY8c85x2CSO8P2Cu9lIE44I5mWqnTgDfV1uk1NtZEsp4 MHWtvOejTP/NgLHydPnqhbz8nYmhv+habTos+8z4Tw== X-Google-Smtp-Source: ABdhPJyPzEAErBPAXhs9T4MgPYqRu/l5uY0/YAfd1sbtAWYcjj6t0I1hQ8V/3A5xcAjooM+5EAgJiAjAFZSjaBHO4E0= X-Received: by 2002:a17:902:bb92:b029:d9:e9bf:b775 with SMTP id m18-20020a170902bb92b02900d9e9bfb775mr19302708pls.24.1607395414374; Mon, 07 Dec 2020 18:43:34 -0800 (PST) MIME-Version: 1.0 References: <20201206101451.14706-1-songmuchun@bytedance.com> <20201207130018.GJ25569@dhcp22.suse.cz> <20201207150254.GL25569@dhcp22.suse.cz> <20201207195141.GB2238414@carbon.dhcp.thefacebook.com> In-Reply-To: From: Muchun Song Date: Tue, 8 Dec 2020 10:42:58 +0800 Message-ID: Subject: Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes To: Hugh Dickins Cc: Roman Gushchin , Michal Hocko , Greg KH , rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Vladimir Davydov , Will Deacon , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 8, 2020 at 4:33 AM Hugh Dickins wrote: > > On Mon, 7 Dec 2020, Roman Gushchin wrote: > > On Mon, Dec 07, 2020 at 04:02:54PM +0100, Michal Hocko wrote: > > > > > > As I've said the THP accounting change makes more sense to me because it > > > allows future changes which are already undergoing so there is more > > > merit in those. > > > > +1 > > And this part is absolutely trivial. > > It does need to be recognized that, with these changes, every THP stats > update overflows the per-cpu counter, resorting to atomic global updates. > And I'd like to see that mentioned in the commit message. Thanks for reminding me. Will add. > > But this change is consistent with 4.7's 8f182270dfec ("mm/swap.c: flush > lru pvecs on compound page arrival"): we accepted greater overhead for > greater accuracy back then, so I think it's okay to do so for THP stats. Agree. Thanks. > > Hugh -- Yours, Muchun