From: Muchun Song <songmuchun@bytedance.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Jann Horn <jannh@google.com>,
Youquan Song <youquan.song@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>, Jan Kara <jack@suse.cz>,
John Hubbard <jhubbard@nvidia.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [External] [PATCH 1/2] hugetlb: remove prep_compound_huge_page cleanup
Date: Tue, 22 Jun 2021 17:09:14 +0800 [thread overview]
Message-ID: <CAMZfGtVqJjVVgG+sd33er8Eg-MieF7V=nVExvQZTFhbxteaCGQ@mail.gmail.com> (raw)
In-Reply-To: <20210622021423.154662-2-mike.kravetz@oracle.com>
On Tue, Jun 22, 2021 at 10:15 AM Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> The routine prep_compound_huge_page is a simple wrapper to call either
> prep_compound_gigantic_page or prep_compound_page. However, it is only
> called from gather_bootmem_prealloc which only processes gigantic pages.
> Eliminate the routine and call prep_compound_gigantic_page directly.
>
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Nice clean-up. Thanks.
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
> ---
> mm/hugetlb.c | 29 ++++++++++-------------------
> 1 file changed, 10 insertions(+), 19 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 760b5fb836b8..50596b7d6da9 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1320,8 +1320,6 @@ static struct page *alloc_gigantic_page(struct hstate *h, gfp_t gfp_mask,
> return alloc_contig_pages(nr_pages, gfp_mask, nid, nodemask);
> }
>
> -static void prep_new_huge_page(struct hstate *h, struct page *page, int nid);
> -static void prep_compound_gigantic_page(struct page *page, unsigned int order);
> #else /* !CONFIG_CONTIG_ALLOC */
> static struct page *alloc_gigantic_page(struct hstate *h, gfp_t gfp_mask,
> int nid, nodemask_t *nodemask)
> @@ -2759,16 +2757,10 @@ int __alloc_bootmem_huge_page(struct hstate *h)
> return 1;
> }
>
> -static void __init prep_compound_huge_page(struct page *page,
> - unsigned int order)
> -{
> - if (unlikely(order > (MAX_ORDER - 1)))
> - prep_compound_gigantic_page(page, order);
> - else
> - prep_compound_page(page, order);
> -}
> -
> -/* Put bootmem huge pages into the standard lists after mem_map is up */
> +/*
> + * Put bootmem huge pages into the standard lists after mem_map is up.
> + * Note: This only applies to gigantic (order > MAX_ORDER) pages.
> + */
> static void __init gather_bootmem_prealloc(void)
> {
> struct huge_bootmem_page *m;
> @@ -2777,20 +2769,19 @@ static void __init gather_bootmem_prealloc(void)
> struct page *page = virt_to_page(m);
> struct hstate *h = m->hstate;
>
> + VM_BUG_ON(!hstate_is_gigantic(h));
> WARN_ON(page_count(page) != 1);
> - prep_compound_huge_page(page, huge_page_order(h));
> + prep_compound_gigantic_page(page, huge_page_order(h));
> WARN_ON(PageReserved(page));
> prep_new_huge_page(h, page, page_to_nid(page));
> put_page(page); /* free it into the hugepage allocator */
>
> /*
> - * If we had gigantic hugepages allocated at boot time, we need
> - * to restore the 'stolen' pages to totalram_pages in order to
> - * fix confusing memory reports from free(1) and another
> - * side-effects, like CommitLimit going negative.
> + * We need to restore the 'stolen' pages to totalram_pages
> + * in order to fix confusing memory reports from free(1) and
> + * other side-effects, like CommitLimit going negative.
> */
> - if (hstate_is_gigantic(h))
> - adjust_managed_page_count(page, pages_per_huge_page(h));
> + adjust_managed_page_count(page, pages_per_huge_page(h));
> cond_resched();
> }
> }
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-06-22 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 2:14 [PATCH 0/2] Fix prep_compound_gigantic_page ref count adjustment Mike Kravetz
2021-06-22 2:14 ` [PATCH 1/2] hugetlb: remove prep_compound_huge_page cleanup Mike Kravetz
2021-06-22 9:09 ` Muchun Song [this message]
2021-06-22 2:14 ` [PATCH 2/2] hugetlb: address ref count racing in prep_compound_gigantic_page Mike Kravetz
2021-06-23 8:00 ` [External] " Muchun Song
2021-06-24 0:26 ` Mike Kravetz
2021-06-24 3:38 ` Muchun Song
2021-06-22 2:16 ` [PATCH 0/2] Fix prep_compound_gigantic_page ref count adjustment Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZfGtVqJjVVgG+sd33er8Eg-MieF7V=nVExvQZTFhbxteaCGQ@mail.gmail.com' \
--to=songmuchun@bytedance.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=jhubbard@nvidia.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=willy@infradead.org \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).