From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91882C4361A for ; Fri, 4 Dec 2020 03:40:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BE1CC223D6 for ; Fri, 4 Dec 2020 03:40:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE1CC223D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 989426B0036; Thu, 3 Dec 2020 22:40:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 915BD8D0001; Thu, 3 Dec 2020 22:40:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DA046B006C; Thu, 3 Dec 2020 22:40:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id 63DCB6B005C for ; Thu, 3 Dec 2020 22:40:10 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2D3A1363B for ; Fri, 4 Dec 2020 03:40:10 +0000 (UTC) X-FDA: 77554196580.05.bean95_0a0bc7c273c1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 147B9180260C1 for ; Fri, 4 Dec 2020 03:40:10 +0000 (UTC) X-HE-Tag: bean95_0a0bc7c273c1 X-Filterd-Recvd-Size: 4825 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Dec 2020 03:40:09 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id w6so2783271pfu.1 for ; Thu, 03 Dec 2020 19:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kP0kqVxYlLhlxakYbEWvE8pzB4Mj7yplj9IQfIP/Nqo=; b=RXeno4fHs2hClfvDpmt84Kb0l0ffZ+tfCf4eGR4N2xKr5d+GEweCV3ikwwgvmK8Jz8 7yRlfUm9ZgJHUw0G7xO4JpRTa6nHUnxHGOP3ecvxLWNCVn2qfP0+4sEXxg+TQ6dzvNdB 8fFJclIAPEb3EGx/lzzZi/6MYFK1BUfwM3r0BthCHtK3IOfFmB7QRDuVsNQ+2GSAaMLj Fx7lToXjBVngkeA49IgqF5XW44cP2AB3Llrt2EDOfpZX1pB/6wcSb6Q/s5a06s8rxYkP f6HLsRbClLzTOVfJPPeTaEpznXSGk9wCHNM+A1LjcwaYFE4EheH05Ug+dHysIlihP4qm fqUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kP0kqVxYlLhlxakYbEWvE8pzB4Mj7yplj9IQfIP/Nqo=; b=sGHm1ztgoPfCOoq9uuadBfTJQCn9N9z3ppJPYttphyejejiWtCvtqavsK1zw3EgLl5 6PR+RqrezcfqSj6kXsCLU6r8y318jipho2crhO7M1Q08wDpLUa0RkOguyVFLv86jqxYj cE8reZXvj9NFdl41/eK+s4gWGHJLsHevNJWMiPyaZ0+/WQ+NUr6WgirCmQC6Yd0Jmy7U 0dU/W919FknXqEE6CPx4DvWXB+2aOENB9JwJD3oBTHf2scFPFCohkxGVtcSbVcj5vWap XsMmvLXm0+Yqh2eETo7OIiOjnPUR/M6gtUFGWdGnQpd8oyK9aN/4fcLGPiLvp3X8emBp E+5A== X-Gm-Message-State: AOAM530SVoV0Zcm7XITdbOZVDrSK1zu/ALyPXwfjXgZYyEMgyTighRYo oK8A/ZldcoVihWsEQyKVFf6554DSrJqbS7hcVzHPhQ== X-Google-Smtp-Source: ABdhPJynCEO+aYzaCWwl98Gj7aTZquZAjP6gvBEF+xIuWOhnCtjsbj71ZJ7LyQ2PQpmasXLQiRg6kelKrNEq9MwhbLk= X-Received: by 2002:a63:1203:: with SMTP id h3mr2402111pgl.273.1607053207913; Thu, 03 Dec 2020 19:40:07 -0800 (PST) MIME-Version: 1.0 References: <20201130151838.11208-1-songmuchun@bytedance.com> <600fd7e2-70b4-810f-8d12-62cba80af80d@oracle.com> In-Reply-To: <600fd7e2-70b4-810f-8d12-62cba80af80d@oracle.com> From: Muchun Song Date: Fri, 4 Dec 2020 11:39:31 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v7 00/15] Free some vmemmap pages of hugetlb page To: Mike Kravetz Cc: Andrew Morton , Jonathan Corbet , dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org, bp@alien8.de, mingo@redhat.com, Thomas Gleixner , pawan.kumar.gupta@linux.intel.com, mchehab+huawei@kernel.org, paulmck@kernel.org, viro@zeniv.linux.org.uk, Peter Zijlstra , luto@kernel.org, oneukum@suse.com, jroedel@suse.de, Matthew Wilcox , David Rientjes , Mina Almasry , Randy Dunlap , anshuman.khandual@arm.com, Oscar Salvador , Michal Hocko , "Song Bao Hua (Barry Song)" , Xiongchun duan , LKML , Linux Memory Management List , linux-doc@vger.kernel.org, linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 4, 2020 at 7:49 AM Mike Kravetz wrote: > > On 12/3/20 12:35 AM, Muchun Song wrote: > > On Mon, Nov 30, 2020 at 11:19 PM Muchun Song wrote: > >> > >> Hi all, > >> > >> This patch series will free some vmemmap pages(struct page structures) > >> associated with each hugetlbpage when preallocated to save memory. > > > > Hi Mike, > > > > What's your opinion on this version? Any comments or suggestions? > > And hoping you or more people review the series. Thank you very > > much. > > Sorry Muchun, I have been busy with other things and have not looked at > this new version. Should have some time soon. Thanks very much. > > As previously mentioned, I feel qualified to review the hugetlb changes > and some other closely related changes. However, this patch set is > touching quite a few areas and I do not feel qualified to make authoritative > statements about them all. I too hope others will take a look. Agree. I also hope others can take a look at other modules(e.g. sparse-vmemmap, memory-hotplug). Thanks for everyone's efforts on this. > -- > Mike Kravetz -- Yours, Muchun