From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F48C433E7 for ; Thu, 8 Oct 2020 07:22:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F1D092087D for ; Thu, 8 Oct 2020 07:22:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kutSNlGC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1D092087D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A36C6B005C; Thu, 8 Oct 2020 03:22:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 352176B005D; Thu, 8 Oct 2020 03:22:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21ADE6B0062; Thu, 8 Oct 2020 03:22:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id E5E596B005C for ; Thu, 8 Oct 2020 03:22:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 76C6A824999B for ; Thu, 8 Oct 2020 07:22:35 +0000 (UTC) X-FDA: 77347915470.25.slope98_43014f9271d6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 587761804E3A0 for ; Thu, 8 Oct 2020 07:22:35 +0000 (UTC) X-HE-Tag: slope98_43014f9271d6 X-Filterd-Recvd-Size: 3672 Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 8 Oct 2020 07:22:34 +0000 (UTC) Received: by mail-yb1-f195.google.com with SMTP id x8so3777760ybe.12 for ; Thu, 08 Oct 2020 00:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NVt6HPCbv7NkAw3ASSdTsU1dVq2uc72ksR0NlB2xCJg=; b=kutSNlGCJ4DWn8geC2BcqllTlHrAhFdTBF/cCO7YJMeNrBGCCDWQ37FEUYopj9TwnB Kk55GYLf+Yj9o5CkMTmK37F0rRg1tiAPHFZZkNEUfrR8ap6lbtFUAWT9Fqf0mMzJhQ2p mcoBY+xr69zGzD2/Ofyr4eYlFPvQx91ROInlE6NkEymnoGnv7M/6VKak7kmfuxImRkWZ OaP+Fs2qg57HdvIjh+x1jcF7U6UsMaHNorlCGYG9UIQ8KFvF5GxWdi1vn6VD0BA/rYv3 2jPGtJWkmUNNul8SU6+fd3SGVUTjlFdNqGZjPl6b62GdxPzCqmfJyEvjnLwffL8NREs6 bDDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NVt6HPCbv7NkAw3ASSdTsU1dVq2uc72ksR0NlB2xCJg=; b=HG/z51XWQfM0X6G1sYU2J0yrSb4O2ZzEZMAkXoJNv6WyEasleagBf2Shj8K+pwPDo3 MWHS+47n4pm9dbaDJVRqy+B5avEN5eLFkqfUR76Qb9odxB43FTkkbOVtFs5lIxNH8ElU mBiNvkrZelirZz4f9aNQvzOMELIh1aqu8vIf2owLX7F6RtLMrLjzpgSkxOYDUEd4Xps8 NKchDfQqFVFbP1i4CWSqWnCcT1JjSKI5rk3pPXRzkH/6q1zj5raCev3KhbpoTk2fDF/V AvTsK5JoququovAEhKSz0HQntPXr/W6tcCc9eJsB6BEaAtbQ+D8nKxSOrM0Wlndti10N 86Vw== X-Gm-Message-State: AOAM530A1PGk6hzLBJ4wfhVhs5p4ZPiLrEr8a1K3lcBvjly/PFxpQ/GD 8NOC05di8gw3oLCYouG2BkSmqx/uDGIOoFYFZVq2gQ== X-Google-Smtp-Source: ABdhPJwpFp41/iqnZPbR9ZaIh0yqzdNQJ50wKIrTOJk31V+lLXBS8CnYFjtdxBlZoVA+/iYDktEcyuwVqP1YU3MRL04= X-Received: by 2002:a25:d4d7:: with SMTP id m206mr9441434ybf.332.1602141753828; Thu, 08 Oct 2020 00:22:33 -0700 (PDT) MIME-Version: 1.0 References: <20201007184403.1902111-1-axelrasmussen@google.com> <20201007184403.1902111-2-axelrasmussen@google.com> In-Reply-To: <20201007184403.1902111-2-axelrasmussen@google.com> From: Michel Lespinasse Date: Thu, 8 Oct 2020 00:22:21 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] tracing: support "bool" type in synthetic trace events To: Axel Rasmussen Cc: Steven Rostedt , Ingo Molnar , Andrew Morton , Vlastimil Babka , Daniel Jordan , Laurent Dufour , Jann Horn , Chinwen Chang , Yafang Shao , LKML , linux-mm Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 7, 2020 at 11:44 AM Axel Rasmussen wrote: > It's common [1] to define tracepoint fields as "bool" when they contain > a true / false value. Currently, defining a synthetic event with a > "bool" field yields EINVAL. It's possible to work around this by using > e.g. u8 (assuming sizeof(bool) is 1, and bool is unsigned; if either of > these properties don't match, you get EINVAL [2]). > > Supporting "bool" explicitly makes hooking this up easier and more > portable for userspace. Acked-by: Michel Lespinasse Looks fine to me, but you really want to get Steven's opinion over mine here :)