From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C3DC77B6F for ; Tue, 11 Apr 2023 17:09:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8B58900003; Tue, 11 Apr 2023 13:09:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3B5A900002; Tue, 11 Apr 2023 13:09:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D03FC900003; Tue, 11 Apr 2023 13:09:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BDAE4900002 for ; Tue, 11 Apr 2023 13:09:14 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 810AA805FB for ; Tue, 11 Apr 2023 17:09:14 +0000 (UTC) X-FDA: 80669745828.10.CF3F578 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf07.hostedemail.com (Postfix) with ESMTP id C0CE740004 for ; Tue, 11 Apr 2023 17:09:12 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="Dt/fnq5R"; spf=pass (imf07.hostedemail.com: domain of edumazet@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681232952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gm7xePjxYk7+XJPNyNCPc3m+W8vE886GdLa6QN77x1c=; b=y5qGaW4AoXKqfV5UYoVab9Weu5gdfZGHyRYgyCBNSlAwY6KIrYiTiBUeXtu6s9xQXulrez yT6yD9D9bCiupaMdX0QRb8uScS31663EQ1yMf4xEYhglg2Ycm8T3ithvqISJUqydCQI6wz zo9nejXVtcTBnPAVF/9Dp58vPzsFeqY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="Dt/fnq5R"; spf=pass (imf07.hostedemail.com: domain of edumazet@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681232952; a=rsa-sha256; cv=none; b=q6J/DOlfqqzXdDIQ5JxBA4rvtOmeh7DJ1Cb1q+lkFmRpIymv+Zk2PATHTGTs2ymFTnRy0i lqGecJloAYoYhIachhucgpDjwgPp2oalZEtzAbEgxMNazwbYAQ+MPaz++QMzSSruZaNNWW cgi5/NwNAIhNe01LpxSmHpF1KQnMVCE= Received: by mail-yb1-f181.google.com with SMTP id z9so8938170ybs.9 for ; Tue, 11 Apr 2023 10:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681232952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Gm7xePjxYk7+XJPNyNCPc3m+W8vE886GdLa6QN77x1c=; b=Dt/fnq5Rohg8OvlruMfiPphHzl880reg7mPfS4YNa5TmiKezMqJU7c5N642pzetXf2 6NbxlvK5ktk5iVQVml81CM9HQp85vFnzaieIFuuBqYSPu6WYL5u9tdlk4I6vgkBMqUvC w6wRpn8CV3RHhSbKqat6mlHmMYEYrkecxwv76tB8yR+Z9cCcwUm2we4/xm2upTtQATqH K4dsin1oFx+mWY14ixXb3oYb59cL4azDcD+rWQMZleC8KPvs8F+48Wq+ejwmTxLhkXPf IQbCu9aPtXBDaBDRLeDoRMpbwBZMZsK7uZVTPVozcyVwBpKD7OpdbHbV6DcndD7Ixvtu 1lzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681232952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gm7xePjxYk7+XJPNyNCPc3m+W8vE886GdLa6QN77x1c=; b=DyIpca82Q0IJDj9Al1/QQfJk9j34ZyZ4aibHNoziccoG2i4qSt4ooi05FkHq+c29Zl JWmrncFUcjrJZGtuHxnRpLbmSkC0oR40N1DDGIy6LGmaFQK9f3Gx9ltIJ3CdKyqdXMeb seLkhV9IrAo/5m0pv/p+ppcZ7abezaMKlPj9r1oB6Rdr1IfWKFpFZg9/GQZwtdMoN8Fx jEXaUz90zDvaJvMwcFHxOWAqeortcaW9VTHgaky1YRucX3/uCiN9qTr7QCxPMKYLpdHM 9WeRbuq8b/CVy0oRFfw8BWD5PBIGrYj7BXkvcvhgJnOo/JV366+stFs1sp/p8yidNSZu ma0Q== X-Gm-Message-State: AAQBX9cb7fBzh2nphh81RqsXhZctnW4lNfFfcyhZWazNogRxeP+LhnxG vc/BPz2NI6tnqRkGofgSN5JgQt/sr5JQNchVJKGIdA== X-Google-Smtp-Source: AKy350b8jaqgaAHh8wLrh+Z1EDrMUNUXWA3JcWdiVtFGHsb3jqA9X9Y6psDGOt8LUL6EO2xtyY+DLjKwwfub7Ud1Mfs= X-Received: by 2002:a25:7347:0:b0:b8f:892:3967 with SMTP id o68-20020a257347000000b00b8f08923967mr2861731ybc.4.1681232951657; Tue, 11 Apr 2023 10:09:11 -0700 (PDT) MIME-Version: 1.0 References: <20230411160902.4134381-1-dhowells@redhat.com> <20230411160902.4134381-8-dhowells@redhat.com> In-Reply-To: <20230411160902.4134381-8-dhowells@redhat.com> From: Eric Dumazet Date: Tue, 11 Apr 2023 19:09:00 +0200 Message-ID: Subject: Re: [PATCH net-next v6 07/18] tcp: Support MSG_SPLICE_PAGES To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: mmf9rrqg58jbup8xrk5adpngg1yis331 X-Rspamd-Queue-Id: C0CE740004 X-HE-Tag: 1681232952-906018 X-HE-Meta: U2FsdGVkX1/6aCSDDEYPmLUtETkTUsx7Rl8eEmcl2LSqpMQbIJ8LlPE+6qHhFJjUdVp+8j+XSY6Z1uZfkqDyXPqHubCLMgoZrVI0fIgKxZbl7sOUXjR472oBG6soxbNzkNN9rdqrO53+F0KvU8ErSVpxh1PsydCWRtm2tCZ+0ERBZ77zR4GVDe4zMIU0BBbUrx2VmUyfVLUpeAUBOoMYIV3cZnZy4AHmWEErQq9XYHkfKyHSkmpAjMPhjNQnDDaMQlFlS++emMTtr8mRtKoj366pcMRMRTKiuMEqjWj+Z8l+8TjoV8xuMiAafudl6JVZlZAlcuwNmV9HocC5DBdOYT8m5wTHJJ9Qj0wBoT1glXyrEFnil29DlYZjvKwU9lCq78+kkeKndk7eJDI0Mwv4RZ8rxGZC8uMSpYmp19XRn4w8pcjkN7hhMUfp8G6E4b5GFffEt5Z/QyJKrfkjD1izv9nKOmwFiweWrka9tzDT6pLW9EYUoySSy6ePWIhV6PWFCYCa0yTfb0g+S51hzWtpf5QOVOPWnYyb0KQtz+Blgebt4K9EEwGhx9dbbnx63hAQWkBCgLbAVCk1JSLvas6XUqOPmHMGqPgBJldpuOVNv6BfjbxJnKPEw/3UZxUCY1gt8jnwuR0dh/UOSe3Iz2H4M2KXjrwnAK6byJP8YnCBNx4wTsBkRkVxGobLv0XzLPZiD65tRufQMQ+RUo/1BJs0D4JDhfBpt+G+r8tu4eIL9O5B3FftYXPfjbZuCeUoRNCLVWiz5+PjV6AZYxRbGcjauCfMqbPdM60SRVAhX9s6QZwqts1awSHjHAFCmKXFMZX6PLr/O4MCJHPC2U/R12adKIYDuR+hJQhBLNJ1/JYV/j+BZIT/NBZI0+vscvKK/NTOymuv01Uk5PszqqxcIRRyTasjqszDgr14IqTwMEXnkk7dfzksfxL4I7yRjmORf4CU0UlWAA5sNoUVTiu74NM 5tP3F9UX zsgCALLJuuKA1TAI2JOSabLYvn6C7Wmi99UaDi7Q7rKGfTWIp3xtu3C87emSKbdajvuv+IzqNkkGvfPj4ALB2AxX9jfcVLs0JdZoOGkd5LfhU0UX40OZ/Qaw+CpKkUry7Cu/zyv5NIX6h+BSsHHlOW/bGR0TL9xDJ4YO0X05rNrLccSFJLGYHGKUCF3Z58evFWRR+kRxOwADS9zujyBx/vVlBqUtqH2/XnZjdWOvs0p7XsbK8258nRoQYSP3Pr9hp9C8V1m7gb89+B2cwW18HjtHgz6l6YXzQnOFdG4gOZdH0YxvQIKyFiXbKfJnwYAOiArFo8ilZMj8bCneq6qSh7MaIIFhCNaJS0mjGNqfzOwTXIPs9rV5gHMWQzzx1qFvPRypQUN0v6nJbstkjNgBJPRFqrCtxu7kiibwikj1ePAWooEqfqLTtbo32qKALrOc+LeWFLvLQqmqtGaiy8TIYAASPZvV1HoJMSATRJCeBUdQNnBDGETY8mGFnJCjdfvhwtV3ypAT1R/dTlwPXTAhwXDne3GU/caA4XmrBgSgQGWji7noYFVYdYgRdBBm0mr/6FGQc5ofqTgL0ZPBf8drXDCX/Ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 11, 2023 at 6:09=E2=80=AFPM David Howells = wrote: > > Make TCP's sendmsg() support MSG_SPLICE_PAGES. This causes pages to be > spliced or copied (if it cannot be spliced) from the source iterator. > > This allows ->sendpage() to be replaced by something that can handle > multiple multipage folios in a single transaction. > > Signed-off-by: David Howells > cc: Eric Dumazet > cc: "David S. Miller" > cc: David Ahern > cc: Jakub Kicinski > cc: Paolo Abeni > cc: Jens Axboe > cc: Matthew Wilcox > cc: netdev@vger.kernel.org > --- > > Notes: > ver #6) > - Use common helper. > > net/ipv4/tcp.c | 43 ++++++++++++++++++++++++++++++++++++------- > 1 file changed, 36 insertions(+), 7 deletions(-) > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index fd68d49490f2..0b2213da5aaf 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -1221,7 +1221,7 @@ int tcp_sendmsg_locked(struct sock *sk, struct msgh= dr *msg, size_t size) > int flags, err, copied =3D 0; > int mss_now =3D 0, size_goal, copied_syn =3D 0; > int process_backlog =3D 0; > - bool zc =3D false; > + int zc =3D 0; > long timeo; > > flags =3D msg->msg_flags; > @@ -1232,17 +1232,22 @@ int tcp_sendmsg_locked(struct sock *sk, struct ms= ghdr *msg, size_t size) > if (msg->msg_ubuf) { > uarg =3D msg->msg_ubuf; > net_zcopy_get(uarg); > - zc =3D sk->sk_route_caps & NETIF_F_SG; > + if (sk->sk_route_caps & NETIF_F_SG) > + zc =3D 1; zc is set to 0, 1, MSG_ZEROCOPY , MSG_SPLICE_PAGES I find this a bit confusing. Maybe use a private enum ? > } else if (sock_flag(sk, SOCK_ZEROCOPY)) { > uarg =3D msg_zerocopy_realloc(sk, size, skb_zcopy= (skb)); > if (!uarg) { > err =3D -ENOBUFS; > goto out_err; > } > - zc =3D sk->sk_route_caps & NETIF_F_SG; > - if (!zc) > + if (sk->sk_route_caps & NETIF_F_SG) > + zc =3D MSG_ZEROCOPY; > + else > uarg_to_msgzc(uarg)->zerocopy =3D 0; > } > + } else if (unlikely(msg->msg_flags & MSG_SPLICE_PAGES) && size) { > + if (sk->sk_route_caps & NETIF_F_SG) > + zc =3D MSG_SPLICE_PAGES;