From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29947C432C3 for ; Tue, 3 Dec 2019 12:51:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D1B3620684 for ; Tue, 3 Dec 2019 12:51:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="in9LJdS3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1B3620684 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5D6B26B0502; Tue, 3 Dec 2019 07:51:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 584BD6B0503; Tue, 3 Dec 2019 07:51:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 473AA6B0504; Tue, 3 Dec 2019 07:51:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 2F4976B0502 for ; Tue, 3 Dec 2019 07:51:12 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id E068C181AEF21 for ; Tue, 3 Dec 2019 12:51:11 +0000 (UTC) X-FDA: 76223815542.21.ant14_448f462eaaf4a X-HE-Tag: ant14_448f462eaaf4a X-Filterd-Recvd-Size: 6019 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Dec 2019 12:51:10 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id r27so2750607otc.8 for ; Tue, 03 Dec 2019 04:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=grUjX2oQj+x45DwjswUrp2guuqFlROa1YhQ3JsunnnU=; b=in9LJdS3BZijHqC7CN4xgXYDVwQO6OP137tNagDUPAGVb7TP8fLPI6rqIIAHOFEI9i nROXLS6DuXsQuH1IvufEYR6skJzcSOU5sPWGr4wZTWJe6DI2J83bit+vxnqO4lOjTiJT eJ7MWm0ovQQ10SwY82pBdsVXZgnNHgKQhsLPVVBRd4tsn/Ac6lsWNjvdpTEbX7FAsLOi z5VAr1584XidVXFYNGCyQxUomhBjb2/+1glvYWj3T7EFYl7GmYsTjyx/P6SwUQLeVanV Y4lFK1pc4wkMqkHBQazGjeemmlDx8Z+SKgn0KBMt1HfThTlng8IZ8AFwf2iOzFwa5Qto 5kIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=grUjX2oQj+x45DwjswUrp2guuqFlROa1YhQ3JsunnnU=; b=uTm/hBzkf+WQOiUZt6N23KmacPQSjlYQdqXZmXiUoQ219kGcN/ggBPQatEV6dWQyBb /0qjSX+HSKzwnsQ+gnsrWefzFUsv5gyIAPe8ZoNNZ3ewjM4X/u8NQqzzepIpReObfov0 PQ/nt1NMZ6LylgaaT3B21vmptDLuop2I/vl2JE+4nwvMQ8UIsIweF0jCYsfbyFYXLYnE gDsbJgE8MQl84PxqBF1Oj25w9tUFdUWXvGxYEj+t9NUoWH9U2b0sX4jpW93+9F1hzkvd vFHr1Cdmw6mNh8JrQx6WpKCc8JLgcISxIfynxUikm7S4RsLJNXZ1pZl+H+3T4zstRwXb +hmw== X-Gm-Message-State: APjAAAXn+zLvOCYGTAUHH9ii60steH+wwbwNnUJuOf3sYA2pwqIZEAMj qMdwuyZfWMm8iGbYdvkt5d0pyUZSxBp9r3CMqBypnQ== X-Google-Smtp-Source: APXvYqyq2D1ZeZINZOEjVhEqvuJxGZ+phyYaE84Ckl2FDNpJFk+S85OAqTnerfNDl0353YtcrGsuJnG9xvUgADYjJK8= X-Received: by 2002:a9d:7f12:: with SMTP id j18mr3121013otq.17.1575377469896; Tue, 03 Dec 2019 04:51:09 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-33-glider@google.com> In-Reply-To: <20191122112621.204798-33-glider@google.com> From: Marco Elver Date: Tue, 3 Dec 2019 13:50:58 +0100 Message-ID: Subject: Re: [PATCH RFC v3 32/36] kmsan: add iomap support To: Alexander Potapenko Cc: Christoph Hellwig , "Darrick J. Wong" , Vegard Nossum , Dmitry Vyukov , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Nov 2019 at 12:28, wrote: > > Functions from lib/iomap.c interact with hardware, so KMSAN must ensure > that: > - every read function returns an initialized value > - every write function checks values before sending them to hardware. > > Signed-off-by: Alexander Potapenko > Cc: Christoph Hellwig > Cc: Darrick J. Wong > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: linux-mm@kvack.org > --- > > Change-Id: Iacd96265e56398d8c111637ddad3cad727e48c8d > --- > lib/iomap.c | 40 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/lib/iomap.c b/lib/iomap.c > index e909ab71e995..3ef20b8138e2 100644 > --- a/lib/iomap.c > +++ b/lib/iomap.c > @@ -6,6 +6,7 @@ [...] > void iowrite8_rep(void __iomem *addr, const void *src, unsigned long count) > { > + /* Make sure uninitialized memory isn't copied to devices. */ > + kmsan_check_memory(src, count); > IO_COND(addr, outsb(port, src, count), mmio_outsb(addr, src, count)); > } > void iowrite16_rep(void __iomem *addr, const void *src, unsigned long count) > { > + /* Make sure uninitialized memory isn't copied to devices. */ > + kmsan_check_memory(src, count); Should this be 'count * 2' ? > IO_COND(addr, outsw(port, src, count), mmio_outsw(addr, src, count)); > } > void iowrite32_rep(void __iomem *addr, const void *src, unsigned long count) > { > + /* Make sure uninitialized memory isn't copied to devices. */ > + kmsan_check_memory(src, count); Should this be 'count * 4' ? Thanks, -- Marco