From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AEEBC432C0 for ; Mon, 2 Dec 2019 13:33:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F21BA2084F for ; Mon, 2 Dec 2019 13:33:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aaMQ9ybi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F21BA2084F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 900E26B0007; Mon, 2 Dec 2019 08:33:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88A276B0008; Mon, 2 Dec 2019 08:33:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7529D6B000A; Mon, 2 Dec 2019 08:33:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 5C1576B0007 for ; Mon, 2 Dec 2019 08:33:54 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 05FE145A6 for ; Mon, 2 Dec 2019 13:33:54 +0000 (UTC) X-FDA: 76220294388.29.sun00_5c31280223901 X-HE-Tag: sun00_5c31280223901 X-Filterd-Recvd-Size: 6528 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Dec 2019 13:33:53 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id r27so16530162otc.8 for ; Mon, 02 Dec 2019 05:33:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qLg7Fa8CfHQcpEgSHvh8yPgZJv/6HozFYavN+PRhOMo=; b=aaMQ9ybijy+Ai0wE0LP2Aht5QAVzv/XdLhJ6o1QMFAPUusVal9MBA+bZCR8r8Lr1Xu Ohp5wef6COF2So8schJXxTX4e1Q45HL8PLSLlaSUTmZV4oBeIlCpdlu00YVv7OcQz/83 YVwv83Y+7sZONQnlxEtZCjVu2U0dfro3Wcjuqf+Tt8LSbhOmeP7P8AMwH/ajZPlzQ4hR w4Neg0IcHYD4JV8JliQxnNUvg+WanMV2N7nVGZZmVf4AWIRhSxyZY/Rt3pOaxhH0KCsH 8hY4xufCw8nWpKyK7nni78A7w/5wrEP+iHod4uZJTY1To4wxr+0Nz1W5id78Bqr+6sqC FqSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qLg7Fa8CfHQcpEgSHvh8yPgZJv/6HozFYavN+PRhOMo=; b=Prean2dWxbd1ESEFhc4g45aRXEIYBQXIzXWRUijmSx/l8kg3ftqsYpGRCXcZuj03+D cnkHMFUQIiduVG4QBjGyyRSJNDU7E8Gv+XUcKlCGzcQE0S1UZmJjTTZW4PKzwLuZ3mL2 VHHK9ffofdXhw9TVODTYeHhDgG2ZMpRJ4qvZZ5SjbZLLyd7Oq+aqUV72crADVzioQGlZ eZ/XU7txk9GKw4oeRwP5YL+FZKMjfIkT0dYAEfRTgZlsctU1qb6y68KT27xkpWsa8YR+ 3vKfp13yobt55vm4aKiAp0hIMSYMtyWnRhdnzL+7kuOfujKnZQHNTOr2H5DAEyBaOYdS Zhcw== X-Gm-Message-State: APjAAAXkBM8rtIJdJH5aTNP4OvloakgPlR+2+/PWH86zYen4MUz0x3s+ RSELlVoJ/TsoWDtMxgWEH1F1ECAMih8Cnr2llI+7hw== X-Google-Smtp-Source: APXvYqzQ04y71D0cnZq5ABFbjQZ20Y5PJQaN9uaZGIKFnwT3jTKfAsGrKqRyMI9QY9fYHkTCiEQ+bqixoOus0ph+PkU= X-Received: by 2002:a9d:7410:: with SMTP id n16mr7102483otk.23.1575293632234; Mon, 02 Dec 2019 05:33:52 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-19-glider@google.com> In-Reply-To: <20191122112621.204798-19-glider@google.com> From: Marco Elver Date: Mon, 2 Dec 2019 14:33:40 +0100 Message-ID: Subject: Re: [PATCH RFC v3 18/36] kmsan: disable LOCK_DEBUGGING_SUPPORT To: Alexander Potapenko Cc: Eric Biggers , Qian Cai , Christoph Hellwig , Herbert Xu , Harry Wentland , Vegard Nossum , Dmitry Vyukov , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Nov 2019 at 12:27, wrote: > > KMSAN doesn't currently support lock debugging, causing the kernel to > enter infinite recursion at boot time. > See https://github.com/google/kmsan/issues/57. > > Signed-off-by: Alexander Potapenko > Cc: Eric Biggers > Cc: Qian Cai > Cc: Christoph Hellwig > Cc: Herbert Xu > Cc: Harry Wentland > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: linux-mm@kvack.org > > --- > This patch is part of "kmsan: Kconfig changes to disable options > incompatible with KMSAN", which was split into smaller pieces. > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 75c36318943d..a3f6f5d68593 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1068,6 +1068,9 @@ menu "Lock Debugging (spinlocks, mutexes, etc...)" > config LOCK_DEBUGGING_SUPPORT > bool > depends on TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT > + # KMSAN is incompatible with lockdep, > + # see https://github.com/google/kmsan/issues/57. > + depends on !KMSAN > default y > > config PROVE_LOCKING > > Change-Id: I4f97edc8a02d8ca208fc914e55e8f0c23d74eac8 > --- > lib/Kconfig.debug | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 75c36318943d..a3f6f5d68593 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1068,6 +1068,9 @@ menu "Lock Debugging (spinlocks, mutexes, etc...)" > config LOCK_DEBUGGING_SUPPORT > bool > depends on TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT > + # KMSAN is incompatible with lockdep, > + # see https://github.com/google/kmsan/issues/57. Does it make sense to get this working? Or rather, is it feasible to get working? If not, I would just remove the reference to the Github issue, and declare that KMSAN is incompatible with lockdep. > + depends on !KMSAN > default y > > config PROVE_LOCKING > -- > 2.24.0.432.g9d3f5f5b63-goog >