From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22222C10DCE for ; Tue, 24 Mar 2020 23:51:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD52720719 for ; Tue, 24 Mar 2020 23:51:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="jgx9CVgZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD52720719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C9E16B0005; Tue, 24 Mar 2020 19:51:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57B546B0006; Tue, 24 Mar 2020 19:51:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 490E76B0007; Tue, 24 Mar 2020 19:51:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 2F8256B0005 for ; Tue, 24 Mar 2020 19:51:42 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D57C8180AE1B5 for ; Tue, 24 Mar 2020 23:51:41 +0000 (UTC) X-FDA: 76631905602.05.head12_8330e94169561 X-HE-Tag: head12_8330e94169561 X-Filterd-Recvd-Size: 5376 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Mar 2020 23:51:41 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id w13so445205oih.4 for ; Tue, 24 Mar 2020 16:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KsuHRbkrRa7b9vqtRFx6ZxGV0C6hEgdYMQeOpNoVJ0E=; b=jgx9CVgZcBzRzaEGKFLv/1JOTUMrhNkGkLTdNTBN5CFC7PlSIeE0hcCdBrTvaw578G 8YxLzN0nM6iNf3wKE7zw8apBgYHyE5jU7LNswbWwXwWHfUTQJO9vm1PFErePmhUQPlBP Vt6nqyYE7EcDffVVOCJ4DFUufko+Zog9ruk7Gg0dJk5SQBgWGC7BBV5pr1mRIq5755yO YVHd++wVXkAmTw/lET38pgHh8M72HZAwVGgO4Du+2ufb81Jltpo4VrKzt0/QsPNJMRgr 2Tq6BGao3x7tbcGZIExPuDBLWO3boKoqOsO8A/UijwTYnjICttMS266PGrxtNmAjMR3G rsaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KsuHRbkrRa7b9vqtRFx6ZxGV0C6hEgdYMQeOpNoVJ0E=; b=qQ1AHT8q/WkPY0sU5+5+C1PpV3UHifOA/R9mDgaxoZlf/gigsAEBg9JTXWBVoElYr3 yWAN6bsq5lizFy0kXApsRBRTrTfSU6WrtPNLpJxOLON5IbpjCeGhI+GETutAgcrIEnsz CKP1YynjBlE5pg3GJd23VUEVrBXMSlL9d8i/qVfijc2XxfMvyNXpCn762D7gSB8yN72w zqG+4ASbKAB5e8pJGLuxNGRvA6X98kfmH0aOYaBuzwdR0CiWlJDciEcDdH8sFiJ/o1iK f6JYlI9XG4QCLgaVjppPnF+QAPUOcqdBdSW/ymKobxmsS0DtXem6wAxzBawEszRh2kyK G0YA== X-Gm-Message-State: ANhLgQ0DvuXj2a7/4rO6OAbgeYyymR6433X9JG1a6YC8awed0DV241nD eZLCUUVNVhNA+d5OtzCfMLr/po5OrDMmLakP8fhxEw== X-Google-Smtp-Source: ADFU+vvEot3loXp3xfdzaa8/BtiMFgInDf2505MhIro1JIu7WSMtVgkejuDT5W3XzYDu/BNtqWzlHCFs5LvpT08hY6c= X-Received: by 2002:aca:ef82:: with SMTP id n124mr562802oih.73.1585093900545; Tue, 24 Mar 2020 16:51:40 -0700 (PDT) MIME-Version: 1.0 References: <158500767138.2088294.17131646259803932461.stgit@dwillia2-desk3.amr.corp.intel.com> <158500774067.2088294.1260962550701501447.stgit@dwillia2-desk3.amr.corp.intel.com> <27ba42ac-ec08-fd9c-dee2-53414eb0bc58@oracle.com> In-Reply-To: <27ba42ac-ec08-fd9c-dee2-53414eb0bc58@oracle.com> From: Dan Williams Date: Tue, 24 Mar 2020 16:51:29 -0700 Message-ID: Subject: Re: [PATCH 12/12] device-dax: Introduce 'mapping' devices To: Joao Martins Cc: Linux MM , Dave Hansen , Christoph Hellwig , linux-nvdimm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 24, 2020 at 9:28 AM Joao Martins wrote: > > On 3/23/20 11:55 PM, Dan Williams wrote: > > In support of interrogating the physical address layout of a device with > > dis-contiguous ranges, introduce a sysfs directory with 'start', 'end', > > and 'page_offset' attributes. The alternative is trying to parse > > /proc/iomem, and that file will not reflect the extent layout until the > > device is enabled. > > > > Signed-off-by: Dan Williams > > --- > > drivers/dax/bus.c | 190 +++++++++++++++++++++++++++++++++++++++++++++ > > drivers/dax/dax-private.h | 14 +++ > > 2 files changed, 202 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > > index 07aeb8fa9ee8..645449a079bd 100644 > > --- a/drivers/dax/bus.c > > +++ b/drivers/dax/bus.c > > @@ -558,6 +558,167 @@ struct dax_region *alloc_dax_region(struct device *parent, int region_id, > > } > > EXPORT_SYMBOL_GPL(alloc_dax_region); > > > > +static void dax_mapping_release(struct device *dev) > > +{ > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + > > + ida_free(&dev_dax->ida, mapping->id); > > + kfree(mapping); > > +} > > + > > +static void unregister_dax_mapping(void *data) > > +{ > > + struct device *dev = data; > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + struct dax_region *dax_region = dev_dax->region; > > + > > + dev_dbg(dev, "%s\n", __func__); > > + > > + device_lock_assert(dax_region->dev); > > + > > + dev_dax->ranges[mapping->range_id].mapping = NULL; > > + mapping->range_id = -1; > > + > > + device_del(dev); > > + put_device(dev); > > +} > > + > > +static struct dev_dax_range *get_dax_range(struct device *dev) > > +{ > > + struct dax_mapping *mapping = to_dax_mapping(dev); > > + struct dev_dax *dev_dax = to_dev_dax(dev->parent); > > + struct dax_region *dax_region = dev_dax->region; > > + > > + device_lock(dax_region->dev); > > + if (mapping->range_id < 1) { > ^^^^^^^^^^^^^^^^^^^^^ perhaps "mapping->range_id < 0" ? > > AFAICT, invalid/disabled ranges have id to -1. > > Otherwise we can't use mapping0 entry fields. > Yes, a gaping hole in the unit test.