From: Catalin Marinas <catalin.marinas@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Yang Shi <yang.shi@linux.alibaba.com>,
"dvyukov@google.com" <dvyukov@google.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case
Date: Mon, 15 Jul 2019 10:01:00 -0500 [thread overview]
Message-ID: <F89E7123-C21C-41AA-8084-1DB4C832D7BD@gmail.com> (raw)
In-Reply-To: <20190715131732.GX29483@dhcp22.suse.cz>
On 15 Jul 2019, at 08:17, Michal Hocko <mhocko@kernel.org> wrote:
> On Sat 13-07-19 04:49:04, Yang Shi wrote:
>> When running ltp's oom test with kmemleak enabled, the below warning was
>> triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is
>> passed in:
>
> kmemleak is broken and this is a long term issue. I thought that
> Catalin had something to address this.
What needs to be done in the short term is revert commit d9570ee3bd1d4f20ce63485f5ef05663866fe6c0. Longer term the solution is to embed kmemleak metadata into the slab so that we don’t have the situation where the primary slab allocation success but the kmemleak metadata fails.
I’m on holiday for one more week with just a phone to reply from but feel free to revert the above commit. I’ll follow up with a better solution.
Catalin
next prev parent reply other threads:[~2019-07-15 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 20:49 [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case Yang Shi
2019-07-13 19:39 ` David Rientjes
2019-07-15 3:43 ` Yang Shi
2019-07-15 13:18 ` Michal Hocko
2019-07-13 21:25 ` Matthew Wilcox
2019-07-15 3:47 ` Yang Shi
2019-07-15 13:06 ` Matthew Wilcox
2019-07-15 17:00 ` Yang Shi
2019-07-15 13:17 ` Michal Hocko
2019-07-15 15:01 ` Catalin Marinas [this message]
2019-07-15 15:18 ` Qian Cai
2019-07-15 16:58 ` Yang Shi
2019-07-16 17:38 ` Yang Shi
2019-07-25 2:48 ` Andrew Morton
2019-07-25 17:21 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F89E7123-C21C-41AA-8084-1DB4C832D7BD@gmail.com \
--to=catalin.marinas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).