From: Greg KH <greg@kroah.com>
To: sj38.park@gmail.com
Cc: akpm@linux-foundation.org, SeongJae Park <sjpark@amazon.de>,
Jonathan.Cameron@huawei.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, amit@kernel.org,
benh@kernel.crashing.org, brendanhiggins@google.com,
corbet@lwn.net, david@redhat.com, dwmw@amazon.com,
elver@google.com, fan.du@intel.com, foersleo@amazon.de,
gthelen@google.com, guoju.fgj@alibaba-inc.com, mgorman@suse.de,
minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org,
peterz@infradead.org, riel@surriel.com, rientjes@google.com,
rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com,
shuah@kernel.org, snu@amazon.de, vbabka@suse.cz,
vdavydov.dev@gmail.com, zgf574564920@gmail.com,
linux-damon@amazon.com, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v26 07/13] mm/damon: Implement a debugfs-based user space interface
Date: Tue, 30 Mar 2021 11:22:45 +0200 [thread overview]
Message-ID: <YGLt5R1AlgGrPtv4@kroah.com> (raw)
In-Reply-To: <20210330090537.12143-8-sj38.park@gmail.com>
On Tue, Mar 30, 2021 at 09:05:31AM +0000, sj38.park@gmail.com wrote:
> +static int __init __damon_dbgfs_init(void)
> +{
> + struct dentry *dbgfs_root;
> + const char * const file_names[] = {"monitor_on"};
> + const struct file_operations *fops[] = {&monitor_on_fops};
> + int i;
> +
> + dbgfs_root = debugfs_create_dir("damon", NULL);
> +
> + for (i = 0; i < ARRAY_SIZE(file_names); i++)
> + debugfs_create_file(file_names[i], 0600, dbgfs_root, NULL,
> + fops[i]);
> + dbgfs_fill_ctx_dir(dbgfs_root, dbgfs_ctxs[0]);
> +
> + dbgfs_dirs = kmalloc_array(1, sizeof(dbgfs_root), GFP_KERNEL);
No error checking for memory allocation failures?
> + dbgfs_dirs[0] = dbgfs_root;
> +
> + return 0;
> +}
> +
> +/*
> + * Functions for the initialization
> + */
> +
> +static int __init damon_dbgfs_init(void)
> +{
> + int rc;
> +
> + dbgfs_ctxs = kmalloc(sizeof(*dbgfs_ctxs), GFP_KERNEL);
No error checking?
> + dbgfs_ctxs[0] = dbgfs_new_ctx();
> + if (!dbgfs_ctxs[0])
> + return -ENOMEM;
> + dbgfs_nr_ctxs = 1;
> +
> + rc = __damon_dbgfs_init();
> + if (rc)
> + pr_err("%s: dbgfs init failed\n", __func__);
Shouldn't the error be printed out in the function that failed, not in
this one?
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-30 9:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 9:05 [PATCH v26 00/13] Introduce Data Access MONitor (DAMON) sj38.park
2021-03-30 9:05 ` [PATCH v26 01/13] mm: " sj38.park
2021-03-30 9:05 ` [PATCH v26 02/13] mm/damon/core: Implement region-based sampling sj38.park
2021-03-30 9:05 ` [PATCH v26 03/13] mm/damon: Adaptively adjust regions sj38.park
2021-03-30 9:05 ` [PATCH v26 04/13] mm/idle_page_tracking: Make PG_idle reusable sj38.park
2021-03-30 9:05 ` [PATCH v26 05/13] mm/damon: Implement primitives for the virtual memory address spaces sj38.park
2021-03-30 9:05 ` [PATCH v26 06/13] mm/damon: Add a tracepoint sj38.park
2021-03-30 9:05 ` [PATCH v26 07/13] mm/damon: Implement a debugfs-based user space interface sj38.park
2021-03-30 9:22 ` Greg KH [this message]
2021-03-30 9:59 ` SeongJae Park
2021-03-30 10:20 ` SeongJae Park
2021-03-30 9:05 ` [PATCH v26 08/13] mm/damon/dbgfs: Export kdamond pid to the user space sj38.park
2021-03-30 9:05 ` [PATCH v26 09/13] mm/damon/dbgfs: Support multiple contexts sj38.park
2021-03-30 9:05 ` [PATCH v26 10/13] Documentation: Add documents for DAMON sj38.park
2021-03-30 9:05 ` [PATCH v26 11/13] mm/damon: Add kunit tests sj38.park
2021-03-30 9:05 ` [PATCH v26 12/13] mm/damon: Add user space selftests sj38.park
2021-03-30 9:05 ` [PATCH v26 13/13] MAINTAINERS: Update for DAMON sj38.park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGLt5R1AlgGrPtv4@kroah.com \
--to=greg@kroah.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=elver@google.com \
--cc=fan.du@intel.com \
--cc=foersleo@amazon.de \
--cc=gthelen@google.com \
--cc=guoju.fgj@alibaba-inc.com \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=snu@amazon.de \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=zgf574564920@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).