From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EAC4C49EA6 for ; Thu, 24 Jun 2021 20:06:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E2CC613B3 for ; Thu, 24 Jun 2021 20:06:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E2CC613B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C9DA66B0011; Thu, 24 Jun 2021 16:06:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4D756B005D; Thu, 24 Jun 2021 16:06:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3DC76B006C; Thu, 24 Jun 2021 16:06:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 80B176B0011 for ; Thu, 24 Jun 2021 16:06:29 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A39F9180BD76B for ; Thu, 24 Jun 2021 20:06:29 +0000 (UTC) X-FDA: 78289699698.15.FFF85C0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 06557200107C for ; Thu, 24 Jun 2021 20:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BtxiXggwDvXrNGHd7tGUED0H/U9R7sx5bv0cWhEUZYE=; b=pbnNFprtOq0QMj47KdtCAC9lKn /zBFzHucRFeOVpNk+IAd/cqbp4zn6o2COCdzyHY/PDn5Bo093uI1jLcRK1bpOvonT4Id4faOJQ+BJ M9to8iJn9suJiSucVoX+q+vnccTGbMdOBmN0bBHl8oQ7m4aSuArwUOOG7t3N2PVdULLNq8oihFgT+ s1ngJ/P7X+K7J8UanYE477NLmL6ki1qUdKmujR5HIPYjdFs4234FKD2qK2rVx+0/fCbyDIAh/zrx6 YJCSvhT7tcBTUqbI4bEWez91gOfYC6KkztuHGExWrLws2uBhaZZrAKSc5kHHk5WQJSs8BDtU9v8Y0 E5VC+6AA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwVbw-00Gwt1-94; Thu, 24 Jun 2021 20:06:07 +0000 Date: Thu, 24 Jun 2021 21:06:04 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 29/46] mm/writeback: Add folio_account_cleaned() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-30-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pbnNFprt; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: r6syfqnuwfq9mufmeux8yje9xn8zm97a X-Rspamd-Queue-Id: 06557200107C X-Rspamd-Server: rspam06 X-HE-Tag: 1624565188-37225 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 23, 2021 at 11:36:14AM +0200, Christoph Hellwig wrote: > On Tue, Jun 22, 2021 at 01:15:34PM +0100, Matthew Wilcox (Oracle) wrote: > > Get the statistics right; compound pages were being accounted as a > > single page. > > Maybe reword this a little to document the existing function that got > it wrong, and why it did not matter before. Get the statistics right; compound pages were being accounted as a single page. This didn't matter before now as no filesystem which supported compound pages did writeback. Also move the declaration to filemap.h since this is part of the page cache. Add a wrapper for account_page_cleaned().