From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E586C49EA5 for ; Thu, 24 Jun 2021 23:50:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 54E88613AD for ; Thu, 24 Jun 2021 23:50:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54E88613AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 59B546B0036; Thu, 24 Jun 2021 19:50:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 571E56B005D; Thu, 24 Jun 2021 19:50:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4114F6B006C; Thu, 24 Jun 2021 19:50:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 0D1926B0036 for ; Thu, 24 Jun 2021 19:50:51 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3805E1C9AD for ; Thu, 24 Jun 2021 23:50:52 +0000 (UTC) X-FDA: 78290265144.30.ED8FF8B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 150282001095 for ; Thu, 24 Jun 2021 23:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QrDKKmi2jhhfzOeBzeGjVF68+wOp3Rw/4GYCckMy6O0=; b=EfowUAHjP6rvRkIOaO+mR4InfD GejD3d/O+OyWxQPJMl2kq/YpZoKjLm1p0OBREnlf3p1ZTuYTey5653em5WZyoO5nTe3Z8s4j1C6A0 IHyyxgR29GT5bL2/6o5mNB0RLlpOyjLgE4erh834BsEOLXfWNsMwCyVnSsaVS5ru+ndWnFkNNcJL0 iOPa5zzpnqhvMsXS40UQ443a0enMggojGVMuhJ+aX5wsnkcYATa0Rmu3DXlNAxeo181LjD3ASdSeH nDnFvpDocBIBgzRJdBpZcR/GSRLcZt9Kb/zKd6uyo1oPfBuZORVpY7DsJzT2q8qzlgwIRw/wwaGDv QsZS3h9g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwZ70-00H7b7-Td; Thu, 24 Jun 2021 23:50:27 +0000 Date: Fri, 25 Jun 2021 00:50:22 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 38/46] mm: Add folio_evictable() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-39-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 150282001095 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EfowUAHj; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: k4uzdjbrhaerxb8s3zyzuqjun5meug3h X-HE-Tag: 1624578650-118318 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 23, 2021 at 11:54:06AM +0200, Christoph Hellwig wrote: > > + * Reasons folio might not be evictable: > > + * 1. page's mapping marked unevictable > > + * 2. page is part of an mlocked VMA > > s/page/folio/? Thanks. * Reasons folio might not be evictable: * 1. folio's mapping marked unevictable * 2. One of the pages in the folio is part of an mlocked VMA > Otherwise looks good: > > Reviewed-by: Christoph Hellwig