From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98737C433EF for ; Mon, 13 Sep 2021 20:10:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 331F360273 for ; Mon, 13 Sep 2021 20:10:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 331F360273 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C99386B006C; Mon, 13 Sep 2021 16:10:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4711940008; Mon, 13 Sep 2021 16:10:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B37F6940007; Mon, 13 Sep 2021 16:10:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id A79156B006C for ; Mon, 13 Sep 2021 16:10:19 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 510442B350 for ; Mon, 13 Sep 2021 20:10:19 +0000 (UTC) X-FDA: 78583642158.29.904F6DC Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf16.hostedemail.com (Postfix) with ESMTP id 1C8DCF000092 for ; Mon, 13 Sep 2021 20:10:18 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id lb1-20020a17090b4a4100b001993f863df2so901361pjb.5 for ; Mon, 13 Sep 2021 13:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FZZEMatov1ywQnlAFEuJS6XYFerKWwr4EqDpdXQaYcY=; b=Ygg3+TCcneorxzC43CXi9+QyVczta/m/dbbyX3FF4p4pFOnwBjsvFsPD0MCpK+rS+8 MtRQIToFoyvhTo9TAdj9NRx8XGnX1qIKNQ4Ql6K8TG9kJRiQamhZGJn5p8PMfGtW+Dqw 0CeQzz/5MYNPtsGK3b2RP9vz+zAuUppw6n4ob2yrSE0jOHmfr0Y/suOcCdB8kJFxJ4FH J+mFbropaOv/dta3lHwW1ogpb1SUc4GfQK261qmDht/Q3rs2u46pWH+EwNSntxm1nclD vklzSZYYi5/FIVa9m8NXWF7XLbikHgRT2kMp1UfuZv5VUbIgEMe/gnApk+nJFDFPiCJ8 I4kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=FZZEMatov1ywQnlAFEuJS6XYFerKWwr4EqDpdXQaYcY=; b=eeKJP93gNIiSYG3S/Et20wSd6Dwgptm5sQua0JUIcS8h9Z7NkCJR8XWKP9KHfbkFt5 Y77azpNK1O5Dm3sEiF1ksEuvEArmlWvHSEpj1g20tkZX4gHfRbvlA8LSZo/oYcDddkKD hX8b9D9thQOwP5dx/k3t2xSmHh0RmuhrjwtxFoDx9v3b6Jod/152BtYIjAP1melPvngc cGuhiumJBDPD/A28oCfOy1YTLBTdn7MOIMsMSNIs8ZOBOCAEGG77ik4lM7ePO0qRkIIy 4wk8342Nb/9kuKqnFU/l5Dq4KVGr9TwZ70mMSxtB+ZBD05tFZglkAhQyG0OPl2QJ39Hz 3JPw== X-Gm-Message-State: AOAM531C+vAZVPfX4cMO9Dbva0c63zvoOLCwydl7byA0QDoI29aYaJGa XgB7JemoesZ8m9ApXWO0KHo= X-Google-Smtp-Source: ABdhPJx4vPt3BujS6XT0VkIhVx8lcxyx2fXBRc0yjYsLsD9r5Z+HcPsVMJ5W9tQZKVB6D5yB5hQIGQ== X-Received: by 2002:a17:90b:3ec6:: with SMTP id rm6mr370730pjb.68.1631563817871; Mon, 13 Sep 2021 13:10:17 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-e24f-43ff-fee6-449f.res6.spectrum.com. [2603:800c:1a02:1bae:e24f:43ff:fee6:449f]) by smtp.gmail.com with ESMTPSA id c21sm7912657pfd.200.2021.09.13.13.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Sep 2021 13:10:17 -0700 (PDT) Date: Mon, 13 Sep 2021 10:10:16 -1000 From: Tejun Heo To: Shakeel Butt Cc: Feng Tang , Hillf Danton , LKML , Xing Zhengjun , Linux MM Subject: Re: [memcg] 45208c9105: aim7.jobs-per-min -14.0% regression Message-ID: References: <20210905124439.GA15026@xsang-OptiPlex-9020> <20210907033000.GA88160@shbuild999.sh.intel.com> <20210912111756.4158-1-hdanton@sina.com> <20210912132914.GA56674@shbuild999.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ygg3+TCc; spf=pass (imf16.hostedemail.com: domain of htejun@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1C8DCF000092 X-Stat-Signature: 77iojd49bsha6mhy3h7oodd9mg5oqgkr X-HE-Tag: 1631563818-128442 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 13, 2021 at 01:09:11PM -0700, Shakeel Butt wrote: > Thanks a lot for the explanation. Are there any concerns to call > cgroup_rstat_flush_irqsafe(root_mem_cgroup->css.cgroup) in system_wq? > This will be called every 2 seconds, so, we can assume the updated > tree would be small most of the time. I can't think of a reason why this would be problematic. Thanks. -- tejun