From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38944C433F5 for ; Sun, 30 Jan 2022 16:10:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C6146B0072; Sun, 30 Jan 2022 11:10:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 575316B0073; Sun, 30 Jan 2022 11:10:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 463756B0074; Sun, 30 Jan 2022 11:10:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 369C06B0072 for ; Sun, 30 Jan 2022 11:10:12 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E358D96F01 for ; Sun, 30 Jan 2022 16:10:11 +0000 (UTC) X-FDA: 79087440222.24.99C4A3D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf06.hostedemail.com (Postfix) with ESMTP id 9B7DF18000C for ; Sun, 30 Jan 2022 16:10:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0803B82978; Sun, 30 Jan 2022 16:10:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D731C340E4; Sun, 30 Jan 2022 16:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643559007; bh=/1u+pt8tW21RlrDy+BIpS9Rs86AWcPQauetCdYmv3S0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uOnyLq9OMTt+pt4Z50QiU3CskGVIet0bd1d2jbv2pg7TcyH81wpyyK0SyZrc3gwGI sjsqxZ1XNyFwMHCFvAo7omM9VjRlnacgXFaQ/MNYSxf5CoXslGXY6U8N4jIYUzZcYh UcxIBPW0+3LcXHxsc8/4nP70im3Zz2IWGMc9x//3H6P6YQtk2hxC0l5CdQ2MTfI4PO 02hqV3CAh7C55r5iRCH6K15GcG05F2eGHQx2NDkO1kpmfP6+pw9+nfXaGfTnMaCWNX Y1vx2Of1QESqL4bJso/inQELLbH1174nq/PaCB5hHWbkBJP9pfYFkgjhDgqVe0XeEn IgKPUcJFpW+6g== Date: Sun, 30 Jan 2022 18:10:00 +0200 From: Mike Rapoport To: Karolina Drobnik Cc: Matthew Wilcox , linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/16] tools/include: Add io.h stub Message-ID: References: <2d9aa000afe81b45157617664134b871207c2067.1643206612.git.karolinadrobnik@gmail.com> <48499a57afb3d27df26b39aa4255b4ba583c1148.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <48499a57afb3d27df26b39aa4255b4ba583c1148.camel@gmail.com> X-Stat-Signature: yneifhzk7kpdu8mmf1fxtyxdd5wyu8an X-Rspam-User: nil Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uOnyLq9O; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9B7DF18000C X-HE-Tag: 1643559010-371878 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 28, 2022 at 12:21:59PM +0100, Karolina Drobnik wrote: > On Thu, 2022-01-27 at 14:09 +0000, Matthew Wilcox wrote: > > On Thu, Jan 27, 2022 at 02:21:25PM +0100, Karolina Drobnik wrote: > > > Add a dummy io.h header. > >=20 > > Rather begs the question of what memblock.c needs from linux/io.h. > >=20 > > Wouldn't it be better to: > >=20 > > +++ b/mm/memblock.c > > @@ -18,7 +18,6 @@ > > =A0#include > >=20 > > =A0#include > > -#include > >=20 > > =A0#include "internal.h" > >=20 >=20 > That was something I considered in the very beginning, but didn't have > a chance to verify it works for all architectures. I can take a look > after I'm finished with other v2 changes. >=20 > > (allmodconfig on x86-64 builds fine with this; I have not done an > > extended sweep of other arches / build options). I did a sweep for defconfigs for all arches and all were fine. Karolina, please send the formal patch. Let's see how kbuild bot reacts. --=20 Sincerely yours, Mike.