From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A436AC00144 for ; Fri, 29 Jul 2022 19:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E57348E0001; Fri, 29 Jul 2022 15:02:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E06286B0072; Fri, 29 Jul 2022 15:02:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA6B58E0001; Fri, 29 Jul 2022 15:02:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BC5E06B0071 for ; Fri, 29 Jul 2022 15:02:18 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8351E1A1647 for ; Fri, 29 Jul 2022 19:02:18 +0000 (UTC) X-FDA: 79741057956.07.04B7D75 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf18.hostedemail.com (Postfix) with ESMTP id 1D0681C00D6 for ; Fri, 29 Jul 2022 19:02:17 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id h21-20020a17090aa89500b001f31a61b91dso6410823pjq.4 for ; Fri, 29 Jul 2022 12:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=LkO9SgTZ2fPl2HYX0gFonlaXjyZgw7WltwbfzzP2PWU=; b=LcCMO/BfHtLr67gbUfFYeZ2DnL0Qe15D/zjxvFdRRh7VmNk7LN5oMsc24VO/GmbV/U PuV6l97/eHoUtKDyH52SVtPAZ87OnqBus/o63uyQuFgufZzCyq9XsxfOUYAdERS1Jgqd Z8e1N8bqzr0z8QDItDcXKcyyEaabrG/16s5zoaP1WRFBF4Ue7XuTf8xaQCPaAoBgg974 KUIBiMYBx36eqSObwBq4p2WXddbpg1bPZ34gDbt+XQiuHO4akXNCCqBoLF/FeCnzUG2i XE9mksL3i7ZMYBmA4SOK8RBlplgWMUQ4wTuOLsTMqyyIK0ibz34Lq8CE9D2iQAq/i5AS iEgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=LkO9SgTZ2fPl2HYX0gFonlaXjyZgw7WltwbfzzP2PWU=; b=YZuGMWGr9fFIGdA4yDO2nvE/Oq6jMYlYeYYZ3bFhQ+TDBqqZZ7MHZYi+p8cz0ddt6m FCWUHfwTfnNYz3z/K7xb7aDEKtXVUP25/TEy9n98B26p1VWv+yswgRQiRThxFMSGuBTn Dc1zkmw91yhpkxwEwnxKCaOGdO4Ueomjenlmdl3f+HYN8EkLUuAW0qWOhmmfYACc/eYK g1/CZsdobyZuUJim7wTqtvHz2wHXwE9YWFaq9vi/HJKcWztXiALEY9o/MOU45P2VwXEi gq/pq98fVPDGAkR7RKVetB6amU9Gr5DZxaqQa5gctXR5nDBdvmhj9mzw/LXqszbNiVIK CJvA== X-Gm-Message-State: ACgBeo1AksMOcZWnTnlHBi30lTzlQpNWqNYx7FR+57/BO1TG2qnVRBkg s+MsRjABdp3MOOFAzFGQQuhtmg== X-Google-Smtp-Source: AA6agR6iqcQsub1nBR7JRnM5qfcyEbknlTLsOfU5kvnAs7e7vtoc0LC7cubgKQlDwv2I4efPq2wL9Q== X-Received: by 2002:a17:90a:2ec5:b0:1f2:ea66:c832 with SMTP id h5-20020a17090a2ec500b001f2ea66c832mr6318473pjs.31.1659121336897; Fri, 29 Jul 2022 12:02:16 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id n16-20020a170902e55000b0016d5cf36ff8sm4042180plf.274.2022.07.29.12.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jul 2022 12:02:16 -0700 (PDT) Date: Fri, 29 Jul 2022 19:02:12 +0000 From: Sean Christopherson To: Chao Peng Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song Subject: Re: [PATCH v7 08/14] KVM: Rename mmu_notifier_* Message-ID: References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220706082016.2603916-9-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220706082016.2603916-9-chao.p.peng@linux.intel.com> ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="LcCMO/Bf"; spf=pass (imf18.hostedemail.com: domain of seanjc@google.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659121338; a=rsa-sha256; cv=none; b=n6CG/GCjc0FIPT0l3zAiJYUixQSK8+sE8kGHg7k42VetFLq7MNhp2xEhitwvGfWnHNCH5r ssb3Yxyr3gtNczF4PObqOYsVQDVr9uHh/LWXtvQKOtTC8W+1mH8/GpdOXgr0h9ASS09LWj YrbLC0pUmZG7yIi8/n4nUI1+bLknIuA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659121338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LkO9SgTZ2fPl2HYX0gFonlaXjyZgw7WltwbfzzP2PWU=; b=Wq4tKiC2Q3i3fD1OFznOdFIpzaU0WV1vPA3vxt6rsc6Azq0kjWQMpWznHLkyLYjYiijiFy 3b2Uq+EHQguSi3nJCPymQHlib2Q96g2wIeVUHssUBR8msHv31y5hAosJPTnSHKr1wLYVNX QoiBL5pLIH0X7Iyl7FXm9VCkHfD6LCM= X-Stat-Signature: yr5zijhutyrmwe1dd5o3dgzq4zjwzgct X-Rspamd-Queue-Id: 1D0681C00D6 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="LcCMO/Bf"; spf=pass (imf18.hostedemail.com: domain of seanjc@google.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam02 X-HE-Tag: 1659121337-792122 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 06, 2022, Chao Peng wrote: > The sync mechanism between mmu_notifier and page fault handler employs > fields mmu_notifier_seq/count and mmu_notifier_range_start/end. For the > to be added private memory, there is the same mechanism needed but not > rely on mmu_notifier (It uses new introduced memfile_notifier). This > patch renames the existing fields and related helper functions to a > neutral name mmu_updating_* so private memory can reuse. mmu_updating_* is too broad of a term, e.g. page faults and many other operations also update the mmu. Although the name most definitely came from the mmu_notifier, it's not completely inaccurate for other sources, e.g. KVM's MMU is still being notified of something, even if the source is not the actual mmu_notifier. If we really want a different name, I'd vote for nomenclature that captures the invalidation aspect, which is really what the variables are all trackng, e.g. mmu_invalidate_seq mmu_invalidate_in_progress mmu_invalidate_range_start mmu_invalidate_range_end