From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D9F2C6FA99 for ; Tue, 7 Mar 2023 20:27:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A25806B0071; Tue, 7 Mar 2023 15:27:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D4E06B0073; Tue, 7 Mar 2023 15:27:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87585280001; Tue, 7 Mar 2023 15:27:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7876A6B0071 for ; Tue, 7 Mar 2023 15:27:33 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 45C891A0EAE for ; Tue, 7 Mar 2023 20:27:33 +0000 (UTC) X-FDA: 80543237586.18.75CA341 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf26.hostedemail.com (Postfix) with ESMTP id 7A9B7140018 for ; Tue, 7 Mar 2023 20:27:31 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=OwwLfDPK; spf=pass (imf26.hostedemail.com: domain of 3Mp4HZAYKCLMlXTgcVZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3Mp4HZAYKCLMlXTgcVZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678220851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WGcASroMdccxdn62Jjtjh8PVnJGDXhBcjr99ONuCvY4=; b=qqbDDuStOMRNy6Di+3EiajshoyWrxN2N4Gh9ob/kPHRZ0CNJRabjTpwG0gvhGxeChv5un1 AqOWsAVzyr93iMKu7WqS4F4kllx3FCW+051O+IAk8xdsB/B1DViaVm8xJ+2BDihv8TYgBD y0ME17LYqXdKOfSNf3jYOMB0w4w1eq8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=OwwLfDPK; spf=pass (imf26.hostedemail.com: domain of 3Mp4HZAYKCLMlXTgcVZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3Mp4HZAYKCLMlXTgcVZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678220851; a=rsa-sha256; cv=none; b=QCBGu8CS6lAzYSnCVCH21J1k2B6+O0PQtV75j0CVh2zZzo8+/JYdlT3u7W9Djlt/s9Jxn9 TA7uCnfGXLAsqosXCAX2ZrnAOeRzhds6PIetl1qTkGdA+/NyYyN6NBvQ+ER18Ya5otRS+J yX8r78K757hpNLkteLis2vLBht+223w= Received: by mail-pl1-f201.google.com with SMTP id k3-20020a170902ce0300b0019ca6e66303so8245341plg.18 for ; Tue, 07 Mar 2023 12:27:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678220850; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=WGcASroMdccxdn62Jjtjh8PVnJGDXhBcjr99ONuCvY4=; b=OwwLfDPKljzAkPvlj0S/FrolNQFkMYhVCSYaPZA6BhlyFeubRSg3vonk6akM+nwgAx dcS6vYx/LWgfF4nSPN+n5wRbJl1+oX04X/RQuea86YN+QKQuGEhXA8GHTKbpJNljgVbg 1tgLB7KavCS6Q8io76xaUiHKm29QSamSGbG7VBUDlQZNg7fOcC8uJ1SLfFlvvf38+NHp H0+zdtAOsLWl91QdOI5eJY+EmcNzqsXqCw01IvZ9IrObznTsFWqkSsLtumj8X2Gb549e mgTJkRz7STcC9OGGE966xqlp75dxFmI9JO9DcpLgaboo61ZXNHLGYkcot+ahXB1p5gKf Im0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678220850; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WGcASroMdccxdn62Jjtjh8PVnJGDXhBcjr99ONuCvY4=; b=DYO5C96mwsKQ0LGY3tJfW8tJw7NbPngzCnEUmlhozR4P3MfeyX7dSGOKo3cd/QeNHb DUIY0LeVMV+LoOpZ63qH4bkL2Z7zHAL8g1FsCPsopDPv3GmNpo/9Ncg8k5bUgxGQZHnz Heev2YtjSapEEZwd8T0+z+Gm5Og1DQGKBzc3f9boml7RBygf6nsry/rZz5PD6dZH2vsx MmUXHl4bzXnrxuB2/sgRdh81b/q/+XNU80HfYZpGz2rUynPL2ptjL+Ba4HoeJEAkhgFM 1E7yMBfvdyISHiGJMHnLdRmXinJMHyaW2UGwm4RIxEmiblmvqCUfOLw/1oLiH12SQRyA ye7w== X-Gm-Message-State: AO0yUKWZz8iHlxHjSR8bq1kJUKhgtzReITyn6wkXmj0M9zTb1DJ0U5e6 jFUomXQz3RHSbPQD9f7HQbAig91o78w= X-Google-Smtp-Source: AK7set9n+PBGh5X4bHcHssSmlZaRESH4dUDPeHJTAkKKGP+YbNHu8+uM5MNsGFpRsbe7uC0L5WQKdFmMJ3c= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:2948:0:b0:503:7bcd:9806 with SMTP id bu8-20020a632948000000b005037bcd9806mr5442294pgb.4.1678220850029; Tue, 07 Mar 2023 12:27:30 -0800 (PST) Date: Tue, 7 Mar 2023 12:27:28 -0800 In-Reply-To: Mime-Version: 1.0 References: <20221202061347.1070246-10-chao.p.peng@linux.intel.com> Message-ID: Subject: Re: [PATCH v10 9/9] KVM: Enable and expose KVM_MEM_PRIVATE From: Sean Christopherson To: Ackerley Tng Cc: Chao Peng , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, pbonzini@redhat.com, corbet@lwn.net, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, arnd@arndb.de, naoya.horiguchi@nec.com, linmiaohe@huawei.com, x86@kernel.org, hpa@zytor.com, hughd@google.com, jlayton@kernel.org, bfields@fieldses.org, akpm@linux-foundation.org, shuah@kernel.org, rppt@kernel.org, steven.price@arm.com, mail@maciej.szmigiero.name, vbabka@suse.cz, vannapurve@google.com, yu.c.zhang@linux.intel.com, kirill.shutemov@linux.intel.com, luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, qperret@google.com, tabba@google.com, michael.roth@amd.com, mhocko@suse.com, wei.w.wang@intel.com Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 7A9B7140018 X-Stat-Signature: 1dktnrpbw6zpdoupbtexfohcea33ys11 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678220851-5250 X-HE-Meta: U2FsdGVkX18Ofa1DV5/B8AgHevBf+5jvjVGZ2bv1armqByk6VU2gHrX+lnXBmJRSlH0RqFjPbDP/V8XFO6q3p+wkT0TXUuUgE1JN1g/gN1mnVbKO7ElNnLb4j8tCnU/IlE09KsDbcmbGAsyI3IZX7e36kLUVcL2rwU1i+JrUiLHdzYv/sucaJ7+lgLmvwPf3aNMbt5Z8KJ4S5zGo3qUNB13aNxLS/sZoBgIvJnLt1mAM6NISoQd3FTHXtEdiyyW1sO2nPYzgZv9LamP41cY+es7UEuexEg7mkvU/9OEWKu9HpNj+Ct1uRxpfkWX8i3+eEvzQ/QSLiQHm2ZMOfA9bwrauOxo85VwjA1s+Jm31PzVgb19FpMYuVF4E+DwAk2USnCiUdNQ6x/zot6zKGyipS9sBW9exGsRQs8iqpDSp1ddEdX6prztiIOioG0DWBhVrcjHbNYWLlsxsZZVIjiROVpzVZzfjMRD8JVKhrRaoohY2QLS379AMTiwKPsmeHCA+d1Fi+MnTOLlkJDARsbyBY3h8F6QU/687BKf3DEF/m0kuO7boumyGh8k1un8IV4lBQ6xnvtcFzrQaimWPzEZJmmu7RsRYpjFC3nWinwDHUVTgRSyB1rsALV37EfvmCsirOCJiiXudGEaLlj/wBNBi9jr8vgnqODLVyfBDgmPIZALxhJQKxU3ss5Se7RHDVZEyt6pHl2qTbxJLbANfDx0MXzpgHApZ5mEDHV060sQylMJdagh9T6/Av/86v1CqBLd6xfXwO3RET+3/nBcNBZcWfHDz8K9fVzpMi7RngyGze8ksDwNM9kdqYcuqnoU56MYKz+T2Ds2nsXv4zoed1mHC4HHFhgDXC7+1YhxSXpyhwIRyNwfUtoJB2hlFh2ZCkHdYvrdx9XW+x67kJPDeTYjctEWM6b1GB/uuxLtZ7BY+BvYFosNZirGCmFkiv2I9+DQD6u+s8x9gCtcBMDR/Q3J I19B0Gtt 88WC4I/RbnNZeK2eBfpK25ufCaoRGIF1M2uEKaJXSEl/w19zf9FA2/Yi9F8S9FF1zc/d8OTMsTOAk2GN6gEPx8imAVj/aCUqDEynHvjA5TcXMsdjC/8UyTMEep6CI12XNQ2Yiq48MkP8MxJqU34rHsf4DCtyzUtpnMFfDSKksvU30jL3rWvcT5v+jKkgCG3lRzh2cVs4XU6HACojQtAs/znUsw3ngcY04EOmhmW/OzUJHMb3jwUl7UvwTwHMFr3m30eSLVh0eSJmGFMgmqsp/pipukqs0UqQm7dE9kC6hjIHKBgF4VuEHMx9bFUyE+cFAfgBeDoybXpVHw5aKpcmswqUV2EhcfWL3oa3+xYN6krXMf+blsX649NhNdRtmD11TOrZnYcc/CgnvMl0esMBrlFt1JRayiMNR5Kb+lpAmxReghREMrAJGlnOKR3OGmrjqFjJYc/TZcs73BkQK5d57/cDl95aYRoB9DOhDoDddkIqSJvnPFY0yuzeOFba7uuhXMbeknXb5vWF7+N3tg0m6lEbSBRozgC9uYxWB9oub1yMSx6yYQX/VVFSWO1YGxtnoVB/2sQSGuYIBujOV70hMDF8VDl0SjPqwaa24RlNHPbEMj961SI4cPX+9Ryib8V9vlyLBm0WsePClWtgluX6NY7SjsKAox9GrWaAh3iYoqR3ICa8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Please trim your replies so that readers don't need to scan through a hundred or so lines of quotes just to confirm there's nothing there. On Tue, Mar 07, 2023, Ackerley Tng wrote: > Chao Peng writes: > > > Register/unregister private memslot to fd-based memory backing store > > restrictedmem and implement the callbacks for restrictedmem_notifier: > > - invalidate_start()/invalidate_end() to zap the existing memory > > mappings in the KVM page table. > > - error() to request KVM_REQ_MEMORY_MCE and later exit to userspace > > with KVM_EXIT_SHUTDOWN. > > > Expose KVM_MEM_PRIVATE for memslot and KVM_MEMORY_ATTRIBUTE_PRIVATE for > > KVM_GET_SUPPORTED_MEMORY_ATTRIBUTES to userspace but either are > > controlled by kvm_arch_has_private_mem() which should be rewritten by > > architecture code. > > Could we perhaps rename KVM_MEM_PRIVATE to KVM_MEM_PROTECTED, to be in > line with KVM_X86_PROTECTED_VM? > > I feel that a memslot that has the KVM_MEM_PRIVATE flag need not always > be private; It can sometimes be providing memory that is shared and > also accessible from the host. > > KVM_MEMORY_ATTRIBUTE_PRIVATE is fine as-is because this flag is set when > the guest memory is meant to be backed by private memory. > > KVM_MEMORY_EXIT_FLAG_PRIVATE is also okay because the flag is used to > indicate when the memory error is caused by a private access (as opposed > to a shared access). > > kvm_slot_can_be_private() could perhaps be renamed kvm_is_protected_slot()? No to this suggestion. I agree that KVM_MEM_PRIVATE is a bad name, but kvm_is_protected_slot() is just as wrong. The _only_ thing that the flag controls is whether whether or not the memslot has an fd that is bound to restricted memory. The memslot itself is not protected in any way, and if the entire memslot is mapped shared, then the data backed by the memslot isn't protected either. What about KVM_MEM_CAN_BE_PRIVATE? KVM_MEM_PRIVATIZABLE is more succinct, but AFAICT that's a made up word, and IMO is unnecessarily fancy.