From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FEB3C7619A for ; Wed, 12 Apr 2023 13:04:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDC746B0075; Wed, 12 Apr 2023 09:04:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8D8C6B0078; Wed, 12 Apr 2023 09:04:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7B5B900002; Wed, 12 Apr 2023 09:04:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B9DB76B0075 for ; Wed, 12 Apr 2023 09:04:40 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7B5F080107 for ; Wed, 12 Apr 2023 13:04:40 +0000 (UTC) X-FDA: 80672758320.07.3C5622D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 39AC114000A for ; Wed, 12 Apr 2023 13:04:36 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=H4xjivd+; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681304677; a=rsa-sha256; cv=none; b=AJ1eyXKc/EUjUX72RC1AlgGBfO8cQk92ajsfjUzbLEbbSlFsrFOuHN3N+aepfWTUyr75EA 1bvZOyTimPnGKIGkiO8uCiYdciS/QEzGBlLAmo+c3zoh3s9xVBxHRIaQDnvZqSFOzWq/8D fd/qHE3q3IF/6Hc+uHW++/OKcqR8ARg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=H4xjivd+; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681304677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2u4C6fn8rcBG4p3IFP1tSLcJySxwgo6iZPmr/m9xEiI=; b=Im75xt5xy3uoomSFDmtdwxKH1fe58jjjON6LlQ+y4xrMLxLDgmIYSfI2BuBIE9yDmK84ut E3A8AR6ufLlhfrL32fLan70y8+N4UCyPToYXBFXYG06byxH0C9x7x8b9sCg2SFg8gyZJMM skxBXuogQQspzv3sgeb2S/TE24rrRIQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2u4C6fn8rcBG4p3IFP1tSLcJySxwgo6iZPmr/m9xEiI=; b=H4xjivd+25lajydBPWRap7/1zZ aWg+3k1OaiDh87KsoSgA13s5fv6UMEsDgKGzWIj4D22ZYXeT9xIOzjjsQiBPh3jXhTgenMvx1HCwO DADm48N/N6gPoQG7FXWDtJ5AybjAgJkQ5Dq/E0eHqnL5i4N7xwMNXEpWqXv68C6QM4szljLD5LW3/ VjzJqOpXGXgSVafz9ythipDVQdJDkRkSre5JBdWC2CYafk3pbSsqF9Dbysz9SjXuFP3AWUzMgdKNo Npv2J94oLBpboWl+UZMXzryV6EmpaxGdbj77ypZR9T6/OCfg+A+oXZNMh6Unyd5DoRxBIiV+XKJcq h3FZe16g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pma9J-006ssP-D2; Wed, 12 Apr 2023 13:04:33 +0000 Date: Wed, 12 Apr 2023 14:04:33 +0100 From: Matthew Wilcox To: Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/rmap: convert __page_{set, check}_anon_rmap() to folios Message-ID: References: <20230412021811.1503281-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230412021811.1503281-1-yajun.deng@linux.dev> X-Rspam-User: X-Rspamd-Queue-Id: 39AC114000A X-Rspamd-Server: rspam01 X-Stat-Signature: go6hsbsobpir1u9kfhpgm31z9wjgz74s X-HE-Tag: 1681304676-759897 X-HE-Meta: U2FsdGVkX19wHkweOWFK1VHzCrl+p/1aRxtXQ/Cy+Yz9nh4hPHMnLMjDiPVAsQRDUR35mLOPStsIZCrOVcyGNGM7945lTjL+MIIVw9Ah6UcQBB3pKDJ+2qU0h0B6MfNEorhA/ajvKQahmbW91otCrkQnI6n++WpOEpqzirpK/gWp+lgnV8bTLmPaAthc+aifRUdaU73HIyq0CuLSz3CPjiTj6P1hJNKwhBPknxz5+XYS+mGSMJ5uMqtJvpYqMBU5ehuwhLcUnfe3U4aUQRAMwmlZQqPDKTWtKH5De24+WJY5xZ5oGnRfxM0xV+qYYmq37GPcd00tFHlmgfRgnH9Od1CbRCA1aS9/0zoXETRzdVHH45PVfqnVAVXf8I8ZF2U8nzdUri0yRrIQDh9t/WC2dmrw8vBTIvAQymOhzfKo88TdoFiaIpyORTF/YutoRbwskA3HRvr+UhllNVLk7RJyhDO3JscxrNGXXLBOiHFN5eEan/IN78zkKU/86FgjdIvoX1g7XgXzODCtUvR3bExgPso9nlCARfwxJ8zkQK9NftLHq0b6RGZwDJQtV1yI61qv5/+m0nTbThdM65CJlGobPLuUNb2NPJMmpNQanXC4axey2vPeMQjJLZqHhCamw0isCboiul25nryB5+pbLpvLLzHJhZQpHJVD6bcIKKep71ECiNeECGCpG3zKXpSw2l5ieuKYaHt3Fo0OsvrWtNA3je8Dvj2UEE6yGNDFPt0boL/vk/GUoq2WStFARAg4ZWe5flA3lAhm+U7XJicNnpXi7Q8+9EOMnvzfqY5GNdB9jf+4yB7xyCbUnA5elwcrT/sZG19mq6QrLjvk6RwSxEpdKr15/+Rh2S5Cy2nalAibMS/ie2BJlgMf1i1tEnH6cYF2//DyFHoDBBh/nXD1vDoOWXbJVSeLZJxnUBM+lOBdrTXBxFO5X+7614oWetQIwgLTXe/KSCW52Ggj8hvpvHe gPZZtZLA S2rSo2Erk19Qut9eVBK/cmpEIvFPKHbIv5BhclvV0Yv3cii5CRKpLqylmfDd4q7fUFY6iCkAM2ZgufA7AKsg0PhY8vjPb8JkPH/KwbtW3pBsinNnX1pUkZz/ZSzNF1hnCS8akjRNeyOWkLhjQR3oNFwaNeLCAB7pxTL/RTDkEoZG19XfQbuBhG/J5EBnxK+Z08oQhE16XK14E4Ok= X-Bogosity: Ham, tests=bogofilter, spamicity=0.020644, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 12, 2023 at 10:18:11AM +0800, Yajun Deng wrote: > The 2nd parameter in __page_set_anon_rmap() is only used by > SetPageAnonExclusive(), so there is no need to put > SetPageAnonExclusive() in __page_set_anon_rmap(). > > Remove SetPageAnonExclusive() from __page_set_anon_rmap() and modify > __page_set_anon_rmap() to __folio_set_anon_rmap(). > > Since __page_check_anon_rmap() needs a folio, we can directly use > and change it to __folio_check_anon_rmap(). I do not think this is an improvement.