From: Matthew Wilcox <willy@infradead.org>
To: Stefan Roesch <shr@devkernel.io>
Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com,
mhocko@suse.com, david@redhat.com,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
akpm@linux-foundation.org, hannes@cmpxchg.org,
Bagas Sanjaya <bagasdotme@gmail.com>
Subject: Re: [PATCH v6 1/3] mm: add new api to enable ksm per process
Date: Wed, 12 Apr 2023 17:29:38 +0100 [thread overview]
Message-ID: <ZDbccpmPVU5RRPws@casper.infradead.org> (raw)
In-Reply-To: <qvqwfs9513mn.fsf@devbig1114.prn1.facebook.com>
On Wed, Apr 12, 2023 at 09:08:11AM -0700, Stefan Roesch wrote:
>
> Matthew Wilcox <willy@infradead.org> writes:
>
> > On Tue, Apr 11, 2023 at 08:16:46PM -0700, Stefan Roesch wrote:
> >> case PR_SET_VMA:
> >> error = prctl_set_vma(arg2, arg3, arg4, arg5);
> >> break;
> >> +#ifdef CONFIG_KSM
> >> + case PR_SET_MEMORY_MERGE:
> >> + if (mmap_write_lock_killable(me->mm))
> >> + return -EINTR;
> >> +
> >> + if (arg2) {
> >> + int err = ksm_add_mm(me->mm);
> >> +
> >> + if (!err)
> >> + ksm_add_vmas(me->mm);
> >
> > in the last version of this patch, you reported the error. Now you
> > swallow the error. I have no idea which is correct, but you've
> > changed the behaviour without explaining it, so I assume it's wrong.
> >
>
> I don't see how the error is swallowed in the arg2 case. If there is
> an error ksm_add_vmas is not executedd and at the end of the function
> the error is returned. Am I missing something?
You said 'int err' which declares a new variable. If you want it
reported, just use 'error = ksm_add_mm(me->mm);'.
next prev parent reply other threads:[~2023-04-12 16:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 3:16 [PATCH v6 0/3] mm: process/cgroup ksm support Stefan Roesch
2023-04-12 3:16 ` [PATCH v6 1/3] mm: add new api to enable ksm per process Stefan Roesch
2023-04-12 13:20 ` Matthew Wilcox
2023-04-12 16:08 ` Stefan Roesch
2023-04-12 16:29 ` Matthew Wilcox [this message]
2023-04-12 15:40 ` David Hildenbrand
2023-04-12 16:44 ` Stefan Roesch
2023-04-12 18:41 ` David Hildenbrand
2023-04-12 19:08 ` David Hildenbrand
2023-04-12 19:55 ` Stefan Roesch
2023-04-13 9:46 ` David Hildenbrand
2023-04-12 3:16 ` [PATCH v6 2/3] mm: add new KSM process and sysfs knobs Stefan Roesch
2023-04-12 3:16 ` [PATCH v6 3/3] selftests/mm: add new selftests for KSM Stefan Roesch
2023-04-13 13:07 ` David Hildenbrand
2023-04-13 13:08 ` David Hildenbrand
2023-04-13 16:32 ` Stefan Roesch
2023-04-13 18:09 ` Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDbccpmPVU5RRPws@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=shr@devkernel.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).