From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 963C2C77B6E for ; Wed, 12 Apr 2023 20:08:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10509900003; Wed, 12 Apr 2023 16:08:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B4CF900002; Wed, 12 Apr 2023 16:08:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBFA3900003; Wed, 12 Apr 2023 16:08:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DD1EB900002 for ; Wed, 12 Apr 2023 16:08:47 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B44C5140148 for ; Wed, 12 Apr 2023 20:08:47 +0000 (UTC) X-FDA: 80673827094.14.0E72018 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 2C562100010 for ; Wed, 12 Apr 2023 20:08:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IYMMtcMU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681330125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hdO2/I6wOUQxoSSiwra0n4gQA+gYUisy/Yi9wlX79ws=; b=G5AC4goblRSVv9aAE0sowdS23YL+ioe2UIyOoI31rjh1LvUnr6ZKwWy4VIzg+pZzgl6FAm K6VIKGi2D/fIU5flMu6HgH2S/NQ+wTb+C25SCoMTp9VdNTB15p79K9qcgxgJyQ/iMUB0SM THZQsAc35XcokVk4YjesPfo5qMejISM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IYMMtcMU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681330125; a=rsa-sha256; cv=none; b=sR4kQQaoGzJlfVSBjLjpRnDv9x+N2CiTMlDH9tCuGkmWUOmHklVJAVKoIBDjtzUVMz2LXp 6ZnAFtHZDaEu+OuMuwAME0oooTCOkOIhrQynNckU53OZHrWG1O/VBWTd3oO7hovhBD52NA CfECsRavI0loeZt9dAXfsH1J1XJ9yQo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681330124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hdO2/I6wOUQxoSSiwra0n4gQA+gYUisy/Yi9wlX79ws=; b=IYMMtcMUYDY0GnlyCM2cz5lCn7rVygF+uyKWEh6KqGB3tj1WULi4GpebgskGkvfEGAO9zi Jsco+vmsGBPDnSJ2RFUnkxk1SnSv0kfivEfPhBCUYNkcq2s96OKDW30PUL0rHw9NYwMdVx +fr6C0umMG5Ir+P+AUbvR1FGB2sUBhE= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-gQLCmsF_MRqVuWetnORr4g-1; Wed, 12 Apr 2023 16:08:39 -0400 X-MC-Unique: gQLCmsF_MRqVuWetnORr4g-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-74a904f38f3so88174085a.1 for ; Wed, 12 Apr 2023 13:08:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681330119; x=1683922119; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hdO2/I6wOUQxoSSiwra0n4gQA+gYUisy/Yi9wlX79ws=; b=WYn+pCPeDGCMVhn3s8y3vmYWv2itTRxh1wbpu3DdZ/yKKcQu4bq3oELH4g2QOHSMbL BYHenFCT25ZeDLUCE2qs8zIwfQjDe2Q+c656kMSOKRd9hMBF6h38KfMpwRexefNJx8T1 C679rCuH2mtudEoMoVP5Pp0JvyGsTCEBUwby2pOE9XjR9mpgGlycEiP2zySdKQOb2FzJ k4VBIB8iuEr2TERZldm9M8OElgD+m1D74PH1i6S2ZKWYHQE7oMgKzG3+7UuDDuYBp/aX 3Nh2LoamocKb3Plo5lYrN4Vg0tDMIVC7xNtPOP6EF/iD3euFCWVM6yqhA20Y0bGUXWN5 wGUA== X-Gm-Message-State: AAQBX9fXLPhsDvLdGKCxhOaxXsDNN5KW1iBwydi/F9Uau6QpewHBXXyQ iSjWn0K6qT3I1Q1WTo83ggcTlDh2YmswFlUZ1Z7mZsJVtm8VbUwdWpsCrfkM/a4cSxBB3w1efYZ NRKyrfnW2lws= X-Received: by 2002:a05:6214:401a:b0:5aa:14b8:e935 with SMTP id kd26-20020a056214401a00b005aa14b8e935mr5581612qvb.2.1681330119267; Wed, 12 Apr 2023 13:08:39 -0700 (PDT) X-Google-Smtp-Source: AKy350bX1oAtWowJaU6wuzfTqtxyW4XmdGaEUQDzVIuNdn57ibnNFhftBPj9Nv0c9ckS+f1wdk5+SQ== X-Received: by 2002:a05:6214:401a:b0:5aa:14b8:e935 with SMTP id kd26-20020a056214401a00b005aa14b8e935mr5581584qvb.2.1681330118958; Wed, 12 Apr 2023 13:08:38 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id pe6-20020a056214494600b005e938eb99ecsm3618698qvb.122.2023.04.12.13.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 13:08:37 -0700 (PDT) Date: Wed, 12 Apr 2023 16:08:36 -0400 From: Peter Xu To: Axel Rasmussen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Andrea Arcangeli , Mike Kravetz , Nadav Amit , David Hildenbrand , Mike Rapoport , Leonardo Bras Soares Passos Subject: Re: [PATCH v2 16/31] selftests/mm: UFFDIO_API test Message-ID: References: <20230412163922.327282-1-peterx@redhat.com> <20230412164257.328375-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2C562100010 X-Stat-Signature: h13tafgmp75kmtxuq8c77ur8kbuidgcr X-HE-Tag: 1681330125-402963 X-HE-Meta: U2FsdGVkX187E05YFxMIaOMP3cRr3t6V+F1k7IMpHZnaF6L/kzw9NZbc6xShQVpuRZyrnNgrKgj+Bw1YP5McZT+b6AzKGQWJxjMB7qa0EnhBdRrmDlF+kF6uVN5CJQ7MjoMCvOLYu710mWKBv9cYDhWZGB6QgwKvXSntqBe9KFEDx/pTcIwbY6twg888CuKoZ1RWyDVrYT2RfpF+rWPVmnGCJtmTMKNZX4CmwGItEFbKGpN3MlVp+7IJ+wAH6fTDFnCjQKMCy8PM3KqnNsMOl5REEDvUi5MxsxHp97DENsxdM4MAw0i8YnTM7dafe2d2YWe/vLkvDwJVKodlNW2iVT58/x43hNdITSpi9U8IVX/Tg4P7X7GC8DfjHhr9J+X0I18Qrpk/Nqiv8ujh7orqG1QtAca3MpYKIi+CrYMjm4/qYgTeepzoK6XxNDiXIvbEAbaKupcKgDP034Sr1A5TLRrl702huwbbLQxCpy27Ggd5jp9M9dZvf0dfRYtJd+z8v5KFKqcw8uCANyRLYNS09Sk2KceNLsQmR0AylyOT1cQk9Yx3t1LiAfueREbxJJ42+42Ck35yvm+dzpd1poR0MuV2fvdpqR8rZc3KC1ujArdVungFVfoRfW0ypHE+FpS0w+V9jvSQgNY0OgJ0t/MWm/7KRcoj4dk8XIM3k7/m2ZUbz7JWjTz+f9Rtj/h/yPX2IymL9lZhiYjA/sPxCLtxo6BmhKIw1XspkJqpGt5W+xDaGRxlyv1hJjtGUKM8eWQR0kaXK4vYubL2G9ymZNZ29xtzn5xFpUG3Usom29vqx+R0ZRD6BX5PQCE5yDuNhy3T6VZB2Z62MiJqY7H/6XA9ZCsDFsAP52Rniwjq6XnO/XF+L4hw0M9k3NQ0U2dqTeRWyn56+w+0tsAY+Xqax6lwAkQ0XLxz23C99B1XObZRwt4eUcE2JJx7zSozsLXRnd0EDy0yRypG2548bNzTdPw 7jqaFvCO Gb4Y5QGUvPKGFK3n6uu34+JZsW628mhMY+yp4YnLtGrW4QoYumt6cf8zBaNa21Rl1etFDLXsaWMmdXnYWoHlmwyNQ47bRvMJG9dmt/T7jf6jxbM34IZTZcbcQYa7gYjMFQU9Rf9cwWWVTIXkvq1I01+SJ8XE+uFhbkPoRC4oB3ewfwrIYyyKbHXnWESQGmya9KKc0oG/vt5bWR4pqW8i4boH3+tWf+/qe533jLsc3ZBZmQfGtVRkfoz2O5sWwiol+5Nw59wLT6rz1PqdL/zx+tsNqDdIResjrbZ27OW5ahpDkBFQoYXwtKKXhcbsgFrlMK+nldBWafsNJbcRqmeotf9WUc4nNr3Z91ZBGkc+4/WkPOcuixsG8W9rgEgOZpHAvbUMFNCX5eFAdMRVTWfA0SIvgp5VRewZoA8oIfSwfzkgEWJ0KyC8myesZ6xN7skgXAI/VjEYDmGlZ+UoWz/tGGcPCwfnoBumXJCcIEpB6zC/w/CNuPLDt9ljL7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.027675, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 12, 2023 at 12:47:39PM -0700, Axel Rasmussen wrote: > > +#define uffd_test_fail(...) do { \ > > + printf("failed [reason: "); \ > > + printf(__VA_ARGS__); \ > > + printf("]\n"); \ > > + ksft_inc_fail_cnt(); \ > > + } while (0) > > + > > +#define uffd_test_skip(...) do { \ > > + printf("skipped [reason: "); \ > > + printf(__VA_ARGS__); \ > > + printf("]\n"); \ > > + ksft_inc_xskip_cnt(); \ > > + } while (0) > > Some of this is duplicating what's in kselftest_harness.h - e.g. > assertions, printing test summary, keeping track of pass/fail/skip > counts, etc. > > I wonder how you feel about using the standard harness? E.g. is the > plan to do this (more straightforward?) refactor first, and then > switch later? Or is there some reason it can't be used? David asked similar question. I wanted to arrange the output mostly for: (1) one test per line, (2) dump test name before anything (even failing). The 2nd one is important for uffd tests since it uses err() which bails out immediately on unexpected failures (comparing to uffd_test_fail). To achieve that I found I can use ksft_inc_xskip_cnt() etc. so I kept using the counters in the harness but leave the print format on my own. I assume that's also why these were exported in kselftests.h so when tests want to have customized output it can still use the counters. Thanks, -- Peter Xu