From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F460C7619A for ; Wed, 12 Apr 2023 22:01:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 042046B0074; Wed, 12 Apr 2023 18:01:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0D1D900003; Wed, 12 Apr 2023 18:01:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D86A6900002; Wed, 12 Apr 2023 18:01:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C64E66B0074 for ; Wed, 12 Apr 2023 18:01:45 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9595B1602A3 for ; Wed, 12 Apr 2023 22:01:45 +0000 (UTC) X-FDA: 80674111770.23.E0D0980 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf02.hostedemail.com (Postfix) with ESMTP id 84C4480026 for ; Wed, 12 Apr 2023 22:01:43 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=itcYyHsT; spf=pass (imf02.hostedemail.com: domain of 3Rio3ZAYKCJ8RD9MIBFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--seanjc.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3Rio3ZAYKCJ8RD9MIBFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681336903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FXF6AhQnwp1n/IhYSnfZVqcASsRtZ9yL6mJXzW8Mi9w=; b=aBTbFUWdCjNa04byKSegYZJNXvM0lYOVwKrpsJwdyOks6+RtBvpRARAJcr+vPOhxmqgdKz U4FM/zMAc+GKGWXgsXpsSsXtha89EdOxDdBrqpx8uPYc6ayLwOVs+cCod5TUeEZ6alUuZX 5nYahkeKSqMjJ46g+/E6VZVd9mLjEBo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=itcYyHsT; spf=pass (imf02.hostedemail.com: domain of 3Rio3ZAYKCJ8RD9MIBFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--seanjc.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3Rio3ZAYKCJ8RD9MIBFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681336903; a=rsa-sha256; cv=none; b=K1or1P/S33lMhBR2/Y02h3BelqcR9AtHPO6ZtE3cy6JJUJbsmO9S++iR6YBmGyoRyIexF8 zWmYF2BdXZ59O1Ll9OVhASX3hr9ChoHP23akvz0LivL1PwCkvApaspSPBJbV+xbKOQx4d8 +lTOKUwobNRySIhqeXJeTI9h6OS9UME= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-54efad677cbso123909687b3.6 for ; Wed, 12 Apr 2023 15:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681336902; x=1683928902; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=FXF6AhQnwp1n/IhYSnfZVqcASsRtZ9yL6mJXzW8Mi9w=; b=itcYyHsTjH+BWioeMOzHRsDUxYxnEou8ifBndkBXI6TNX5xq/HUkT1AyyhCCB+jlgg 3qhGiIFyP5GPmeAb9F/cGYLL0T6ndH4Anu3KiFTJ2zgUv7rYRpICAgBSTO4SmMWQG2dj 4lYV/RthfLCJMCgdpXeycR2egix1Qp8q862Y6ehJoE8Zrk7VpCCp7zEkzxGBY8nv1lJY RZQCmJ4imt199cSg173cMIapT9cfLep+3yZW0B5b36RF/xqQ9iUnS4egjGE1JSQeu6db gbh/vWlrrOQUF9lx8wSU9AC22JYq+cM0a/46K9zgrM+CGG4alQS9oe5dHDfglVggicdO Y9Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681336902; x=1683928902; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FXF6AhQnwp1n/IhYSnfZVqcASsRtZ9yL6mJXzW8Mi9w=; b=iTepzqaOo4NeW+ABKXNE1Hw0b+p6OChZPvfcYGCA9oAd4AVMyHdz9/KR1/2CRTxqnm /+99+LvcB4OnrO0dpsqKErot4siMTTLi3DEkJBerZxbrxEByvoyxcmE1PwooZqumWR3m I5laY7IxU6MMxyGV6vWmm9HR/WSyGOaYNKGtTfsLXb0LFruiU3R8w6n/UXLyv+ZyiJlp bTWW+qlxle8Rhj41RZSJ8Efzly9uT7craQf+RSoIk0QcXNzINcShrZ4iOdIv9fqCR3eW 0vWzx6vqOYf90Rrpb84Qayicig2EyJBbq5pBVXBsyklxFFVUeo8LA8ekeIJkgrBAI6uB SPqg== X-Gm-Message-State: AAQBX9c0U00it0vq80kHimxTDoSzjTKWJqHlcoCA7ZXUOh94/qEsAh7T djpgY6PSP2I6+nnpmCUVWCgG/zFIKOk= X-Google-Smtp-Source: AKy350artxVLouCy5UXXqGRd6vaUaGCzjJlbptUimGvT0630mPFw3RBlFaQsm42qDt42zFcnXgHxxlmRTKU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:cc07:0:b0:b8b:fe5f:2eaa with SMTP id l7-20020a25cc07000000b00b8bfe5f2eaamr43241ybf.2.1681336902548; Wed, 12 Apr 2023 15:01:42 -0700 (PDT) Date: Wed, 12 Apr 2023 15:01:41 -0700 In-Reply-To: <20230323012737.7vn4ynsbfz7c2ch4@amd.com> Mime-Version: 1.0 References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20230119111308.GC2976263@ls.amr.corp.intel.com> <20230119223704.GD2976263@ls.amr.corp.intel.com> <20230213130102.two7q3kkcf254uof@amd.com> <20230221121135.GA1595130@chaop.bj.intel.com> <20230323012737.7vn4ynsbfz7c2ch4@amd.com> Message-ID: Subject: Re: [PATCH v10 0/9] KVM: mm: fd-based approach for supporting KVM From: Sean Christopherson To: Michael Roth Cc: Chao Peng , Isaku Yamahata , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, mhocko@suse.com, wei.w.wang@intel.com Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: tfdjrfa3s4dnj1pjghjbz8fkrhojdyu6 X-Rspamd-Queue-Id: 84C4480026 X-HE-Tag: 1681336903-286278 X-HE-Meta: U2FsdGVkX1+FOsepFyFysChbXDxkM1YlqEnayi82wW1sGmcnwh5sMeZF2By84MtE2iICMnJb6RJMNqtj0yXHGKvKgCJO9iRP6TNnBqJ+pzWU+EJ095IhdTIzoWkJiXfbTbggJVyAfGPQTxhM6NZWKN0o0dpLLyT+y2szAu9MerP1hksxgaZohbCTTbdkJG9+fc121/mUkHwH6a1WhGAB6g8atSGatAFdqQA/0M4WrRRB6h0gv9eRH0exz4GvfynVFQjcGqn8PMsIs8QqykTbeMhentmSRsYzN/wy1xAsMYbzh63o1lf9x5SE/7ns8t12urcKxdbQcRmA8cugoA7QHJ730Lq3QcuRb0Cp/6ImqWy5klBXBbmKUlgLdHmeX0kXpS7zUuBOvSa5Us3e4us8Dvcbh/deD6VRWfX/BygmsvevofQ0accWLW2vvSPO0JeyA2gq1s7eJ5HDpTTIrcmqdwZgopSVUJGwkU0QDLixKvCu/XrtF8J2VRzF6ju3ryYHsU7O6am8h+QiR6du6e1y1+UD/+9H2r2tV2YM8DUECdyV0jBaerS3SclG1EiBBLvRT7Kr4hN4tGwHZZ3VwKZlB2S2h+JbDHVUN6aG+6bnu+NRSLaSy31QvGsoojSWke/YrnGseD0mqTQPq4/1voIC2xNCVzPt0BjAWoC4B3qEyvPaP0j45MAg3/+cp2VUn6nAM2dqJGrejvLnxaQOlMRmiBXA9sndIev2tiw6Gag+OMEmIPsSe7TCg8WyMNJ2fKmMgX+DtHT3bztVB8VI572zJ8lsSCHuNb0QLOweQ1H2ucjOOk4DiOZo6O4vITnYKtA50WafTU8aPS49kQrnnPi4OVbcUUxafI8UxblHCgbGjWOu8+7giy4CgzwmrITmZsb/+CiqCChz/oSxDnLN5fLPx/kENDkCE2WBH98LBZKmKfitjIliwEtEUNjoXgto3n3LBfvEwGUlGlv7Z+1Spuh sbPPAGaz Kjn35xuuzP7T1+nN6YY3nfWekbiPGbxSinciWbZ3VwHKddm1wdfpHxAZoeXxRNgUdGLomVWSIWEzv1oJq6w291rZeOH3zgWbRPTrVJHhvNsxhbIDi0ebuzfkNMcbWMRmgidUm6BGNKYhYczJUncF5JcTVbjk/EG+sAh5DpKTuUyqieEwPR03+WeqkBy0hlw55ZgP00s7SRhLASgcTlRW/UIH7A2BvuEkZvi+ikIrdFbzyuu1J2Tr2U1ICs2xn0rYGBB9SgM4kREDrcw3Po1U7zyiB1Nr1+g283tuy7oN1lZj0DYDwG8zsHgf5DfUSIbNTOb25GTGXqmunrVoPCpwrzosiUUwYD4JLsXOTmZeuaFr4TwuEu9zTYGQWuzN6fdAgNQp8J61VRr1u12cuhoYyNjSUHXCAoRKYaDgzMvGxRQoiZfjtK9xSB1jZbRdU9ldfMblWGpP95SVWEQS9C8cWNvN1LQ9C4CItTuJaa6S4ze4weSQfQjTvaM6llVCkKr903nlAvVPyhbgJ1Dghj5b9xdv//QkcGsa6XTZsUpV8vTTCI2dHPgzS7ZWweLu2iQJVvvEpRlniwifGAJP4k1YDP37tAHEJMmajts4DbiHaXcXq/rNHtHykISVVhLp+nW9UVm/fzP94r2UcO8sGrGT/OLDl3uHKFZ79EAhq36M4kuSo8t13FROU0z2us3+mOI7w+RVo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 22, 2023, Michael Roth wrote: > On Tue, Feb 21, 2023 at 08:11:35PM +0800, Chao Peng wrote: > > > *fixup (upm_base_support): KVM: use inclusive ranges for restrictedmem binding/unbinding > > > *fixup (upm_base_support): mm: restrictedmem: use inclusive ranges for issuing invalidations > > > > As many kernel APIs treat 'end' as exclusive, I would rather keep using > > exclusive 'end' for these APIs(restrictedmem_bind/restrictedmem_unbind > > and notifier callbacks) but fix it internally in the restrictedmem. E.g. > > all the places where xarray API needs a 'last'/'max' we use 'end - 1'. > > See below for the change. > > Yes I did feel like I was fighting the kernel a bit on that; your > suggestion seems like it would be a better fit. Comically belated +1, XArray is the odd one here.