From: Chris Li <chrisl@kernel.org>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitaly.wool@konsulko.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nathan Chancellor <nathan@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH -next v9 0/3] Delay the initialization of zswap
Date: Wed, 3 May 2023 17:11:58 -0700 [thread overview]
Message-ID: <ZFL4Tvm8KKrCfjRr@google.com> (raw)
In-Reply-To: <20230411093632.822290-1-liushixin2@huawei.com>
Hi Shixing,
On Tue, Apr 11, 2023 at 05:36:29PM +0800, Liu Shixin wrote:
> In the initialization of zswap, about 18MB memory will be allocated for
> zswap_pool. Since some users may not use zswap, the zswap_pool is wasted.
> Save memory by delaying the initialization of zswap until enabled.
Sorry I am late to this discussion. I notice you are already at V9.
Anyway, I am curious how much of the 18MB was came from the zswap_pool
alone and how much of it came from the other part of the initialization.
If it is the zswap_pool alone, it means that we can have a smaller patch
to get most of your 18M back.
I also notice you move a lot of __init function back to normal functions.
That would mean those functions wouldn't be able to drop after the
initialization phase. That is another reason to move less of the initialization
function.
Chris
next prev parent reply other threads:[~2023-05-04 0:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 9:36 [PATCH -next v9 0/3] Delay the initialization of zswap Liu Shixin
2023-04-11 9:36 ` [PATCH -next v9 1/3] mm/zswap: remove zswap_entry_cache_{create,destroy} helper function Liu Shixin
2023-04-11 9:36 ` [PATCH -next v9 2/3] mm/zswap: replace zswap_init_{started/failed} with zswap_init_state Liu Shixin
2023-04-11 9:36 ` [PATCH -next v9 3/3] mm/zswap: delay the initialization of zswap Liu Shixin
2023-04-12 15:20 ` Christoph Hellwig
2023-05-04 0:11 ` Chris Li [this message]
2023-05-04 7:11 ` [PATCH -next v9 0/3] Delay " Liu Shixin
2023-05-04 14:53 ` Chris Li
2023-05-08 1:37 ` Liu Shixin
2023-05-20 15:33 ` Chris Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFL4Tvm8KKrCfjRr@google.com \
--to=chrisl@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=nathan@kernel.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).